Bug #58115 MTR should restart slaves between tests if master needs restart

• Submitted: 10 Nov 2010 14:52
• Modified: 7 Dec 2010 12:54
• Reporter: Bjørn Munch
• Status: Closed
• Category: Tools: MTR / mysql-test-run
• Severity: S3 (Non-critical)
• Version: 5.1+
• OS: Any
• Assigned to: Bjørn Munch
• CPU Architecture: Any

[10 Nov 2010 14:52] Bjørn Munch

Description:
After Bug #57840, it may happen that only the master is restarted between tests.

In trunk (5.6) this lead to some tests then failing because the slave complained that the master had changed UUID.

An ignore was added but this shouldn't be done. In stead, we should restart slave(s) also when the master is restarted.

How to repeat:
Currently this triggers it in trunk-bugfixing:

./mtr rpl.rpl_flush_logs rpl.rpl_incident

[10 Nov 2010 14:53] Bjørn Munch

Even though a problem was only seen on -trunk, we should fix this from 5.1 where Bug #57840 was done.

[12 Nov 2010 13:46] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123729

3111 Bjorn Munch	2010-11-12
      Bug #58115 MTR should restart slaves between tests if master needs restart
      As we check for servers to restart, tag the tinfo if the master is restarted,
      then check (after all other checks) for slave restarts.

[18 Nov 2010 15:36] Bjørn Munch

After discussing this with the 2nd reviewer, it was concluded that the log warning about changed UUID is the result of the previous test does not clean up the state properly.

This should be fixed with Bug #49978 and so the slave restart will not be needed. I will however push this to trunk-bugfixing (where 57840 has been pushed) so that I can also remove the suppression of the warning. This can then be undone once 49978 has been merged.

[18 Nov 2010 17:08] Bjørn Munch

Pushed to trunk-mtr, will be merged to trunk-bugfixing soon.

[18 Nov 2010 19:42] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/124298

2988 Bjorn Munch	2010-11-18
      Bug #58115 MTR should restart slaves between tests if master needs restart
      As we check for servers to restart, tag the tinfo if the master is restarted,
      then check (after all other checks) for slave restarts.
      Removed suppression of UUID warning which is now avoided

[5 Dec 2010 12:42] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (version source revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

[7 Dec 2010 12:54] Paul DuBois

Changes to test suite. No changelog entry needed.