Bug #54161 MTR: disabled.def lists don't work with FQ test names

• Submitted: 1 Jun 2010 21:30
• Modified: 14 Oct 2010 15:40
• Reporter: Luis Soares
• Status: Closed
• Category: Tools: MTR / mysql-test-run
• Severity: S3 (Non-critical)
• Version: mysql-next-mr
• OS: Any
• Assigned to: Luis Soares
• CPU Architecture: Any
• Tags: mtr

[1 Jun 2010 21:30] Luis Soares

Description:
MTR: disabled.def lists doesn't work with FQ test names

If storing a fully qualified (FQ) test name in disabled.def, mtr
will ignore this entry and not disable the test. A FQ names is
something like:

 rpl.rpl_spec_variables

Checked with:

 - tree:  mysql-next-mr
 - revid: [e-mail]-20100531075105-3d1v24etiu1x3c7h

How to repeat:
1. bzr clone -r revid:[e-mail]-20100531075105-3d1v24etiu1x3c7h mysql-next-mr
2. cd mysql-next-mr
3. bash BUILD/compile...
4. cd mysql-test
5. vi suite/rpl/t/disabled.def
   <append rpl.> to rpl_spec_variables
(...)
rpl.rpl_spec_variables             : BUG#47661 2009-10-27 jasonh rpl_spec_variables fails on PB2 hpux

6. perl mtr rpl.rpl_spec_variables
--> Observe MTR *NOT* disabling the test case <--

Suggested fix:
Make MTR work with the suite in disabled.def.

[1 Jun 2010 21:49] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/109821

3398 Luis Soares	2010-06-01
      BUG#54161: MTR: disabled.def lists don't work with FQ test names
      
      MTR will ignore fully qualified test name entries in disabled.def 
      lists. Therefore, it would still run the test case, even if it is
      listed.
      
      This patch fix this by extending the check when marking the test
      case as disabled to take into consideration not only the cases that
      contain the simple test name but also those that contain fully 
      qualified test names.

[1 Jun 2010 21:55] Bjørn Munch

Patch looks reasonable, but I wonder why you need this?

[1 Jun 2010 22:15] Luis Soares

Context: WL#5408.

I need this for WL#5408, so that I can specify multiple disabled lists 
each with entries containing FQ test names. If I don't have that, I risk
disabling tests with the same name but under different suites. So if I
want to disabled test suite1.test1 and not suite2.test1 I could not do
it just by simply adding:

  "test1 : my precious comment" 

to the list.

[2 Jun 2010 11:14] Bjørn Munch

Ok I see the point. The if/else can be simplified as:

# Test name may have been disabled with or without suite name part
$tinfo->{'comment'}= $disabled->{$tname} || $disabled->{"$suitename.$tname"};

[2 Jun 2010 11:21] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/109949

3398 Luis Soares	2010-06-02
      BUG#54161: MTR: disabled.def lists don't work with FQ test names
      
      MTR will ignore fully qualified test name entries in disabled.def 
      lists. Therefore, it would still run the test case, even if it is
      listed.
      
      This patch fix this by extending the check when marking the test
      case as disabled to take into consideration not only the cases that
      contain the simple test name but also those that contain fully 
      qualified test names.

[2 Jun 2010 11:29] Bjørn Munch

Patch is good.

[17 Jun 2010 6:13] Bugs System

Pushed into 5.5.5-m3 (revid:[e-mail]-20100615145247-8bj0vmuqlotbqsn9) (version source revid:[e-mail]-20100602121647-82wb33qj5afnz0ft) (merge vers: 5.5.5-m3) (pib:16)

[17 Jun 2010 6:16] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100615150216-cubqoyn1fj9b6a2p) (version source revid:[e-mail]-20100607075151-xjus8wzgjv3g9ok0) (pib:16)

[17 Jun 2010 19:41] Paul DuBois

Test suite changes. No changelog entry needed.

[19 Jul 2010 14:35] Bugs System

Pushed into 5.1.49 (revid:[e-mail]-20100719143034-omcma40sblwmay3x) (version source revid:[e-mail]-20100602121330-wh0qye84rg13i5ej) (merge vers: 5.1.48) (pib:16)

[23 Jul 2010 12:26] Bugs System

Pushed into mysql-trunk 5.5.6-m3 (revid:[e-mail]-20100723121820-jryu2fuw3pc53q9w) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:18)

[23 Jul 2010 12:33] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100723121929-90e9zemk3jkr2ocy) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (pib:18)

[14 Oct 2010 8:37] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 8:52] Bugs System

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 9:07] Bugs System

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 15:40] Jon Stephens

Setting back to Closed; see above.