MySQL Bugs: #52913: Check if there are any tests for mysqlhotcopy, and add them if there aren't

Bug #52913	Check if there are any tests for mysqlhotcopy, and add them if there aren't
Submitted:	17 Apr 2010 4:51	Modified:	14 Oct 2010 14:45
Reporter:	Roel Van de Paar	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Tests	Severity:	S7 (Test Cases)
Version:		OS:	Any
Assigned to:	Horst Hunger	CPU Architecture:	Any

Description:
Check if there are any tests for mysqlhotcopy, and add them if there aren't.

Customer ran into issues due to bug #43594 and would like to verify that any patch created would be tested properly.

How to repeat:
N/A

Suggested fix:
Add tests for mysqlhotcopy if there currently aren't any.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108160

3381 Horst.Hunger	2010-05-12
      Patch for bug#52913: Tests for mysqlhotcopy.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/109695

3403 Horst.Hunger	2010-06-01
      Patch for bug#52913 including the review results.

I have experimented with the patch and emailed a modified diff of the MTR change.

Please change dates like
   "# Created: 10.05.2010"
to ISO format
   "# Created: 2010-05-10"

The tests survived my high load test with tmpfs and disk.

ok to push

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/110060

3412 Horst.Hunger	2010-06-03
      Patch for bug#52913 including all review results.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/110061

3412 Horst.Hunger	2010-06-03
      Patch for bug#52913 including all review results and changes of date format.

Review sent by email:
I experimented with some changes, in particular the test could not
handle the case where mysqlhotcopy isn't available.

I also removed some redundant lines from the .test files, which were
in the .inc file.

Enclosed is a new diff (not a diff to the diff). I haven't been able
to test the tests as I haven't got the required DBI/DBD stuff
installed.

That is another problem: those tests quite possibly will fail in PB2
due to missing DBI/DBD install.

The tests do not check the existence of mysqlhotcopy and skip in case it is not existing. As the script is mandatory, the test fails, if it is not existing, also if the script is not executable.

As the tests are new and due to bug#54129 I set them to experimental. That will also show if somrthing in PB is missing.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/110205

3415 Horst.Hunger	2010-06-04
      Patch for bug#52913: Inserted check if mysqlhotcopy script is existing as requested by review. DIsabled the test until bug#54129 will befixed.

OK with this follow-up fix, die is probably better than skip since it's an error for mysqlhotcopy not to be there.

Oops, forgot to change status.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/110212

3089 Horst.Hunger	2010-06-04
      merge of patch for bug#52913 from 5.1-bugteam to trunk-bugfixing. Changed $basedir to $bindir in mysql-test-run.pl.

Pushed to 5.1-bugteam and merged to trunk-bugfixing and next-mr-bugfixing.

Pushed into 5.5.5-m3 (revid:alik@sun.com-20100615080459-smuswd9ooeywcxuc) (version source revid:alik@sun.com-20100615080459-smuswd9ooeywcxuc) (merge vers: 5.5.5-m3) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100615080558-cw01bzdqr1bdmmec) (version source revid:alik@sun.com-20100615080431-gu5icn0anrt47dsx) (pib:16)

Pushed into 5.5.5-m3 (revid:alexey.kopytov@sun.com-20100615145247-8bj0vmuqlotbqsn9) (version source revid:georgi.kodinov@oracle.com-20100604160950-usx33mwczmow3i5e) (merge vers: 5.5.5-m3) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100615150216-cubqoyn1fj9b6a2p) (version source revid:alik@sun.com-20100607075151-xjus8wzgjv3g9ok0) (pib:16)

Changes to test cases. No changelog entry needed.

Pushed into 5.1.49 (revid:build@mysql.com-20100719143034-omcma40sblwmay3x) (version source revid:horst.hunger@sun.com-20100604085318-455z5sppq1hzwmu7) (merge vers: 5.1.48) (pib:16)

No changelog entry needed.

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)

Closed; tesing only.