MySQL Bugs: #51696: RESTORE: rename SKIP_GAP

Bug #51696	RESTORE: rename SKIP_GAP_EVENT
Submitted:	3 Mar 2010 16:12	Modified:	15 Mar 2010 9:16
Reporter:	Paul DuBois	Email Updates:
Status:	Patch queued	Impact on me:	None
Category:	MySQL Server: Backup	Severity:	S3 (Non-critical)
Version:	6.0	OS:	Any
Assigned to:	Assigned Account	CPU Architecture:	Any

Description:
From email discussion:

Paul,

The RESTORE statement has a SKIP_GAP_EVENT option. But I have 
> noticed that you backup folks tend to refer to the associated
> event as an "incident event" and rarely or never as a "gap
event." This being so, why isn't the option named 
> SKIP_INCIDENT_EVENT?

Yes, Paul, that is the case. The concept was originally called a gap event but later changed to incident event to make it more generic. Sadly, we have not changed the name of the option. I encourage you to open a bug report on this to have it changed or, if you prefer, I will open the bug report.

Note: It is named incident event in the code.

Chuck

How to repeat:
Check the grammar.

Suggested fix:
Rename to INCIDENT_EVENT?

Thank you for the bug report.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/102714

3108 Ritheesh Vedire	2010-03-09
       BUG#51696: RESTORE: rename SKIP_GAP_EVENT
      
       SKIP_GAP_EVENT was introduced as an option for RESTORE
       on a master. To make the option more generic, it was 
       decided to rename the SKIP_GAP_EVENT as SKIP_INCIDENT_EVENT
       and to eliminate the term 'gap event' and it's assosiates
       in the backup code.
      
        This patch replaces all the occurences of 'gap event' and it's 
        assosiates with 'incident event'.
     @ mysql-test/suite/rpl/t/rpl_backup.test
         Replaced the option.
     @ sql/backup/backup_kernel.h
         Replaced the term.
     @ sql/backup/kernel.cc
         Replaced the term.
     @ sql/lex.h
         Changed the token.
     @ sql/si_objects.cc
         Modified comment.
     @ sql/sql_parse.cc
         Replaced the term.
     @ sql/sql_yacc.yy
         Replaced the term  in the grammar.

Good to push.

Problem found with rpl_backup test in that performance of the test is really, really bad. We should not proceed with this patch until the cause of the performance problem is solved first.

To be clear, I am expecting the developer to research the performance issue and determine if there is a problem and to act on that problem. I want to see this analysis before I approve the patch. That is all.

Analysis of the problem accepted. Thanks, Rith.

Patch approved pending changes outlined in commit reply.

Setting the bug to its correct state. Patch Approved.
Performance issue with rpl.rpl_backup.test is BUG#51956.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/103183

3108 Ritheesh Vedire	2010-03-15
      BUG#51696: RESTORE: rename SKIP_GAP_EVENT
                 
        SKIP_GAP_EVENT was introduced as an option for RESTORE
        to signal discontinuity in the binary log. To make the option
        more generic, it was decided to rename SKIP_GAP_EVENT as 
        SKIP_INCIDENT_EVENT and to eliminate 'gap event' and 
        its related terms from the backup code.
       
         This patch replaces all the occurrences of 'gap event' with
        'incident event'.
     @ mysql-test/suite/rpl/r/rpl_backup.result
        Updated result file.
     @ mysql-test/suite/rpl/t/rpl_backup.test
         Replaced SKIP_GAP_EVENT command option with
         SKIP_INCIDENT_EVENT command option and updated 
         the comments.
     @ sql/backup/backup_kernel.h
        Replaced skip_gap_event variable with skip_incident_event.
     @ sql/backup/kernel.cc
         Replaced the term skip_gap_event with skip_incident_event
         and updated the comment.
     @ sql/lex.h
        Replaced SKIP_GAP_EVENT and SKIP_GAP_EVENT_SYM with
        SKIP_INCIDENT_EVENT and SKIP_INCIDENT_EVENT_SYM
        respectively.
     @ sql/si_objects.cc
        Updated comment.
     @ sql/sql_parse.cc
        Renamed the 'gap event' variables to 
        'incident event' variables.
     @ sql/sql_yacc.yy
        Updated the grammar non-terminals with 'incident event' terms.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/103186

3110 Ritheesh Vedire	2010-03-15
       BUG#51696: RESTORE: rename SKIP_GAP_EVENT
                       
       SKIP_GAP_EVENT was introduced as an option for RESTORE
       to signal discontinuity in the binary log. To make the option
       more generic, it was decided to rename SKIP_GAP_EVENT as 
       SKIP_INCIDENT_EVENT and to eliminate 'gap event' and 
       its related terms from the backup code.
             
       This patch replaces all the occurrences of 'gap event' with
       'incident event'.
     @ mysql-test/suite/rpl/r/rpl_backup.result
        Updated result file.
     @ mysql-test/suite/rpl/t/rpl_backup.test
        Replaced SKIP_GAP_EVENT command option with
        SKIP_INCIDENT_EVENT command option and updated 
        the comment.
     @ sql/backup/backup_kernel.h
        Replaced skip_gap_event variable with skip_incident_event.
     @ sql/backup/kernel.cc
        Replaced the term skip_gap_event with skip_incident_event
        and updated the comment.
     @ sql/lex.h
        Replaced SKIP_GAP_EVENT and SKIP_GAP_EVENT_SYM with
        SKIP_INCIDENT_EVENT and SKIP_INCIDENT_EVENT_SYM
        respectively.
     @ sql/si_objects.cc
        Updated comment.
     @ sql/sql_parse.cc
        Renamed the 'gap event' variables to 
        'incident event' variables.
     @ sql/sql_yacc.yy
        Updated the grammar non-terminals with 'incident event' terms.

Pushed to mysql-next-mr-backup.
revision-id: ritheesh.vedire@sun.com-20100315091257-m1dzbue7z1ejzeyi