Bug #51696 | RESTORE: rename SKIP_GAP_EVENT | ||
---|---|---|---|
Submitted: | 3 Mar 2010 16:12 | Modified: | 15 Mar 2010 9:16 |
Reporter: | Paul DuBois | Email Updates: | |
Status: | Patch queued | Impact on me: | |
Category: | MySQL Server: Backup | Severity: | S3 (Non-critical) |
Version: | 6.0 | OS: | Any |
Assigned to: | Assigned Account | CPU Architecture: | Any |
[3 Mar 2010 16:12]
Paul DuBois
[3 Mar 2010 23:53]
MySQL Verification Team
Thank you for the bug report.
[9 Mar 2010 13:39]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/102714 3108 Ritheesh Vedire 2010-03-09 BUG#51696: RESTORE: rename SKIP_GAP_EVENT SKIP_GAP_EVENT was introduced as an option for RESTORE on a master. To make the option more generic, it was decided to rename the SKIP_GAP_EVENT as SKIP_INCIDENT_EVENT and to eliminate the term 'gap event' and it's assosiates in the backup code. This patch replaces all the occurences of 'gap event' and it's assosiates with 'incident event'. @ mysql-test/suite/rpl/t/rpl_backup.test Replaced the option. @ sql/backup/backup_kernel.h Replaced the term. @ sql/backup/kernel.cc Replaced the term. @ sql/lex.h Changed the token. @ sql/si_objects.cc Modified comment. @ sql/sql_parse.cc Replaced the term. @ sql/sql_yacc.yy Replaced the term in the grammar.
[10 Mar 2010 7:37]
Rafal Somla
Good to push.
[10 Mar 2010 22:01]
Chuck Bell
Problem found with rpl_backup test in that performance of the test is really, really bad. We should not proceed with this patch until the cause of the performance problem is solved first.
[10 Mar 2010 22:05]
Chuck Bell
To be clear, I am expecting the developer to research the performance issue and determine if there is a problem and to act on that problem. I want to see this analysis before I approve the patch. That is all.
[12 Mar 2010 13:49]
Chuck Bell
Analysis of the problem accepted. Thanks, Rith. Patch approved pending changes outlined in commit reply.
[15 Mar 2010 8:45]
Ritheesh Vedire
Setting the bug to its correct state. Patch Approved. Performance issue with rpl.rpl_backup.test is BUG#51956.
[15 Mar 2010 9:01]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/103183 3108 Ritheesh Vedire 2010-03-15 BUG#51696: RESTORE: rename SKIP_GAP_EVENT SKIP_GAP_EVENT was introduced as an option for RESTORE to signal discontinuity in the binary log. To make the option more generic, it was decided to rename SKIP_GAP_EVENT as SKIP_INCIDENT_EVENT and to eliminate 'gap event' and its related terms from the backup code. This patch replaces all the occurrences of 'gap event' with 'incident event'. @ mysql-test/suite/rpl/r/rpl_backup.result Updated result file. @ mysql-test/suite/rpl/t/rpl_backup.test Replaced SKIP_GAP_EVENT command option with SKIP_INCIDENT_EVENT command option and updated the comments. @ sql/backup/backup_kernel.h Replaced skip_gap_event variable with skip_incident_event. @ sql/backup/kernel.cc Replaced the term skip_gap_event with skip_incident_event and updated the comment. @ sql/lex.h Replaced SKIP_GAP_EVENT and SKIP_GAP_EVENT_SYM with SKIP_INCIDENT_EVENT and SKIP_INCIDENT_EVENT_SYM respectively. @ sql/si_objects.cc Updated comment. @ sql/sql_parse.cc Renamed the 'gap event' variables to 'incident event' variables. @ sql/sql_yacc.yy Updated the grammar non-terminals with 'incident event' terms.
[15 Mar 2010 9:13]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/103186 3110 Ritheesh Vedire 2010-03-15 BUG#51696: RESTORE: rename SKIP_GAP_EVENT SKIP_GAP_EVENT was introduced as an option for RESTORE to signal discontinuity in the binary log. To make the option more generic, it was decided to rename SKIP_GAP_EVENT as SKIP_INCIDENT_EVENT and to eliminate 'gap event' and its related terms from the backup code. This patch replaces all the occurrences of 'gap event' with 'incident event'. @ mysql-test/suite/rpl/r/rpl_backup.result Updated result file. @ mysql-test/suite/rpl/t/rpl_backup.test Replaced SKIP_GAP_EVENT command option with SKIP_INCIDENT_EVENT command option and updated the comment. @ sql/backup/backup_kernel.h Replaced skip_gap_event variable with skip_incident_event. @ sql/backup/kernel.cc Replaced the term skip_gap_event with skip_incident_event and updated the comment. @ sql/lex.h Replaced SKIP_GAP_EVENT and SKIP_GAP_EVENT_SYM with SKIP_INCIDENT_EVENT and SKIP_INCIDENT_EVENT_SYM respectively. @ sql/si_objects.cc Updated comment. @ sql/sql_parse.cc Renamed the 'gap event' variables to 'incident event' variables. @ sql/sql_yacc.yy Updated the grammar non-terminals with 'incident event' terms.
[15 Mar 2010 9:16]
Ritheesh Vedire
Pushed to mysql-next-mr-backup. revision-id: ritheesh.vedire@sun.com-20100315091257-m1dzbue7z1ejzeyi