MySQL Bugs: #51393: Server start fails with MTR

Bug #51393	Server start fails with MTR_VERSION=1 on Solaris SPARC
Submitted:	22 Feb 2010 15:36	Modified:	6 Mar 2010 19:38
Reporter:	John Embretsen	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tools: MTR / mysql-test-run	Severity:	S7 (Test Cases)
Version:	mysql-next-mr	OS:	Solaris (SPARC)
Assigned to:	Vladislav Vaintroub	CPU Architecture:	Any
Tags:	pushbuild, rqg_pb2, test failure

Description:
Server start via MTRv1 on Solaris SPARC platforms results in error:

"Could not find any of (...)/scripts/mysql_fix_privilege_tables (...)/bin/mysql_fix_privilege_tables"

[mysql-test]$ MTR_VERSION=1 perl ./mysql-test-run.pl analyze

=======================================================
  WARNING: Using mysql-test-run.pl version 1!
=======================================================
Logging: lib/v1/mysql-test-run.pl analyze
100222 16:31:49 [ERROR] An old style --language value with language specific part detected: /export/home/tmp/qauser/tmp-snapshots/mysql-5.5.99-m3-solaris10-sparc-64bit/share/mysql/english/
100222 16:31:49 [ERROR] Use --lc-messages-dir without language specific part instead.
100222 16:31:49 [Note] Buffered information: Performance schema disabled (reason: start parameters).

100222 16:31:49 [Note] Plugin 'FEDERATED' is disabled.
MySQL Version 5.5.99
Using dynamic switching of binlog format
Skipping ndbcluster, mysqld not compiled with ndbcluster
Setting mysqld to support SSL connections
mysql-test-run: *** ERROR: Could not find any of /export/home/tmp/qauser/tmp-snapshots/mysql-5.5.99-m3-solaris10-sparc-64bit/scripts/mysql_fix_privilege_tables /export/home/tmp/qauser/tmp-snapshots/mysql-5.5.99-m3-solaris10-sparc-64bit/bin/mysql_fix_privilege_tables

Manifested as test failures/errors for all Random Query Generator tests (rqg_*) in mysql-next-mr and mysql-next-mr-bugfixing since 2010-02-22.

How to repeat:
cd mysql-test
MTR_VERSION=1 perl ./mysql-test-run.pl analyze

Note that the first error regarding "An old style --language value" seen in the output from next-mr is not present in next-mr-bugfixing, since the latter includes the fix for the related Bug#51248.

The --language error does not seem to affect server startup, though, but the mysql_fix_privilege_tables issue does.

Possible fix is to remove remnants to that script in mtr v1

=== modified file 'mysql-test/lib/v1/mysql-test-run.pl'
--- mysql-test/lib/v1/mysql-test-run.pl	2010-02-07 11:41:24 +0000
+++ mysql-test/lib/v1/mysql-test-run.pl	2010-02-21 21:01:28 +0000
@@ -153,7 +153,6 @@
 our $exe_mysqlimport;
 our $exe_mysqlshow;
 our $exe_mysql_fix_system_tables;
-our $file_mysql_fix_privilege_tables;
 our $exe_mysqltest;
 our $exe_ndbd;
 our $exe_ndb_mgmd;
@@ -1680,19 +1679,7 @@
       $exe_mysql_upgrade= "";
     }
 
-    if ( ! $glob_win32 )
-    {
-      # Look for mysql_fix_system_table script
-      $exe_mysql_fix_system_tables=
-        mtr_script_exists("$glob_basedir/scripts/mysql_fix_privilege_tables",
-  			"$path_client_bindir/mysql_fix_privilege_tables");
-    }
-
-    # Look for mysql_fix_privilege_tables.sql script
-    $file_mysql_fix_privilege_tables=
-      mtr_file_exists("$glob_basedir/scripts/mysql_fix_privilege_tables.sql",
-  		    "$glob_basedir/share/mysql_fix_privilege_tables.sql",
-  		    "$glob_basedir/share/mysql/mysql_fix_privilege_tables.sql");
+   
 
     if ( ! $opt_skip_ndbcluster and executable_setup_ndb())
     {
@@ -2173,7 +2160,6 @@
     $ENV{'MYSQL_FIX_SYSTEM_TABLES'}=  $cmdline_mysql_fix_system_tables;
 
   }
-  $ENV{'MYSQL_FIX_PRIVILEGE_TABLES'}=  $file_mysql_fix_privilege_tables;
 
   # ----------------------------------------------------
   # Setup env so childs can execute my_print_defaults

See Bug#44280 and Bug#42589.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/101120

3096 Vladislav Vaintroub	2010-02-22
      Bug#51393 : remove mtr_fix_privilege_tables from MTR v1

Patch looks OK to me. Tested OK against mysql-next-mr-bugfixing on Solaris 10 SPARC 64-bit (tor06-z2).

I don't think you should remove the parts relating to the .sql file and the setting of MYSQL_FIX_PRIVILEGE_TABLES. This is still in the 6.0-codebase version of MTR v1 and is actually used by some tests. So unless these are also to be deprecated, IMHO they should be kept.

I am also having issues starting MTRv1 in out-of-source cmake builds. I will report it as a separate bug later when I have time, if it is not fixed in the meantime.

How-to-repeat:

mkdir build
cd build
cmake .. -DCMAKE_BUILD_TYPE=Debug (... etc. etc.)
gmake -j4

cd mysql-test

MTR_VERSION=1 perl mysql-test-run.pl analyze

=======================================================
  WARNING: Using mysql-test-run.pl version 1!
=======================================================
Logging: lib/v1/mysql-test-run.pl --script-debug 1st
mysql-test-run: *** ERROR: Could not find any of /export/home/tmp/johnemb/snapshots/next-mr-bugfixing_feb23_patched-cmake_mysql-5.5.99-m3/sql/release/mysqld (...)

So it seems it is not looking in <srcdir>/build/, but <srcdir>.

Normal MTR (v2) works.

I logged http://bugs.mysql.com/bug.php?id=51511 for the issue of MTRv1 not being able to find mysqld in out-of-source cmake builds.

Pushed into 6.0.14-alpha (revid:alik@sun.com-20100225194420-p60r4u90tszj8q2x) (version source revid:vvaintroub@mysql.com-20100223132149-dt8ju4nsjimq7f8l) (merge vers: 6.0.14-alpha) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100225194305-h49uyjrlfl3mwo60) (version source revid:vvaintroub@mysql.com-20100223125045-iq5srydus3lubafc) (pib:16)

Changes to test suite. No changelog entry needed.

Setting report to Need Merge pending push of Celosia to release tree.

Pushed into 5.5.3-m3 (revid:alik@sun.com-20100306103849-hha31z2enhh7jwt3) (version source revid:alik@sun.com-20100225195857-farb6yvy8x06bylj) (merge vers: 5.5.99-m3) (pib:16)

No changelog entry needed.