MySQL Bugs: #51248: Server start fails with MTR

Bug #51248	Server start fails with MTR_VERSION=1 and code with WL5154
Submitted:	17 Feb 2010 16:19	Modified:	6 Mar 2010 19:39
Reporter:	John Embretsen	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tools: MTR / mysql-test-run	Severity:	S7 (Test Cases)
Version:	celosia	OS:	Any
Assigned to:	Bjørn Munch	CPU Architecture:	Any
Tags:	rqg_pb2

Description:
Server fails to start when using MTRv1 against recent code pushed (Feb 17) to mysql-next-mr-bugfixing and mysql-6.0-codebase-bugfixing, implementing WL#5154 - "Remove deprecated 4.1 features".

Failure symptom:

mysql-test-run: WARNING: Process 20541 died
main.1st                       [ fail ]

ERROR: Failed to start master mysqld 0

Aborting: main.1st failed in default mode.
To continue, re-run with '--force'.
Stopping All Servers
mysql-test-run: WARNING: caught exit of unknown child -1
mysql-test-run: WARNING: Forcing kill of process 20541

Error log includes:

100217 19:08:54 [ERROR] /export/home/tmp/je159969/mysql-dev/snapshots/next-mr-bugfixing_feb17_mysql-5.5.99-m3-solaris10-x86_64/libexec/mysqld: unknown variable 'default-character-set=latin1'
100217 19:08:54 [ERROR] Aborting

Among the deprecated features described in WL#5154 is an option set by MTRv1. From the worklog:

<quote>
Deprecation actions apply in 5.0, 5.1, and Betony.
Removal of deprecated items applies in Celosia.

For each "deprecate and add warning" action, it should be understood
that there is a matching "remove deprecated code from Celosia code
base" action.

(...)

--default-character-set (and -C)

Current behavior: No warning message is given if this option is used.
                Option is deprecated in --help text.
Action:           Deprecate both --default-character-set and -C.
                Issue warning message if option is used.
                (--character-set-server is preferred)

</quote>

How to repeat:
Use MTR from a branch with WL#5154, e.g. mysql-next-mr-bugfixing as of 2010-02-17 (afternoon CET).

$ cd mysql-test

$ MTR_VERSION=1 ./mtr 1st

Running "MTR_VERSION=1 ./mtr --script-debug 1st" reveals that MTR indeed specifies this deprecated, now removed, option.

Suggested fix:
Use --character-set-server instead of --default-character-set for MTRv1.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/100659

2966 Bjorn Munch	2010-02-17
      Bug #51248 Server start fails with MTR_VERSION=1 and code with WL5154
      Replaced --default-character-set with --character-set-server
      Replaced --language with --lc-messages-dir
      NB full test suite not tested yet

Ran a number of tests with v1 in next-mr-bugfixing and 6.0-codebase-bugfixing and saw no problems with this.  Did not run whole suite as lots of tests are no longer working with v1 for other reasons.

Pushed to next-mr-bugfixing and 6.0-codebase-bugfixing

Excellent, Bjørn, thanks for reacting so fast!

From results of the first tests after your push it seems that the server is once again able to start. This also matches my own local & quick test results, so I'm checking the review box (patch looked OK to me) :)

Pushed into 6.0.14-alpha (revid:alik@sun.com-20100225194420-p60r4u90tszj8q2x) (version source revid:bjorn.munch@sun.com-20100217190244-25zxu6oxhywj95db) (merge vers: 6.0.14-alpha) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100225194305-h49uyjrlfl3mwo60) (version source revid:bjorn.munch@sun.com-20100217180849-bvcz2olxtm62sa36) (pib:16)

Changes to test suite. No changelog entry needed.

Setting report to Need Merge pending push of Celosia to release tree.

Pushed into 5.5.3-m3 (revid:alik@sun.com-20100306103849-hha31z2enhh7jwt3) (version source revid:alik@sun.com-20100225195857-farb6yvy8x06bylj) (merge vers: 5.5.99-m3) (pib:16)

No changelog entry needed.