Bug #47428 ndbgeneral should target_link mysys, and ws2_32

• Submitted: 18 Sep 2009 3:14
• Modified: 25 Sep 2009 9:57
• Reporter: jack andrews
• Status: Closed
• Category: MySQL Cluster: Cluster (NDB) storage engine
• Severity: S3 (Non-critical)
• Version: mysql-5.1-telco-7.0
• OS: Windows
• Assigned to: jack andrews
• CPU Architecture: Any

[18 Sep 2009 3:14] jack andrews

Description:
if you link to ndbgeneral, you also need to link to mysys and ws2_32.  CMake was intended to capture this information in TARGET_LINK_LIBRARIES.

How to repeat:
.

Suggested fix:
-TARGET_LINK_LIBRARIES(ndbgeneral zlib)
+TARGET_LINK_LIBRARIES(ndbgeneral zlib mysys ws2_32)

[18 Sep 2009 3:22] jack andrews

mailed to dev-ndb@

[22 Sep 2009 7:47] jack andrews

patch here:

Index: bug45447/storage/ndb/src/common/util/CMakeLists.txt
===================================================================
--- bug45447.orig/storage/ndb/src/common/util/CMakeLists.txt    2009-09-18 13:15:26.000000000 +1000
+++ bug45447/storage/ndb/src/common/util/CMakeLists.txt 2009-09-22 17:45:50.355000000 +1000
@@ -55,7 +55,7 @@
             Bitmask.cpp
            ndbinfo.c
 )
-TARGET_LINK_LIBRARIES(ndbgeneral zlib)
+TARGET_LINK_LIBRARIES(ndbgeneral zlib mysys ws2_32)

 ADD_EXECUTABLE(BaseString-t BaseString.cpp)
 SET_TARGET_PROPERTIES(BaseString-t

[23 Sep 2009 2:13] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/84227

3029 jack andrews	2009-09-23
      Bug #47428: ndbgeneral should target_link mysys, and ws2_32

[25 Sep 2009 9:57] jack andrews

patch pushed - don't think i need to send it to 'Documenting'

[30 Sep 2009 8:14] Bugs System

Pushed into 5.1.37-ndb-7.0.9 (revid:[e-mail]-20090930075942-1q6asjcp0gaeynmj) (version source revid:[e-mail]-20090923021121-y034tyqrsluniv5l) (merge vers: 5.1.37-ndb-7.0.8) (pib:11)

[30 Sep 2009 8:15] Bugs System

Pushed into 5.1.35-ndb-7.1.0 (revid:[e-mail]-20090930080049-1c8a8cio9qgvhq35) (version source revid:[e-mail]-20090923044045-pskiy7h7aayo25ko) (merge vers: 5.1.35-ndb-7.1.0) (pib:11)