Bug #44670 | ALTER TABLE crashes in StorageTableShare::haveIndexes() | ||
---|---|---|---|
Submitted: | 5 May 2009 13:34 | Modified: | 26 May 2010 17:46 |
Reporter: | Olav Sandstå | Email Updates: | |
Status: | Unsupported | Impact on me: | |
Category: | MySQL Server: Falcon storage engine | Severity: | S2 (Serious) |
Version: | 6.0.12-alpha | OS: | Any |
Assigned to: | Christopher Powers | CPU Architecture: | Any |
Tags: | F_ONLINE ALTER |
[5 May 2009 13:34]
Olav Sandstå
[5 Aug 2009 3:10]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80115 2764 Christopher Powers 2009-08-04 Bug #44670, "ALTER TABLE crashes in StorageTableShare::haveIndexes()" Disabled unnecessary and unprotected check of StorageTableShare::indexes. modified: storage/falcon/StorageTableShare.cpp
[5 Aug 2009 3:10]
Christopher Powers
StorageTableShare::haveIndexes() performs an unnecessary and unprotected check of the ::indexes linked list.
[5 Aug 2009 23:38]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80230 2765 Christopher Powers 2009-08-05 Bug#44670, "ALTER TABLE crashes in StorageTableShare::haveIndexes()" Don't use StorageTableShare::haveIndexes() at all modified: storage/falcon/ha_falcon.cpp
[17 Aug 2009 18:32]
Kevin Lewis
Falcon cannot crash in StorageTableShare::haveIndexes() if it is not called. Without it, StorageInterface::remapIndexes() is just called more often. But StorageInterface::setIndexes() is only called during create() and open(), which is not often enough to worry about performance. Note; StorageTableShare::haveIndexes() should be deleted later as unused code.
[26 Aug 2009 2:52]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/81565 2770 Christopher Powers 2009-08-25 Bug#44670 "ALTER TABLE crashes in StorageTableShare::haveIndexes()" Restore call to modified StorageTableShare::haveIndexes() to avoid deadlock. modified: storage/falcon/StorageTableShare.cpp storage/falcon/StorageTableShare.h storage/falcon/ha_falcon.cpp
[14 Sep 2009 6:41]
Christopher Powers
[Assigned patch to wrong bug, Bug#46670] A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/81568 2771 Christopher Powers 2009-08-25 Bug#46670 "ALTER TABLE crashes in StorageTableShare::haveIndexes()" Rewrote StorageTableShare::haveIndexes() to more effectively check for the need to remap Falcon indexes modified: storage/falcon/StorageTableShare.cpp storage/falcon/StorageTableShare.h storage/falcon/ha_falcon.cpp