Bug #974 configure scripts assume bash extensions

• Submitted: 31 Jul 2003 23:25
• Modified: 1 Aug 2003 1:32
• Reporter: Alex Kiernan
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 4.0.14
• OS: Solaris (Solaris)
• Assigned to: Lenz Grimmer
• CPU Architecture: Any

[31 Jul 2003 23:25] Alex Kiernan

Description:
acinclude.m4 fails when include ssl support on Solaris

How to repeat:
run configure on Solaris, attempting to include SSL support

Suggested fix:
Index: configure
===================================================================
RCS file: /cvsroot/upstream/mysql/configure,v
retrieving revision 1.1.1.2
retrieving revision 1.2
diff -u -r1.1.1.2 -r1.2
--- configure	2003/07/18 14:58:06	1.1.1.2
+++ configure	2003/07/28 19:59:48	1.2
@@ -20958,7 +20958,7 @@
     case "$CLIENT_EXTRA_LDFLAGS $MYSQLD_EXTRA_LDFLAGS" in
 	*-all-static*) using_static="yes" ;;
     esac
-    if test $using_static = "yes"
+    if test "$using_static" = "yes"
     then
       echo "You can't use the --all-static link option when using openssl."
       exit 1
Index: aclocal.m4
===================================================================
RCS file: /cvsroot/upstream/mysql/aclocal.m4,v
retrieving revision 1.1.1.2
retrieving revision 1.2
diff -u -r1.1.1.2 -r1.2
--- aclocal.m4	2003/07/18 14:57:59	1.1.1.2
+++ aclocal.m4	2003/07/28 19:59:48	1.2
@@ -791,7 +791,7 @@
     case "$CLIENT_EXTRA_LDFLAGS $MYSQLD_EXTRA_LDFLAGS" in
 	*-all-static*) using_static="yes" ;;
     esac
-    if test $using_static = "yes"
+    if test "$using_static" = "yes"
     then
       echo "You can't use the --all-static link option when using openssl."
       exit 1
Index: acinclude.m4
===================================================================
RCS file: /cvsroot/upstream/mysql/acinclude.m4,v
retrieving revision 1.1.1.2
retrieving revision 1.2
diff -u -r1.1.1.2 -r1.2
--- acinclude.m4	2003/07/18 14:57:40	1.1.1.2
+++ acinclude.m4	2003/07/28 19:59:48	1.2
@@ -778,7 +778,7 @@
     case "$CLIENT_EXTRA_LDFLAGS $MYSQLD_EXTRA_LDFLAGS" in
 	*-all-static*) using_static="yes" ;;
     esac
-    if test $using_static = "yes"
+    if test "$using_static" = "yes"
     then
       echo "You can't use the --all-static link option when using openssl."
       exit 1

[1 Aug 2003 1:32] Lenz Grimmer

Thanks for the hint! I've now fixed this in the 4.0 tree on some other places, 
too:

ChangeSet@1.1555, 2003-08-01 10:21:41+02:00, [e-mail]
   - portability fixes: put string tests in double quotes (BUG#974).
     Thanks to Alex Kiernan for the hint.