Bug #91071 Possibly unused functions in xdr_utils

• Submitted: 30 May 2018 8:50
• Modified: 8 Aug 2018 15:41
• Reporter: Zsolt Parragi (OCA)
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 5.7
• OS: Any
• CPU Architecture: Any
• Tags: Contribution

[30 May 2018 8:50] Zsolt Parragi

Description:
xdr_utils.h contains several macros, which provide function declarations/definitions, for example def_init_xdr_array.

These methods could be possibly unused in the RelWithDebInfo configuration.

How to repeat:
Compile MYSQL 5.7 with clang/RelWithDebInfo

Suggested fix:
Mark methods as MY_ATTRIBUTE((unused))

[30 May 2018 8:52] Zsolt Parragi

Added unused attribute to the macros

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: xdr.diff (text/x-patch), 2.28 KiB.

[30 May 2018 10:04] Umesh Shastry

Hello Zsolt,

Thank you for the report and contribution.

Thanks,
Umesh

[13 Jun 2018 12:44] Laurynas Biveinis

Bug 91071 fix for 8.0.11

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: bug91071-8.0.11.patch (application/octet-stream, text), 2.41 KiB.

[14 Jun 2018 5:03] Umesh Shastry

Thank you for the contributions!

Regards,
Umesh

[8 Aug 2018 15:41] David Moss

Posted by developer:
 
Thank you for your feedback, this has been fixed in upcoming versions and the following was added to the 5.7.24 / 8.0.13 changelog:
Compilation warnings related to unused functions in xdr_utils have been reduced. Thanks to Zsolt Parragi for the patch.