MySQL Bugs: #84299: mtr: mem is pure flag / add /run/shm (contribution)

Bug #84299	mtr: mem is pure flag / add /run/shm (contribution)
Submitted:	21 Dec 2016 13:29	Modified:	21 Dec 2016 13:47
Reporter:	OCA Admin (OCA)	Email Updates:
Status:	Verified	Impact on me:	None
Category:	Tools: MTR / mysql-test-run	Severity:	S3 (Non-critical)
Version:	5.7	OS:	Any
Assigned to:		CPU Architecture:	Any
Tags:	Contribution

Description:
This bug tracks a contribution by Daniel Black (Github user: grooverdan) as described in http://github.com/mysql/mysql-server/pull/116

How to repeat:
See description

Suggested fix:
See contribution code attached

Contribution submitted via Github - mtr: mem is pure flag / add /run/shm (*) Contribution by Daniel Black (Github grooverdan, mysql-server/pull/116#issuecomment-268423030): I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: git_patch_98864585.txt (text/plain), 2.37 KiB.

Hello Daniel,

Thank you for the report and contribution.

Thanks,
Umesh

See my comment to the pull request. I think this needs to be extended with a check that the chosen mem directory is not a softlink.

Contribution submitted via Github - bug 84299: Symlinks for mtr mem directory not supported (*) Contribution by Daniel Black (Github grooverdan, mysql-server/pull/117#issuecomment-268670322): I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: git_patch_99022504.txt (text/plain), 744 bytes.

mtr.patch

Attachment: mtr.patch (text/x-patch), 861 bytes.

Attached is a new version. It was pointed out that ./mtr --mem /tmp cannot differentiate between /tmp being a a tmp directory or a test suite to run.

As such the revise patch enabled MTR_MEM=/xxx ./mtr --mem to take the MTR_MEM environment variable as the preferences location.

Additionally it checks the default tmpfs locations aren't a symlink.