Bug #83264 | uint3korr should stop reading four instead of three bytes on x86 | ||
---|---|---|---|
Submitted: | 5 Oct 2016 8:29 | Modified: | 10 Mar 2017 3:13 |
Reporter: | Laurynas Biveinis (OCA) | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | MySQL Server: Replication | Severity: | S3 (Non-critical) |
Version: | 5.5,5.6 | OS: | Any |
Assigned to: | CPU Architecture: | Any | |
Tags: | asan, Contribution |
[5 Oct 2016 8:29]
Laurynas Biveinis
[5 Oct 2016 9:42]
Laurynas Biveinis
Bug 83264 fix for 5.5 (*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.
Contribution: bug83264-5.5.patch (application/octet-stream, text), 927 bytes.
[5 Oct 2016 9:43]
Laurynas Biveinis
Bug 83264 fix for 5.6 (*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.
Contribution: bug83264-5.6.patch (application/octet-stream, text), 1.78 KiB.
[6 Oct 2016 9:53]
MySQL Verification Team
Hello Laurynas, Thank you for the report and contribution. Thanks, Umesh
[12 Oct 2016 10:26]
Ståle Deraas
Posted by developer: Laurynas, will this actually fix a concrete issue that you see, or just make ASAN more clean for 5.5 and 5.6?
[12 Oct 2016 10:36]
Laurynas Biveinis
It's for ASan. We still support 32-bit platforms, and would like to have a clean testing baseline accordingly. The only risk in applying this I'd see is worse code generated with some compiler lacking in optimisation, but I wouldn't consider it's that big of an issue for 32 bits, even if it does happen.
[9 Mar 2017 18:21]
Paul DuBois
Posted by developer: Noted in 5.5.56, 5.6.37, 5.7.19, 8.0.1 changelogs. On x86 machines, the uint3korr() macro read 4 bytes of data instead of the intended 3 bytes.
[9 Mar 2017 18:25]
Paul DuBois
Posted by developer: 8.0.2 changelog, not 8.0.1.
[10 Mar 2017 3:13]
Laurynas Biveinis
Can you please confirm the 5.7 / 8.0 fix? AFAIK the bug was only present in 5.5 and 5.6.
[27 Apr 2017 13:11]
Paul DuBois
Posted by developer: Retagged for release notes from 5.5.56 to 5.5.57.