Bug #80496 buf_dblwr_init_or_load_pages now returns an error code, but caller not updated
Submitted: 24 Feb 2016 14:00 Modified: 2 Feb 2018 7:31
Reporter: Laurynas Biveinis (OCA) Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Server: InnoDB storage engine Severity:S3 (Non-critical)
Version:5.7, 5.7.11, 8.0.4 OS:Any
Assigned to: CPU Architecture:Any

[24 Feb 2016 14:00] Laurynas Biveinis
Description:
This is a minor code review type of bug:

buf_dblwr_init_or_load_pages, previously a void function, now returns a dberr_t since [1]. But its sole caller does not bother to check it.

[1]:

commit 98909cefbc37e54efc6452c7e95bccbf64ac9213
Author: Sunny Bains <Sunny.Bains@oracle.com>
Date:   Wed Mar 4 13:58:59 2015 +1100

    WL#7696 - Backport code from mysql-trunk to mysql-5.7

How to repeat:
Grep for buf_dblwr_init_or_load_pages

Suggested fix:
Check the return code in SysTablespace::read_lsn_and_check_flags, add attribute warn_unused_result.
[24 Feb 2016 14:07] Laurynas Biveinis
Bug 80496 patch for 5.7.11

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: bug80496.patch (application/octet-stream, text), 1.12 KiB.

[25 Feb 2016 4:28] Umesh Shastry
Hello Laurynas,

Thank you for the report and contribution.

Thanks,
Umesh
[6 Jun 2017 9:03] Laurynas Biveinis
Bug 80496 fix for 8.0.1

Attachment: bug80496-8.0.1.patch (application/octet-stream, text), 1.66 KiB.

[6 Jun 2017 9:03] Laurynas Biveinis
Same patch as for 5.7, s/__attribute__/MY_ATTRIBUTE
[5 Aug 2017 7:23] Laurynas Biveinis
Bug 80496 fix for 8.0.2

Attachment: bug80496-8.0.2.patch (application/octet-stream, text), 1.66 KiB.

[2 Feb 2018 7:31] Laurynas Biveinis
The latest contributed fix applies cleanly and works on 8.0.4 too.
[13 Jun 2018 12:30] Laurynas Biveinis
Bug 80496 fix for 8.0.11

Attachment: bug80496-8.0.11.patch (application/octet-stream, text), 1.73 KiB.