MySQL Bugs: #73163: IndexOutOfBoundsException thrown preparing statement

Bug #73163	IndexOutOfBoundsException thrown preparing statement
Submitted:	1 Jul 2014 14:57	Modified:	12 Sep 2014 16:54
Reporter:	Johnathan Crawford (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Connector / J	Severity:	S1 (Critical)
Version:	5.1.31	OS:	Linux
Assigned to:	Filipe Silva	CPU Architecture:	Any
Tags:	jdbc, StringUtils

Description:
After updating from 5.1.29 to 5.1.31 we ran into issues with running load data infile statements with prepared statements.

Exception in thread "main" org.springframework.dao.TransientDataAccessResourceException: PreparedStatementCallback; SQL [LOAD DATA INFILE ? INTO TABLE hlog_event_log_loginfriends FIELDS TERMINATED BY ',' OPTIONALLY ENCLOSED BY '"' ESCAPED BY '\\' LINES TERMINATED BY '\n';]; java.lang.IndexOutOfBoundsException; nested exception is java.sql.SQLException: java.lang.IndexOutOfBoundsException
	at org.springframework.jdbc.support.SQLStateSQLExceptionTranslator.doTranslate(SQLStateSQLExceptionTranslator.java:107)
	at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:72)
	at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:80)
	at org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:603)
	at org.springframework.jdbc.core.JdbcTemplate.update(JdbcTemplate.java:812)
	at org.springframework.jdbc.core.JdbcTemplate.update(JdbcTemplate.java:868)
	at org.springframework.jdbc.core.JdbcTemplate.update(JdbcTemplate.java:876)
	at JdbcTestDao.insert(JdbcTestDao.java:19)
	at Main.main(Main.java:12)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:134)
Caused by: java.sql.SQLException: java.lang.IndexOutOfBoundsException
	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1094)
	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:997)
	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:983)
	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:928)
	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:959)
	at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:949)
	at com.mysql.jdbc.Util.handleNewInstance(Util.java:432)
	at com.mysql.jdbc.PreparedStatement.getInstance(PreparedStatement.java:834)
	at com.mysql.jdbc.ConnectionImpl.clientPrepareStatement(ConnectionImpl.java:1585)
	at com.mysql.jdbc.ConnectionImpl.prepareStatement(ConnectionImpl.java:4600)
	at com.mysql.jdbc.ConnectionImpl.prepareStatement(ConnectionImpl.java:4498)
	at org.springframework.jdbc.core.JdbcTemplate$SimplePreparedStatementCreator.createPreparedStatement(JdbcTemplate.java:1436)
	at org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:581)
	... 10 more
Caused by: java.lang.IndexOutOfBoundsException
	at java.nio.CharBuffer.wrap(CharBuffer.java:375)
	at com.mysql.jdbc.StringUtils.getBytes(StringUtils.java:2067)
	at com.mysql.jdbc.StringUtils.getBytes(StringUtils.java:2039)
	at com.mysql.jdbc.PreparedStatement$ParseInfo.<init>(PreparedStatement.java:364)
	at com.mysql.jdbc.PreparedStatement$ParseInfo.<init>(PreparedStatement.java:205)
	at com.mysql.jdbc.PreparedStatement.<init>(PreparedStatement.java:915)
	at com.mysql.jdbc.JDBC4PreparedStatement.<init>(JDBC4PreparedStatement.java:47)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:408)
	at com.mysql.jdbc.Util.handleNewInstance(Util.java:408)
	... 16 more

How to repeat:
Run the test case provided.

Test case

Attachment: insert-bug.zip (application/x-zip-compressed, text), 3.16 KiB.

Please contact me if further information is required.

Hi,

Johnathan is right. The fix for the issue 72008 introduced a bug in line 2067 in the class StringUtils:

ByteBuffer buf = cs.encode(CharBuffer.wrap(value.toCharArray(), offset, offset + length));

It should be:

ByteBuffer buf = cs.encode(CharBuffer.wrap(value, offset, offset + length));

As far as I can tell this change was not a part of my patch for 72008.

I will attach a patch to fix this issue.

Best regards,
Andrej Golovnin

Fixes this issue. (*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: StringUtils_bug73163.patch (application/octet-stream, text), 533 bytes.

Hi Johnathan,

Thank you for this bug report.

Hi,

This bug was verified as described.

And yes, Andrej. It was introduced in the patch for Bug#72008 and for that we apologize. However, as far as I can tell, to fix this we should replace the line you referred by:

ByteBuffer buf = cs.encode(CharBuffer.wrap(value.toCharArray(), offset, length));

Regarding the encoding capabilities of the different Java versions there are a few inconsistencies and bugs. That's why this method turned out to be implemented as it is. If you find out something else that is relevant for this issue, please, let us know. Thank you.

Hi Filipe,

> ByteBuffer buf = cs.encode(CharBuffer.wrap(value.toCharArray(), offset, length));

> Regarding the encoding capabilities of the different Java versions there are a few inconsistencies and 
> bugs. That's why this method turned out to be implemented as it is. If you find out something else that 
> is relevant for this issue, please, let us know. Thank you.

Could please explain, why it is needed to create a char array? As far as I know the Charset#encode(CharBuffer) method does not care about the backend of the used CharBuffer. Please post more information about the problems in the encoding capabilities of the different Java versions, e.g. Java version numbers, example code, links to the bug reports in the Oracle bug database etc.

Best regards,
Andrej Golovnin

Hi Andrej,

As you may understand, I cannot delve into an issue not related with the Connector/J or MySQL in here. If you wish, we can discuss this a little further by other means.

Thank you,
Filipe Silva

Added the following entry to the Connector/J 5.1.33 changelog:

"Using Java 6 or later, running LOAD DATA INFILE with a prepared statement resulted in an IndexOutOfBoundsException. This was a regression introduced by an issue in the patch for an old bug, which has now been fixed. (Bug #19171665, Bug #73163) References: This bug is a regression of Bug #72008."