Bug #59979 Add mtr option to run debug server, but without turning on debug
Submitted: 7 Feb 2011 8:43 Modified: 9 Feb 2011 19:22
Reporter: Bjørn Munch Email Updates:
Status: Closed Impact on me:
None 
Category:Tools: MTR / mysql-test-run Severity:S3 (Non-critical)
Version:5.1+ OS:Any
Assigned to: Bjørn Munch

[7 Feb 2011 8:43] Bjørn Munch
Description:
After testing out Bug #59148, it becomes clear that running the entire test suite with --debug as it is now, is not a good idea. This option currently does two things: first, it uses mysqld-debug and debug versions of plugins, second it passed --debug (or --loose-debug) to servers and clients.

This will result in a few hundred Gb of trace if the entire test suite is run, clearly too much. It also slows the tests down by large factor.

How to repeat:
Run mtr --debug without limiting to a few tests

Suggested fix:
Leave the --debug as it is (we should not change existing functionality), but add another option --debug-server which ensure we run with the debug version of the server.

It should use mysqld-debug if it finds it, but will not pass the default --debug option. Some tests may set it explicitly though.

If it doesn't find mysqld-debug it probably should check if mysqld supports debug, and fail if it doesn't.
[7 Feb 2011 10:21] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130541

2980 Bjorn Munch	2011-02-07
      Bug #59979 Add mtr option to run debug server, but without turning on debug
      Added --debug-server and use $opt_debug_server where appropriate
      Let --debug imply --debug-server
      When merging to 5.5, must adapt fix for 59148
[7 Feb 2011 11:43] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130556

2980 Bjorn Munch	2011-02-07
      Bug #59979 Add mtr option to run debug server, but without turning on debug
      Added --debug-server and use $opt_debug_server where appropriate
      Let --debug imply --debug-server
      When merging to 5.5, must adapt fix for 59148
      Oops, set debug => debug-server too late, fixed
[7 Feb 2011 12:02] Bjørn Munch
Pushed to -mtr branches
[7 Feb 2011 23:55] Bugs System
Pushed into mysql-trunk 5.6.2 (revid:bjorn.munch@oracle.com-20110207235423-p72c50ae0vgdjbdl) (version source revid:bjorn.munch@oracle.com-20110207235315-oejyajxuc8utuwfu) (merge vers: 5.6.2) (pib:24)
[7 Feb 2011 23:56] Bugs System
Pushed into mysql-5.5 5.5.10 (revid:bjorn.munch@oracle.com-20110207232832-ppycbd3zez7pfvq1) (version source revid:bjorn.munch@oracle.com-20110207232730-yc8qvy7ziu3nd5ds) (merge vers: 5.5.10) (pib:24)
[7 Feb 2011 23:57] Bugs System
Pushed into mysql-5.1 5.1.56 (revid:bjorn.munch@oracle.com-20110207230245-ignb6bk9zfq1zswp) (version source revid:bjorn.munch@oracle.com-20110207230245-ignb6bk9zfq1zswp) (merge vers: 5.1.56) (pib:24)
[8 Feb 2011 11:57] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130703

3316 Anitha Gopi	2011-02-08
      Bug#59979: Added --debug-server option to collections
[8 Feb 2011 13:55] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130722

3614 Anitha Gopi	2011-02-08 [merge]
      Bug#59979: Upmerge revision 3316 from mysql-5.5
[8 Feb 2011 13:57] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130724

3615 Anitha Gopi	2011-02-08
      Bug#59979 - Added debug-server option
[8 Feb 2011 13:58] Bugs System
Pushed into mysql-5.5 5.5.10 (revid:anitha.gopi@sun.com-20110208115542-lc3ibkex1w9wn2z4) (version source revid:anitha.gopi@sun.com-20110208115542-lc3ibkex1w9wn2z4) (merge vers: 5.5.10) (pib:24)
[8 Feb 2011 13:59] Bugs System
Pushed into mysql-trunk 5.6.2 (revid:anitha.gopi@sun.com-20110208135625-jcp43i0mhqum4osw) (version source revid:anitha.gopi@sun.com-20110208135625-jcp43i0mhqum4osw) (merge vers: 5.6.2) (pib:24)
[8 Feb 2011 19:09] Paul Dubois
Changes to test suite. No changelog entry needed.