Bug #59955 engines/funcs/ps_string_not_null test needs better cleanup

• Submitted: 4 Feb 2011 20:02
• Modified: 9 Feb 2011 19:21
• Reporter: Thomas Jones-Low
• Status: Closed
• Category: Tests: Server
• Severity: S3 (Non-critical)
• Version: 5.5.8
• OS: Any
• Assigned to: Vinay Fisrekar
• CPU Architecture: Any

[4 Feb 2011 20:02] Thomas Jones-Low

Description:
The engines/funcs tests are usually pretty good about cleaning up before they start. Except in ps_string_not_null:

--disable_warnings
DROP TABLE IF EXISTS t2;
--enable_warnings
CREATE TABLE t1(c1 CHAR(100) NOT NULL);

If one of the previous test which creates a test.t1 table fails, this test will then fail because the table test.t1 already exists. 

How to repeat:
mysql> create table t1 (c1 char(100) NOT NULL);

./mtr --extern socket=/tmp/mysql.sock --suite=engines/funcs ps_string_not_null 

Suggested fix:
DROP TABLE IF EXISTS t1;

[5 Feb 2011 9:05] Valeriy Kravchuk

Verified with current mysql-5.5 by code review.

[7 Feb 2011 5:41] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130508

3578 Vinay Fisrekar	2011-02-07
      Bug#59955 - engines/funcs/ps_string_not_null test needs better cleanup
      
      Correcting clean up command at the start of test.

[7 Feb 2011 6:57] Sandeep Doddaballapur

Looks good . please push the changes.

[7 Feb 2011 7:05] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130509

3305 Vinay Fisrekar	2011-02-07 [merge]
      bzr merger from mysql-5.1 to mysql-5.5
      Bug#59955 - engines/funcs/ps_string_not_null test needs better cleanup

[7 Feb 2011 7:07] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130510

3600 Vinay Fisrekar	2011-02-07 [merge]
        bzr merger from mysql-5.5 to mysql-trunk
        Bug#59955 - engines/funcs/ps_string_not_null test needs better cleanup

[7 Feb 2011 7:09] Bugs System

Pushed into mysql-5.1 5.1.56 (revid:[e-mail]-20110207054035-paaege91vf2ctb0h) (version source revid:[e-mail]-20110207054035-paaege91vf2ctb0h) (merge vers: 5.1.56) (pib:24)

[7 Feb 2011 7:10] Bugs System

Pushed into mysql-5.5 5.5.10 (revid:[e-mail]-20110207070443-f8d474mdh7tj37p0) (version source revid:[e-mail]-20110207070443-f8d474mdh7tj37p0) (merge vers: 5.5.10) (pib:24)

[7 Feb 2011 9:05] Bugs System

Pushed into mysql-trunk 5.6.2 (revid:[e-mail]-20110207070653-d7wa8hr1qx9ytyw0) (version source revid:[e-mail]-20110207070653-d7wa8hr1qx9ytyw0) (merge vers: 5.6.2) (pib:24)

[7 Feb 2011 16:00] Paul DuBois

Changes for test suite. No changelog entry needed.