Bug #59867 Cleanup cmake files for mysqld and embedded

• Submitted: 1 Feb 2011 10:26
• Modified: 2 Mar 2011 3:37
• Reporter: Tor Didriksen
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 5.6
• OS: Any
• Assigned to: Tor Didriksen
• CPU Architecture: Any

[1 Feb 2011 10:26] Tor Didriksen

Description:
We currently have two separate lists of source files in
libmysqld/CMakeLists.txt and sql/CMakeLists.txt

both of them are unstructured, and need to be maintained in synch.

How to repeat:
read the code

Suggested fix:
rewrite to one list in sql/CMakeLists.txt, and export it to embedded.

[1 Feb 2011 10:35] MySQL Verification Team

Thank you for the bug report.

[1 Feb 2011 14:05] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130128

3585 Tor Didriksen	2011-02-01
      Bug #59867 Cleanup cmake files for mysqld and embedded
      
      Create one common list representing (most of) the source files which
      are common to mysqld and the embedded server.
     @ libmysqld/CMakeLists.txt
        Import most of the sql sources from SQL_EXPORTED_SOURCES, set in sql/CMakeLists.txt
        Some cosmetics (indentation)
     @ sql/CMakeLists.txt
        Sort list of source files alphabetically.
        Remove all .h files
        Export SQL_EXPORTED_SOURCES so it can be used to build the embedded server.
        Some cosmetics (indentation)

[4 Feb 2011 12:40] Jonathan Perkin

Looks good, thanks :)

[4 Feb 2011 12:44] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/130406

3594 Tor Didriksen	2011-02-02
      Bug #59867 Cleanup cmake files for mysqld and embedded
      
      Create one common list representing (most of) the source files which
      are common to mysqld and the embedded server.
     @ libmysqld/CMakeLists.txt
        Import most of the sql sources from SQL_EXPORTED_SOURCES, set in sql/CMakeLists.txt
        Some cosmetics (indentation)
     @ sql/CMakeLists.txt
        Sort list of source files alphabetically.
        Remove all .h files
        Export SQL_EXPORTED_SOURCES so it can be used to build the embedded server.
        Some cosmetics (indentation)

[4 Feb 2011 13:16] Bugs System

Pushed into mysql-trunk 5.6.2 (revid:[e-mail]-20110202083013-5ml5a09v0t5c25ik) (version source revid:[e-mail]-20110202083013-5ml5a09v0t5c25ik) (merge vers: 5.6.2) (pib:24)

[2 Mar 2011 3:37] Paul DuBois

Code cleanup. No user impact. No changelog entry needed.