| Bug #59178 | Valgrind warnings rpl_get_master_version_and_clock | ||
|---|---|---|---|
| Submitted: | 27 Dec 2010 5:34 | Modified: | 14 Mar 2011 5:47 |
| Reporter: | Zhenxing He | Email Updates: | |
| Status: | Duplicate | Impact on me: | |
| Category: | MySQL Server: General | Severity: | S3 (Non-critical) |
| Version: | 5.1,5.5 | OS: | Any |
| Assigned to: | Assigned Account | CPU Architecture: | Any |
| Tags: | pb2, valgrind | ||
[27 Dec 2010 5:34]
Zhenxing He
[5 Jan 2011 13:00]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/127968 3534 Georgi Kodinov 2011-01-05 Bug #59178: disable the test case
[5 Jan 2011 13:07]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/127970 3461 Georgi Kodinov 2011-01-05 [merge] Bug #59178 : null merge of the test disablement to trunk.
[5 Jan 2011 13:08]
Bugs System
Pushed into mysql-5.1 5.1.55 (revid:georgi.kodinov@oracle.com-20110105125805-aedkj2j5lsx36m1u) (version source revid:georgi.kodinov@oracle.com-20110105125805-aedkj2j5lsx36m1u) (merge vers: 5.1.55) (pib:24)
[5 Jan 2011 13:08]
Bugs System
Pushed into mysql-5.5 5.5.9 (revid:georgi.kodinov@oracle.com-20110105130248-3vmoqbnt6mpc6xaj) (version source revid:georgi.kodinov@oracle.com-20110105130248-3vmoqbnt6mpc6xaj) (merge vers: 5.5.9) (pib:24)
[5 Jan 2011 13:09]
Bugs System
Pushed into mysql-trunk 5.6.2 (revid:georgi.kodinov@oracle.com-20110105130642-p42be2bnf8h0zgag) (version source revid:georgi.kodinov@oracle.com-20110105130642-p42be2bnf8h0zgag) (merge vers: 5.6.2) (pib:24)
[5 Jan 2011 16:57]
Alfranio Tavares Correia Junior
Find in what follows how to repeat the problem:
./BUILD/compile-pentium64-valgrind-max
./mtr test.test --valgrind
== cat t/test.test ===
SELECT REPEAT(' ', 2);
[5 Jan 2011 17:13]
Alfranio Tavares Correia Junior
The valgrind errors stem from the sql/protocol.cc:859 where a non-null-terminated string is being printed out.
bool Protocol_text::store(const char *from, size_t length,
CHARSET_INFO *fromcs)
{
CHARSET_INFO *tocs= this->thd->variables.character_set_results;
#ifndef DBUG_OFF
DBUG_PRINT("info", ("Protocol_text::store field %u (%u): %s", field_pos,
field_count, (length == 0? "" : from)));
DBUG_ASSERT(field_pos < field_count);
DBUG_ASSERT(field_types == 0 ||
field_types[field_pos] == MYSQL_TYPE_DECIMAL ||
field_types[field_pos] == MYSQL_TYPE_BIT ||
field_types[field_pos] == MYSQL_TYPE_NEWDECIMAL ||
field_types[field_pos] == MYSQL_TYPE_NEWDATE ||
(field_types[field_pos] >= MYSQL_TYPE_ENUM &&
field_types[field_pos] <= MYSQL_TYPE_GEOMETRY));
field_pos++;
#endif
return store_string_aux(from, length, fromcs, tocs);
}
I don't know if at this point all strings should be null-terminated.
[12 Mar 2011 12:15]
Andrei Elkin
Ramil, this bug must have been addressed by a bug#59060 patch. The stacks are identical, so I would suggest a duplicate. I run into these two while hunting over Bug #58754.
[14 Mar 2011 5:47]
Ramil Kalimullin
Closing as a duplicate, see Andrei's comment.
