Bug #58621 perfschema.dml_ews_by_thread_by_event_name test failure
| Submitted: | 1 Dec 2010 6:56 | Modified: | 30 Dec 2010 18:54 |
|---|---|---|---|
| Reporter: | Marc ALFF | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Performance Schema | Severity: | S3 (Non-critical) |
| Version: | 5.5 | OS: | Any |
| Assigned to: | Marc ALFF | CPU Architecture: | Any |
[1 Dec 2010 8:02]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/125604 3158 Marc Alff 2010-12-01 Bug#58621 perfschema.dml_ews_by_thread_by_event_name test failure This fix affects the test suite only. Before this fix, performance schema tests dml_*.test could fail with spurious failure, depending on the table content. This fix simplifies the SELECT tests in the dml_*.test scripts, to only verify that the SELECT operation passed the security checks and succeeded, which was the original intent of the test. Usage of --replace_column 1 # 2 # 3 # 4 # ... to discard the test output was replaced by a simpler and more maintainable --disable_result_log which also work for empty tables.
[1 Dec 2010 17:29]
Christopher Powers
Patch approved.
[1 Dec 2010 18:53]
Marc ALFF
Pushed into: - mysql-5.5-bugteam - mysql-trunk-bugfixing
[5 Dec 2010 12:37]
Bugs System
Pushed into mysql-trunk 5.6.1 (revid:alexander.nozdrin@oracle.com-20101205122447-6x94l4fmslpbttxj) (version source revid:alexander.nozdrin@oracle.com-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)
[11 Dec 2010 17:06]
Paul DuBois
Changes to test suite. No changelog entry needed.
[17 Dec 2010 12:52]
Bugs System
Pushed into mysql-5.5 5.5.9 (revid:georgi.kodinov@oracle.com-20101217124733-p1ivu6higouawv8l) (version source revid:marc.alff@oracle.com-20101201080104-j851s2tsdj1rarr6) (merge vers: 5.5.8) (pib:24)
Portions of this website are copyright © 2001, 2002 The PHP Group
Page generated in 0.056 sec. using MySQL 8.4.7-u6-cloud
Timestamp references displayed by the system are UTC.
Content reproduced on this site is the property of the
respective copyright holders.
It is not reviewed in advance
by Oracle and does not necessarily represent the opinion of
Oracle or any other party.
Description: Seen in mysql-trunk-stage: perfschema.dml_ews_by_thread_by_event_name [ fail ] Test ended at 2010-11-30 20:41:14 CURRENT_TEST: perfschema.dml_ews_by_thread_by_event_name --- /export/home/pb2/test/sb_1-2613083-1291143967.39/mysql-5.6.1-m5-freebsd7.0-i386-test/mysql-test/suite/perfschema/r/dml_ews_by_thread_by_event_name.result 2010-11-30 17:37:33.000000000 +0300 +++ /export/home/pb2/test/sb_1-2613083-1291143967.39/mysql-5.6.1-m5-freebsd7.0-i386-test/mysql-test/suite/perfschema/r/dml_ews_by_thread_by_event_name.reject 2010-11-30 22:41:13.000000000 +0300 @@ -1,7 +1,6 @@ select * from performance_schema.events_waits_summary_by_thread_by_event_name where event_name like 'Wait/Synch/%' limit 1; THREAD_ID EVENT_NAME COUNT_STAR SUM_TIMER_WAIT MIN_TIMER_WAIT AVG_TIMER_WAIT MAX_TIMER_WAIT -# # # # # # # select * from performance_schema.events_waits_summary_by_thread_by_event_name where event_name='FOO'; THREAD_ID EVENT_NAME COUNT_STAR SUM_TIMER_WAIT MIN_TIMER_WAIT AVG_TIMER_WAIT MAX_TIMER_WAIT mysqltest: Result content mismatch - saving '/export/home/pb2/test/sb_1-2613083-1291143967.39/mysql-5.6.1-m5-freebsd7.0-i386-test/mysql-test/var-n_mix/log/perfschema.dml_ews_by_thread_by_event_name/' to '/export/home/pb2/test/sb_1-2613083-1291143967.39/mysql-5.6.1-m5-freebsd7.0-i386-test/mysql-test/var-n_mix/log/perfschema.dml_ews_by_thread_by_event_name/' Retrying test perfschema.dml_ews_by_thread_by_event_name, attempt(2/3)... perfschema.dml_ews_by_thread_by_event_name [ retry-fail ] Test ended at 2010-11-30 20:41:20 Problem: using the construct: --replace_column 1 # 2 # 3 # 4 # 5 # 6 # 7 # select * from performance_schema.events_waits_summary_by_thread_by_event_name where event_name like 'Wait/Synch/%' limit 1; is too sensitive to the table content, which is not the point of the test. This is a test script issue. How to repeat: N/A Suggested fix: Fix the script to use --disable_query_log instead, for all the dml_*.test scripts: this will make the test script more robust.