Bug #58512 Performance_schema.myisam_file_io fails sporadically in PB2

• Submitted: 26 Nov 2010 8:47
• Modified: 6 Jan 2011 2:51
• Reporter: Marc ALFF
• Status: Closed
• Category: MySQL Server: Performance Schema
• Severity: S3 (Non-critical)
• Version: 5.5
• OS: Any
• Assigned to: Marc ALFF
• CPU Architecture: Any

[26 Nov 2010 8:47] Marc ALFF

Description:
Example of failure:

CURRENT_TEST: perfschema.myisam_file_io
--- /export/home4/pb2/test/sb_3-2586524-1290688249.32/mysql-5.5.8-linux-x86_64-test/mysql-test/suite/perfschema/r/myisam_file_io.result	2010-11-25 15:24:08.000000000 +0300
+++ /export/home4/pb2/test/sb_3-2586524-1290688249.32/mysql-5.5.8-linux-x86_64-test/mysql-test/suite/perfschema/r/myisam_file_io.reject	2010-11-25 16:03:52.000000000 +0300
@@ -18,6 +18,7 @@
 where operation not like "tell"
   order by thread_id, event_id;
 event_name	short_source	operation	number_of_bytes	short_name
+wait/io/file/innodb/innodb_data_file	fil0fil.c:	sync	NULL	
 wait/io/file/myisam/kfile	mi_create.c:	create	NULL	no_index_tab.MYI
 wait/io/file/myisam/dfile	mi_create.c:	create	NULL	no_index_tab.MYD
 wait/io/file/myisam/kfile	mi_open.c:	write	176	no_index_tab.MYI

How to repeat:
Run tests

Suggested fix:
Disable non myisam instruments for the test.

[30 Nov 2010 19:27] Omer Barnir

Is this a server bug or a problem in the test case?

[1 Dec 2010 6:40] Marc ALFF

Hi Omer

This is a bug in the test script.

[1 Dec 2010 9:25] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/125625

3158 Marc Alff	2010-12-01
      Bug#58512 Performance_schema.myisam_file_io fails sporadically in PB2
      
      Before this fix, the test myisam_file_io executed:
      - (a) an update on setup_instrument to disable non myisam file io instruments
      - (b) a truncate on events_waits_history_long
      and later
      - (c) a select on events_waits_history_long
      
      Surprisingly, events that were supposed to be disabled in (a) and removed in (b)
      still were found in (c).
      
      This happened for events such as 
        wait/io/file/innodb/innodb_data_file fil0fil.c: sync  
      because the sync was started before (a) and completed after (b),
      and as a consequence was added in the performance schema history, as expected.
      
      Presence of these records in the history made the test fail. 
      
      This fix makes the test script more robust to account for extra spill waits records in (c).

[1 Dec 2010 17:19] Christopher Powers

Patch approved.

[1 Dec 2010 18:54] Marc ALFF

Pushed into:
- mysql-5.5-bugteam
- mysql-trunk-bugfixing

[5 Dec 2010 12:42] Bugs System

Pushed into mysql-trunk 5.6.1 (revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (version source revid:[e-mail]-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

[11 Dec 2010 17:03] Paul DuBois

Bug not present in any 5.6.x release.

Setting report to Need Merge pending push into 5.5.x.

[17 Dec 2010 12:53] Bugs System

Pushed into mysql-5.5 5.5.9 (revid:[e-mail]-20101217124733-p1ivu6higouawv8l) (version source revid:[e-mail]-20101201180757-db5woxysu9kenfau) (merge vers: 5.5.8) (pib:24)

[6 Jan 2011 2:51] Paul DuBois

Changes to test suite. No changelog entry needed.