MySQL Bugs: #58178: "make package" is broken with cmake 2.8.3

Bug #58178	"make package" is broken with cmake 2.8.3
Submitted:	13 Nov 2010 17:34	Modified:	15 Dec 2010 1:24
Reporter:	Vladislav Vaintroub	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Packaging	Severity:	S2 (Serious)
Version:	5.5+	OS:	Any
Assigned to:	Vladislav Vaintroub	CPU Architecture:	Any

Description:
With cmake 2.8.3 (which was recently released),
"make package" does not do what it should anymore. It creates several *.tar.gz (or on Windows, *.zip) packages, once per COMPONENT (CMake components, we use them for MSI work). We need single "monolithical" package instead.

The component-based install for archives with 2.8.3 was surpising, and it looks like currently there is no perfect fix for it (I filed  CPack bug for the issue here http://public.kitware.com/Bug/view.php?id=11452), non-perfect fix is relatively easy.

How to repeat:
cd <repo>
mkdir xxx
cd xxx
cmake ..
make package

<compile etc...>

CPack: - package: /home/vvaintroub/bzr/mysql-server/xxx/mysql-5.6.99-m5-linux-x86_64-Client.tar.gz generated.
CPack: - package: /home/vvaintroub/bzr/mysql-server/xxx/mysql-5.6.99-m5-linux-x86_64-DataFiles.tar.gz generated.
CPack: - package: /home/vvaintroub/bzr/mysql-server/xxx/mysql-5.6.99-m5-linux-x86_64-DebugBinaries.tar.gz generated.
CPack: - package: /home/vvaintroub/bzr/mysql-server/xxx/mysql-5.6.99-m5-linux-x86_64-Development.tar.gz generated.
CPack: - package: /home/vvaintroub/bzr/mysql-server/xxx/mysql-5.6.99-m5-linux-x86_64-IniFiles.tar.gz generated.
CPack: - package: /home/vvaintroub/bzr/mysql-server/xxx/mysql-5.6.99-m5-linux-x86_64-Server.tar.gz generated.
CPack: - package: /home/vvaintroub/bzr/mysql-server/xxx/mysql-5.6.99-m5-linux-x86_64-SharedLibraries.tar.gz generated.
CPack: - package: /home/vvaintroub/bzr/mysql-server/xxx/mysql-5.6.99-m5-linux-x86_64-Test.tar.gz generated.

Suggested fix:
use CPACK_MONOLITHICAL_INSTALL=1, but reset it to 0 for creation of MSI packages.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123792

3121 Vladislav Vaintroub	2010-11-13
      Bug#58178:  "make package" is broken with cmake 2.8.3
      
      Problem:  with "make package" , many small packages are 
      generated, one per CMake COMPONENT, instead of expected single
      package. This is due to the new (in cmake 2.8.3) component-based 
      install for archive( e.g ZIP,TGZ ) CPack generators.
      
      See http://public.kitware.com/Bug/view.php?id=11452 for discussion.
      
      Fix: use CPACK_MONOLITHIC_INSTALL=1 to enforce single package.
      Reset this variable temporarily to 0 for  MSI creation  (MSI needs 
      COMPONENTs)

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/123795

3121 Vladislav Vaintroub	2010-11-13
      Bug#58178:  "make package" is broken with cmake 2.8.3
      
      Problem:  with "make package" , many small packages are 
      generated, one per CMake COMPONENT, instead of expected single
      package. This is due to the new (in cmake 2.8.3) component-based 
      install for archive( e.g ZIP,TGZ ) CPack generators.
      
      See http://public.kitware.com/Bug/view.php?id=11452 for discussion.
      
      Fix: use CPACK_MONOLITHIC_INSTALL=1 to enforce single package.
      Reset this variable temporarily to 0 for  MSI creation  (MSI needs 
      COMPONENTs)

pushed to 5.5-bugteam, next-mr-bugfixing

Pushed into mysql-trunk 5.6.1 (revid:alexander.nozdrin@oracle.com-20101205122447-6x94l4fmslpbttxj) (version source revid:alexander.nozdrin@oracle.com-20101205122447-6x94l4fmslpbttxj) (merge vers: 5.6.1) (pib:23)

CPACK_MONOLITHIC_INSTALL is documented here:

http://dev.mysql.com/doc/refman/5.5/en/installing-source-distribution.html
http://dev.mysql.com/doc/refman/5.5/en/source-configuration-options.html

Pushed into mysql-5.5 5.5.9 (revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (version source revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)