MySQL Bugs: #57746: Win directory of source distribution - out-of-date files / support for new files

Bug #57746	Win directory of source distribution - out-of-date files / support for new files
Submitted:	26 Oct 2010 18:30	Modified:	14 Dec 2010 23:26
Reporter:	Santo Leto	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Packaging	Severity:	S3 (Non-critical)
Version:	5.5-bzr	OS:	Windows (Vista)
Assigned to:	Sunanda Menon	CPU Architecture:	Any
Tags:	build-vs10.bat, build-vs71.bat, vs10, vs7

Description:
There are some old files in the win directory of the source distribution. Some others could be added. Some others need to be updated.

- Remove:
If VS 7 can't compile MySQL on Windows anymore, I think we should remove the file build-vs71.bat.

- Add:
I think it's better if we include a file "build-vs10.bat" (and "build-vs10_x64.bat" as well) so that users can run these .bat files when they want to use Visual Studio 10.

In fact, it seems that cmake isn't smart enough to always understand the latest VS installed when running a simple "cmake ." - or at least it has failed on my machine, where I have different versions of VS (my cmake version is 2.8.2). Adding .bat files for VS 2010 might be useful.

If we don't want to add the files, we need to document the -G option of cmake.

- Update:
Step 6 of the README file included in the win directory should be updated as well (to remove reference to VS 7.1 and to the build-vs71.bat file, and to add support for VS 10 and file build-vs10.bat).

How to repeat:
Browse win directory.

Suggested fix:
See above.

Thank you for the bug report.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122611

3117 smenon	2010-11-03
      Bug #57746: Win directory of source distribution - out-of-date files / support for new files

Patch approved, please go ahead.

I'd suggest a few more changes:

 - "sources.Use", 2 spaces after full stop

 - The recommended procedure is to perform the build in a seperate directory, e.g:

     md bld
     cd bld
     cmake .. [cmake args]

   We should reflect that in the README.  This method also makes the removal of
   the CMakeCache.txt obsolete, instead you just rmdir bld and start again.

 - I think the entire Step 5 should be removed, it's obsolete and instead
    you should just pass arguments to the cmake command line, e.g.

     cmake .. -G "<target>" -DWITH_INNOBASE_STORAGE_ENGINE=1

   even better, we should recommend users use

     -DBUILD_CONFIG=mysql_release

   to build binaries exactly the same as we do for releases.

 - Step 7 should also include a way to build on the command line, e.g:

     devenv MySql.sln /build RelWithDebInfo

 - The VS 10 instructions should follow the same format as the existing entries.

Perhaps it's even worth removing most of this file and just pointing users
at the wiki page:

  http://forge.mysql.com/wiki/CMake

and add any information there which is missing from the README.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/122814

3118 smenon	2010-11-04
      Bug #57746: Win directory of source distribution - out-of-date files / support for new files
      (win/README updated with some more changes)

Pushed into mysql-trunk 5.6.99-m5 (revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (version source revid:alexander.nozdrin@oracle.com-20101113152450-2zzcm50e7i4j35v7) (merge vers: 5.6.1-m4) (pib:21)

Pushed into mysql-next-mr (revid:alexander.nozdrin@oracle.com-20101113160336-atmtmfb3mzm4pz4i) (version source revid:alexander.nozdrin@oracle.com-20101113152540-gxro4g0v29l27f5x) (pib:21)

This affects information files in the source distribution. No changelog entry needed.

Pushed into mysql-5.5 5.5.9 (revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (version source revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)