| Bug #57744 | sql-common/client.c: Missing DBUG_RETURN macro | ||
|---|---|---|---|
| Submitted: | 26 Oct 2010 16:45 | Modified: | 11 Dec 2010 17:32 |
| Reporter: | Paul DuBois | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Compiling | Severity: | S3 (Non-critical) |
| Version: | 5.5.8 | OS: | Any |
| Assigned to: | Georgi Kodinov | CPU Architecture: | Any |
[26 Oct 2010 17:39]
MySQL Verification Team
Which source tree are you using?. Thanks in advance.
[26 Oct 2010 18:09]
Paul DuBois
mysql-5.5-security, which currently has a version of 5.5.8.
[26 Oct 2010 18:09]
Paul DuBois
I have debugging enabled, by the way.
[26 Oct 2010 19:22]
MySQL Verification Team
Thank you for the feedback.
[10 Nov 2010 15:22]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/123440 3114 Georgi Kodinov 2010-11-10 Bug #57744: sql-common/client.c: Missing DBUG_RETURN macro - added missing DBUG_RETURN - fixed whitespace according to coding style.
[10 Nov 2010 15:54]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/123447 3115 Georgi Kodinov 2010-11-10 Bug #57744: sql-common/client.c: Missing DBUG_RETURN macro - added missing DBUG_RETURN - fixed whitespace according to coding style.
[13 Nov 2010 16:13]
Bugs System
Pushed into mysql-trunk 5.6.99-m5 (revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (version source revid:alexander.nozdrin@oracle.com-20101113152450-2zzcm50e7i4j35v7) (merge vers: 5.6.1-m4) (pib:21)
[13 Nov 2010 16:34]
Bugs System
Pushed into mysql-next-mr (revid:alexander.nozdrin@oracle.com-20101113160336-atmtmfb3mzm4pz4i) (version source revid:alexander.nozdrin@oracle.com-20101113152540-gxro4g0v29l27f5x) (pib:21)
[11 Dec 2010 17:32]
Paul DuBois
Noted in 5.5.8 changelog. In debug builds, a missing DBUG_RETURN macro in sql/client.c caused mysql to be unable to connect to the server.
[16 Dec 2010 22:29]
Bugs System
Pushed into mysql-5.5 5.5.9 (revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (version source revid:jonathan.perkin@oracle.com-20101216101358-fyzr1epq95a3yett) (merge vers: 5.5.9) (pib:24)
Description: Attempting to use one of the built-in auth plugins, I get this: % mysql --default-auth=mysql_old_password /var/mysql/50508/bin/mysql: debugger aborting because missing DBUG_RETURN or DBUG_VOID_RETURN macro in function "old_password_auth_client" How to repeat: See above. Suggested fix: === modified file 'sql-common/client.c' --- sql-common/client.c 2010-10-04 12:54:41 +0000 +++ sql-common/client.c 2010-10-26 16:38:57 +0000 @@ -4265,7 +4265,7 @@ static int old_password_auth_client(MYSQ { /* read the scramble */ if ((pkt_len= vio->read_packet(vio, &pkt)) < 0) - return CR_ERROR; + DBUG_RETURN (CR_ERROR); if (pkt_len != SCRAMBLE_LENGTH_323 + 1 && pkt_len != SCRAMBLE_LENGTH + 1)