Bug #57106 Robustness of memcpy calls in the performance schema

• Submitted: 29 Sep 2010 16:04
• Modified: 11 Dec 2010 17:05
• Reporter: Marc ALFF
• Status: Closed
• Category: MySQL Server: Performance Schema
• Severity: S3 (Non-critical)
• Version: 5.6
• OS: Any
• Assigned to: Marc ALFF
• CPU Architecture: Any

[29 Sep 2010 16:04] Marc ALFF

Description:
This bug is a follow up of:

Bug#56761 Segfault on CHECKSUM TABLE performance_schema.EVENTS_WAITS_HISTORY EXTENDED

The same issue with robustness of calls to memcpy() needs to be fixed for the new tables implemented in 5.6 only: THREADS, SETUP_ACTORS.

The length of a buffer needs to be sanitized before calling memcpy, in table_setup_actors.cc and table_threads.cc

How to repeat:
Read the code

Suggested fix:
Same as bug#56761

[7 Oct 2010 21:17] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120308

3321 Marc Alff	2010-10-07
      Bug#57106 Robustness of memcpy calls in the performance schema
      
      Before this fix:
      - SELECT * from SETUP_ACTORS
      - SELECT * from THREADS
      could lead to crashes inside a memcpy,
      because the length of the memory to copy was not checked.
      
      This fix makes these tables more robust to invalid data,which can be produced with edge conditions when the record read is changing.

[7 Oct 2010 23:40] Christopher Powers

Ok to push.

[8 Oct 2010 15:08] Marc ALFF

Pushed into mysql-next-mr-bugfixing

[13 Nov 2010 16:13] Bugs System

Pushed into mysql-trunk 5.6.99-m5 (revid:[e-mail]-20101113155825-czmva9kg4n31anmu) (version source revid:[e-mail]-20100629074804-359l9m9gniauxr94) (merge vers: 5.6.99-m4) (pib:21)

[13 Nov 2010 16:36] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20101113160336-atmtmfb3mzm4pz4i) (version source revid:[e-mail]-20100804103744-vbpeghipkz6pyc9z) (pib:21)

[11 Dec 2010 17:05] Paul DuBois

Bug not present in any 5.6.x release. No changelog entry needed.