MySQL Bugs: #56375: Test "mysqld--help-notwin" assumes fixed socket path, fails for RPMs

Bug #56375	Test "mysqld--help-notwin" assumes fixed socket path, fails for RPMs
Submitted:	30 Aug 2010 15:29	Modified:	16 Nov 2010 2:00
Reporter:	Joerg Bruehe	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tests: Server	Severity:	S3 (Non-critical)
Version:	5.5.6-m3	OS:	Linux (RPM packages)
Assigned to:	Bernt Marius Johnsen	CPU Architecture:	Any

Description:
This is a quote from the 5.5.6-m3 test logs for all RPM builds:

=====
main.mysqld--help-notwin                 [ retry-fail ]
        Test ended at YYYY-MM-DD HH:MM:SS

CURRENT_TEST: main.mysqld--help-notwin
--- /PATH/mysql-test/r/mysqld--help-notwin.result
+++ /PATH/mysql-test/r/mysqld--help-notwin.reject
@@ -913,7 +913,7 @@
 slave-type-conversions
 slow-launch-time 2
 slow-query-log FALSE
-socket /tmp/mysql.sock
+socket /var/lib/mysql/mysql.sock
 sort-buffer-size 2097152
 sporadic-binlog-dump-fail FALSE
 sql-mode

mysqltest: Result content mismatch
=====

The different path name is correct, our RPMs have different settings than our tar.gz builds.

How to repeat:
Build a RPM and watch the test suite run.

It will also happen when one of our users/customers lets the test suite run on a RPM installation.

Suggested fix:
Use "--replace-result $MASTER_MYSOCK MASTER_SOCKET" in the test,
and adapt the result file.

On 5.5.6-RC1 run on OpenSUSE 11.0 I get even more differences when this test is run:

/mtr mysqld--help-notwin
Logging: ./mtr  mysqld--help-notwin
100929 15:19:04 [Note] Plugin 'FEDERATED' is disabled.
MySQL Version 5.5.6
Checking supported features...
 - skipping ndbcluster, mysqld not compiled with ndbcluster
 - SSL connections supported
Collecting tests...
vardir: /usr/share/mysql-test/var
Checking leftover processes...
Removing old var directory...
Creating var directory '/usr/share/mysql-test/var'...
Installing system database...
Using server port 6029
worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009

==============================================================================

TEST                                      RESULT   TIME (ms)
------------------------------------------------------------

worker[1] mysql-test-run: WARNING: running this script as _root_ will cause some tests to be skipped
main.mysqld--help-notwin                 [ fail ]
        Test ended at 2010-09-29 15:19:11

CURRENT_TEST: main.mysqld--help-notwin
--- /usr/share/mysql-test/r/mysqld--help-notwin.result  2010-09-29 16:19:01.000000000 +0300
+++ /usr/share/mysql-test/r/mysqld--help-notwin.reject  2010-09-29 16:19:10.000000000 +0300
@@ -688,7 +688,7 @@
  How many threads we should keep in a cache for reuse
  --thread-handling=name
  Define threads usage for handling queries, one of
- one-thread-per-connection, no-threads, loaded-dynamically
+ one-thread-per-connection, no-threads
  --thread-stack=#    The stack size for each thread
  --time-format=name  The TIME format (ignored)
  --timed-mutexes     Specify whether to time mutexes (only InnoDB mutexes are
@@ -860,9 +860,9 @@
 performance-schema-max-file-handles 32768
 performance-schema-max-file-instances 10000
 performance-schema-max-mutex-classes 200
-performance-schema-max-mutex-instances 1000000
-performance-schema-max-rwlock-classes 30
-performance-schema-max-rwlock-instances 1000000
+performance-schema-max-mutex-instances 1000
+performance-schema-max-rwlock-classes 20
+performance-schema-max-rwlock-instances 1000
 performance-schema-max-table-handles 100000
 performance-schema-max-table-instances 50000
 performance-schema-max-thread-classes 50
@@ -913,7 +913,7 @@
 slave-type-conversions
 slow-launch-time 2
 slow-query-log FALSE
-socket /tmp/mysql.sock
+socket /var/lib/mysql/mysql.sock
 sort-buffer-size 2097152
 sporadic-binlog-dump-fail FALSE
 sql-mode

mysqltest: Result content mismatch

 - saving '/usr/share/mysql-test/var/log/main.mysqld--help-notwin/' to '/usr/share/mysql-test/var/log/main.mysqld--help-notwin/'
------------------------------------------------------------
The servers were restarted 0 times
Spent 0.000 of 7 seconds executing testcases

Completed: Failed 1/1 tests, 0.00% were successful.

Failing test(s): main.mysqld--help-notwin

The log files in var/log may give you some hint of what went wrong.

If you want to report this error, please read first the documentation
at http://dev.mysql.com/doc/mysql/en/mysql-test-suite.html

mysql-test-run: *** ERROR: there were failing test case

The comment above applies to OpenSuSE 11.0, 32-bit and Mysql from RPM: 

MySQL-client-5.5.6_rc-1.linux2.6.i386.rpm
MySQL-server-5.5.6_rc-1.linux2.6.i386.rpm
MySQL-test-5.5.6_rc-1.linux2.6.i386.rpm

False alarm. The bug behaves as Joerg originally reported.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/119547

3211 Bernt M. Johnsen	2010-09-30
      Bug#56375 Ignore socket path since it may vary. Added some comments to
      inline perl in the test.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/119668

3203 Bernt M. Johnsen	2010-10-01 [merge]
      Bug#56375 Merged from 5.5-bugteam

Changes to test suite. No changelog entry needed.

Pushed into mysql-5.5 5.5.7-rc (revid:sunanda.menon@sun.com-20101109182959-otkxq8vo2dcd13la) (version source revid:marko.makela@oracle.com-20100824081003-v4ecy0tga99cpxw2) (merge vers: 5.1.50) (pib:21)

Pushed into mysql-trunk 5.6.99-m5 (revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (version source revid:marko.makela@oracle.com-20100824081003-v4ecy0tga99cpxw2) (merge vers: 5.1.50) (pib:21)

Pushed into mysql-next-mr (revid:alexander.nozdrin@oracle.com-20101113160336-atmtmfb3mzm4pz4i) (version source revid:marko.makela@oracle.com-20100824081003-v4ecy0tga99cpxw2) (pib:21)