Bug #54906 Inconsistent license of libmysqld

• Submitted: 30 Jun 2010 1:47
• Modified: 3 Oct 2010 1:37
• Reporter: Marc ALFF
• Status: Closed
• Category: MySQL Server: Embedded Library ( libmysqld )
• Severity: S1 (Critical)
• Version: mysql-next-mr, 5.5
• OS: Any
• Assigned to: Alexey Botchkov
• CPU Architecture: Any

[30 Jun 2010 1:47] Marc ALFF

Description:
In file libmysqld/Makefile.am,
the License is the LGPL

In file libmysqld/CMakeLists.txt,
the license is the GPL.

This can't be: the binary of the library built should not depend
on the makefile used to build it.

How to repeat:
Read the code

Suggested fix:
Use the same license.

In both cases, also fix the street address, including zip code.

[30 Jun 2010 4:17] Valeriy Kravchuk

Sorry, but where do you see LGPL mentioned in libmysqld/CMakeLists.txt?

Somehow I miss it:

valeriy-kravchuks-macbook-pro:mysql-next-mr openxs$ grep LGPL libmysqld/CMakeLists.txt 
valeriy-kravchuks-macbook-pro:mysql-next-mr openxs$ grep -i libra libmysqld/CMakeLists.txt 
ADD_DEFINITIONS(-DMYSQL_SERVER -DEMBEDDED_LIBRARY
ADD_CONVENIENCE_LIBRARY(sql_embedded ${SQL_EMBEDDED_SOURCES})
# On Windows, static embedded server library is called mysqlserver.lib
  ${ZLIB_LIBRARY} ${SSL_LIBRARIES} 
MERGE_LIBRARIES(mysqlserver STATIC ${EMBEDDED_LIBS} 
# Visual Studio users need debug  static library 
  ${CMAKE_STATIC_LIBRARY_PREFIX}mysqld-debug)
  MERGE_LIBRARIES(libmysqld SHARED ${LIBS} EXPORTS ${CLIENT_API_FUNCTIONS})

[30 Jun 2010 4:19] Valeriy Kravchuk

Ups, sorry. Ignore my previous comment. 

Indeed, LGPL is not mentioned, while it is mentioned in Makefile.am.

[12 Aug 2010 8:44] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/115548

3203 Alexey Botchkov	2010-08-11
      Bug#54906      Inconsistent license of libmysqld
              made libmysqld/CMakeLists.txt to have same licence as libmysqld/Makefile.am
      
      per-file comments:
        libmysqld/CMakeLists.txt
      Bug#54906      Inconsistent license of libmysqld
              license modified to be Library GPL

[25 Aug 2010 15:48] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/116782

3195 Alexey Botchkov	2010-08-25
      Bug#54906      Inconsistent license of libmysqld
             made libmysqld/Makefile.am to have same licence as libmysqld/CMakeLists.txt
      
      per-file comments:
        libmysqld/Makefile.am
      Bug#54906      Inconsistent license of libmysqld
              Added GPL license header instead of Library GPL.

[1 Sep 2010 4:41] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/117286

3199 Alexey Botchkov	2010-09-01
      Bug#54906      Inconsistent license of libmysqld
             made libmysqld/Makefile.am to have same licence as libmysqld/CMakeLists.txt
      
      per-file comments:
        libmysqld/Makefile.am
      Bug#54906      Inconsistent license of libmysqld
              Added GPL license header instead of Library GPL.

[1 Sep 2010 13:56] Alexey Botchkov

pushed into 5.5

[2 Oct 2010 18:13] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:[e-mail]-20101002180948-852x1cuv7c6i85ea) (version source revid:[e-mail]-20101002180857-an32jpuwzemsp4f2) (merge vers: 5.6.1-m4) (pib:21)

[2 Oct 2010 18:16] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20101002181053-6iotvl26uurcoryp) (version source revid:[e-mail]-20101002180917-h0n62akupm3z20nt) (pib:21)

[2 Oct 2010 18:16] Bugs System

Pushed into mysql-5.5 5.5.7-rc (revid:[e-mail]-20101002180831-590ka2tuit9qoxbb) (version source revid:[e-mail]-20101002180831-590ka2tuit9qoxbb) (merge vers: 5.5.7-rc) (pib:21)

[3 Oct 2010 1:37] Paul DuBois

No user impact. No changelog entry needed.