Bug #54739 Accidental change in compile-time definitions for FreeBSD
Submitted: 23 Jun 2010 13:45 Modified: 20 Aug 2010 14:49
Reporter: Joerg Bruehe Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S1 (Critical)
Version:5.5.5-m3 OS:FreeBSD
Assigned to: Joerg Bruehe CPU Architecture:Any

[23 Jun 2010 13:45] Joerg Bruehe 
Description:
In "configure.in" (for builds using autotools)
and in "cmake/os/FreeBSD.cmake" (for builds using cmake),
I accidentally introduced the definition of "HAVE_BROKEN_REALPATH" even for current versions of FreeBSD.

This needs to be undone ASAP, to avoid the generation of wrong paths in the code.

How to repeat:
Inspect the code.

Suggested fix:
Remove the offending definition in both files.
[23 Jun 2010 14:20] Bugs System 
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111925

3071 Joerg Bruehe	2010-06-23
      Fix Bug #54739
      Accidental change in compile-time definitions for FreeBSD
      
      
      Revert the accidental setting of "HAVE_BROKEN_REALPATH"
      on current versions of FreeBSD,
      
      do it for both autotools ("configure.in")
      and cmake ("cmake/os/FreeBSD.cmake").
[29 Jun 2010 23:42] Omer Barnir 
triage: not clear what are the side effects but as this was done by mistake and is a correction to a recent change it should go in - SR55RC
[19 Jul 2010 10:15] Bugs System 
Pushed into 5.5.6-m3 (revid:build@mysql.com-20100719101001-0ykgx8ceoq7s458e) (version source revid:build@mysql.com-20100719101001-0ykgx8ceoq7s458e) (merge vers: 5.5.6-m3) (pib:16)
[23 Jul 2010 12:30] Bugs System 
Pushed into mysql-next-mr (revid:alik@sun.com-20100723121929-90e9zemk3jkr2ocy) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (pib:18)
[20 Aug 2010 14:46] Joerg Bruehe 
Sadly, status change was missing.

The patch is in the main trees,
it was already used for 5.5.5-m3 and 5.6.0-m4,
and it will be used for all later versions of 5.5, 5.6, and up.
[20 Aug 2010 14:49] MC Brown 
No user visible changes; not changelog entry required.