Bug #54678 | InnoDB, TRUNCATE, ALTER, I_S SELECT, crash or deadlock | ||
---|---|---|---|
Submitted: | 21 Jun 2010 19:43 | Modified: | 7 Dec 2010 21:36 |
Reporter: | Matthias Leich | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | MySQL Server: InnoDB Plugin storage engine | Severity: | S2 (Serious) |
Version: | 5.1,5.5.5-m3 | OS: | Any |
Assigned to: | Jimmy Yang | CPU Architecture: | Any |
Tags: | crash, deadlock, information_schema, innodb |
[21 Jun 2010 19:43]
Matthias Leich
[21 Jun 2010 19:47]
Matthias Leich
crash in mysql-trunk-runtime
Attachment: crash.prt (application/octet-stream, text), 57.65 KiB.
[21 Jun 2010 19:50]
Matthias Leich
Deadlock in mysql-5.1
Attachment: deadlock_5.1.prt (application/octet-stream, text), 2.57 KiB.
[29 Jul 2010 13:36]
Jimmy Yang
The issue here is that MDL does not know if InnoDB truncate table would take either drop/recreate table approach or delete row-by-row approach. Ideally, we should take EXCLUSIVE lock if we are going through drop/recreate table approach as in this case, and SHARE lock if we are going through delete row by row approach. However, such communication is not available currently, and need to be devised. The conclusion is that we remove the assertion in this case, and work on a complete solution in 5.5. <jyang> so kostja, let's conclude here, I will check in a fix to skip the assert and pass 0 count to ::info in this case <kostja> jyang: yes, in 5.1 it's the only option <kostja> and in 5.5 we need a good fix that we develop together <jyang> However, to resolve it completely, we need to device a way to block folks to poke into metadata while we are drop/recreating <kostja> jyang: i agree. <kostja> so we need a two-phase truncate
[28 Sep 2010 8:46]
Bugs System
Pushed into mysql-5.1 5.1.52 (revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (version source revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (merge vers: 5.1.52) (pib:21)
[29 Sep 2010 22:39]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/119465
[4 Oct 2010 22:05]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/119926
[6 Oct 2010 1:47]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/120041
[6 Oct 2010 1:53]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/120042
[6 Oct 2010 11:35]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/120103 3156 Davi Arnaut 2010-10-06 Bug#49938: Failing assertion: inode or deadlock in fsp/fsp0fsp.c Bug#54678: InnoDB, TRUNCATE, ALTER, I_S SELECT, crash or deadlock The problem was that for storage engines that do not support truncate table via a external drop and recreate, such as InnoDB which implements truncate via a internal drop and recreate, the delete_all_rows method could be invoked with a shared metadata lock, causing problems if the engine needed exclusive access to some internal metadata. This problem originated with the fact that there is no truncate specific handler method, which ended up leading to a abuse of the delete_all_rows method that is primarily used for delete operations without a condition. The solution is to introduce a truncate handler method that is invoked when the engine does not support truncation via a table drop and recreate. This method is invoked under a exclusive metadata lock, so that there is only a single instance of the table when the method is invoked. Also, the method is not invoked and a error is thrown if the table is a parent in a non-self-referencing foreign key relationship. This was necessary to avoid inconsistency as some integrity checks are bypassed. This is inline with the fact that truncate is primarily a DDL operation that was designed to quickly remove all data from a table. Incompatible change: truncate no longer resorts to a row by row delete if the storage engine does not support the truncate method. Consequently, the count of affected rows does not, in any case, reflect the actual number of rows. Incompatible change: it is no longer possible to truncate a table that is referenced to by a foreign key in another table. @ mysql-test/suite/innodb/t/innodb-truncate.test Add test cases for truncate and foreign key checks. Also test that InnoDB resets auto-increment on truncate. @ mysql-test/suite/innodb/t/innodb.test FK is not necessary, test is related to auto-increment. Update error number, truncate is no longer invoked if table is parent in a FK relationship. @ mysql-test/suite/innodb/t/innodb_mysql.test Update error number, truncate is no longer invoked if table is parent in a FK relationship. Use delete instead of truncate, test is used to check the interaction of FKs, triggers and delete. @ mysql-test/suite/parts/inc/partition_check.inc Fix typo. @ mysql-test/suite/sys_vars/t/foreign_key_checks_func.test Update error number, truncate is no longer invoked if table is parent in a FK relationship. @ mysql-test/t/mdl_sync.test Modify test case to reflect and ensure that truncate takes a exclusive metadata lock. @ mysql-test/t/trigger-trans.test Update error number, truncate is no longer invoked if table is parent in a FK relationship. @ sql/ha_partition.cc Reorganize the various truncate methods. delete_all_rows is now passed directly to the underlying engines, so as truncate. The code responsible for truncating individual partitions is moved to ha_partition::truncate_partition, which is invoked when a ALTER TABLE t1 TRUNCATE PARTITION p statement is executed. Since the partition truncate no longer can be invoked via delete, the bitmap operations are not necessary anymore. The explicit reset of the auto-increment value is also removed as the underlying engines are now responsible for reseting the value. @ sql/handler.cc Wire up the handler truncate method. @ sql/handler.h Introduce and document the truncate handler method. It assumes certain use cases of delete_all_rows. Add method to retrieve the list of foreign keys referencing a table. Method is used to avoid truncating tables that are parent in a foreign key relationship. @ sql/share/errmsg-utf8.txt Add error message for truncate and FK. @ sql/sql_lex.h Introduce a flag so that the partition engine can detect when a partition is being truncated. Used to give a special error. @ sql/sql_parse.cc Function mysql_truncate_table no longer exists. @ sql/sql_partition_admin.cc Implement the TRUNCATE PARTITION statement. @ sql/sql_truncate.cc Change the truncate table implementation to use the new truncate handler method and to not rely on row-by-row delete anymore. The truncate handler method is always invoked with a exclusive metadata lock. Also, it is no longer possible to truncate a table that is parent in some non-self-referencing foreign key. @ storage/archive/ha_archive.cc Rename method as the description indicates that in the future this could be a truncate operation. @ storage/blackhole/ha_blackhole.cc Implement truncate as no operation for the blackhole engine in order to remain compatible with older releases. @ storage/federated/ha_federated.cc Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. @ storage/heap/ha_heap.cc Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. @ storage/ibmdb2i/ha_ibmdb2i.cc Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. @ storage/innobase/handler/ha_innodb.cc Rename delete_all_rows to truncate. InnoDB now does truncate under a exclusive metadata lock. Introduce and reorganize methods used to retrieve the list of foreign keys referenced by a or referencing a table. @ storage/myisammrg/ha_myisammrg.cc Introduce truncate method that invokes delete_all_rows. This is required in order to remain compatible with earlier releases where truncate would resort to a row-by-row delete.
[6 Oct 2010 14:24]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/120137 3156 Davi Arnaut 2010-10-06 Bug#49938: Failing assertion: inode or deadlock in fsp/fsp0fsp.c Bug#54678: InnoDB, TRUNCATE, ALTER, I_S SELECT, crash or deadlock - Incompatible change: truncate no longer resorts to a row by row delete if the storage engine does not support the truncate method. Consequently, the count of affected rows does not, in any case, reflect the actual number of rows. - Incompatible change: it is no longer possible to truncate a table that participates as a parent in a foreign key constraint, unless it is a self-referencing constraint (both parent and child are in the same table). To work around this incompatible change and still be able to truncate such tables, disable foreign checks with SET foreign_key_checks=0 before truncate. Alternatively, if foreign key checks are necessary, please use a DELETE statement without a WHERE condition. Problem description: The problem was that for storage engines that do not support truncate table via a external drop and recreate, such as InnoDB which implements truncate via a internal drop and recreate, the delete_all_rows method could be invoked with a shared metadata lock, causing problems if the engine needed exclusive access to some internal metadata. This problem originated with the fact that there is no truncate specific handler method, which ended up leading to a abuse of the delete_all_rows method that is primarily used for delete operations without a condition. Solution: The solution is to introduce a truncate handler method that is invoked when the engine does not support truncation via a table drop and recreate. This method is invoked under a exclusive metadata lock, so that there is only a single instance of the table when the method is invoked. Also, the method is not invoked and a error is thrown if the table is a parent in a non-self-referencing foreign key relationship. This was necessary to avoid inconsistency as some integrity checks are bypassed. This is inline with the fact that truncate is primarily a DDL operation that was designed to quickly remove all data from a table. @ mysql-test/suite/innodb/t/innodb-truncate.test Add test cases for truncate and foreign key checks. Also test that InnoDB resets auto-increment on truncate. @ mysql-test/suite/innodb/t/innodb.test FK is not necessary, test is related to auto-increment. Update error number, truncate is no longer invoked if table is parent in a FK relationship. @ mysql-test/suite/innodb/t/innodb_mysql.test Update error number, truncate is no longer invoked if table is parent in a FK relationship. Use delete instead of truncate, test is used to check the interaction of FKs, triggers and delete. @ mysql-test/suite/parts/inc/partition_check.inc Fix typo. @ mysql-test/suite/sys_vars/t/foreign_key_checks_func.test Update error number, truncate is no longer invoked if table is parent in a FK relationship. @ mysql-test/t/mdl_sync.test Modify test case to reflect and ensure that truncate takes a exclusive metadata lock. @ mysql-test/t/trigger-trans.test Update error number, truncate is no longer invoked if table is parent in a FK relationship. @ sql/ha_partition.cc Reorganize the various truncate methods. delete_all_rows is now passed directly to the underlying engines, so as truncate. The code responsible for truncating individual partitions is moved to ha_partition::truncate_partition, which is invoked when a ALTER TABLE t1 TRUNCATE PARTITION p statement is executed. Since the partition truncate no longer can be invoked via delete, the bitmap operations are not necessary anymore. The explicit reset of the auto-increment value is also removed as the underlying engines are now responsible for reseting the value. @ sql/handler.cc Wire up the handler truncate method. @ sql/handler.h Introduce and document the truncate handler method. It assumes certain use cases of delete_all_rows. Add method to retrieve the list of foreign keys referencing a table. Method is used to avoid truncating tables that are parent in a foreign key relationship. @ sql/share/errmsg-utf8.txt Add error message for truncate and FK. @ sql/sql_lex.h Introduce a flag so that the partition engine can detect when a partition is being truncated. Used to give a special error. @ sql/sql_parse.cc Function mysql_truncate_table no longer exists. @ sql/sql_partition_admin.cc Implement the TRUNCATE PARTITION statement. @ sql/sql_truncate.cc Change the truncate table implementation to use the new truncate handler method and to not rely on row-by-row delete anymore. The truncate handler method is always invoked with a exclusive metadata lock. Also, it is no longer possible to truncate a table that is parent in some non-self-referencing foreign key. @ storage/archive/ha_archive.cc Rename method as the description indicates that in the future this could be a truncate operation. @ storage/blackhole/ha_blackhole.cc Implement truncate as no operation for the blackhole engine in order to remain compatible with older releases. @ storage/federated/ha_federated.cc Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. @ storage/heap/ha_heap.cc Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. @ storage/ibmdb2i/ha_ibmdb2i.cc Introduce truncate method that invokes delete_all_rows. This is required to support partition truncate as this form of truncate does not implement the drop and recreate protocol. @ storage/innobase/handler/ha_innodb.cc Rename delete_all_rows to truncate. InnoDB now does truncate under a exclusive metadata lock. Introduce and reorganize methods used to retrieve the list of foreign keys referenced by a or referencing a table. @ storage/myisammrg/ha_myisammrg.cc Introduce truncate method that invokes delete_all_rows. This is required in order to remain compatible with earlier releases where truncate would resort to a row-by-row delete.
[14 Oct 2010 8:38]
Bugs System
Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (version source revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)
[14 Oct 2010 8:53]
Bugs System
Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (version source revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)
[14 Oct 2010 9:08]
Bugs System
Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (version source revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)
[26 Oct 2010 23:26]
John Russell
Adding to change log: A simultaneous TRUNCATE TABLE and examining the same table's information in the INFORMATION_SCHEMA could cause a crash, in the debug version of the server.
[9 Nov 2010 19:47]
Bugs System
Pushed into mysql-5.5 5.5.7-rc (revid:sunanda.menon@sun.com-20101109182959-otkxq8vo2dcd13la) (version source revid:sunanda.menon@sun.com-20101109182959-otkxq8vo2dcd13la) (merge vers: 5.5.7-rc) (pib:21)
[13 Nov 2010 16:08]
Bugs System
Pushed into mysql-trunk 5.6.99-m5 (revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (version source revid:alexander.nozdrin@oracle.com-20101113152450-2zzcm50e7i4j35v7) (merge vers: 5.6.1-m4) (pib:21)
[13 Nov 2010 16:37]
Bugs System
Pushed into mysql-next-mr (revid:alexander.nozdrin@oracle.com-20101113160336-atmtmfb3mzm4pz4i) (version source revid:vasil.dimov@oracle.com-20100629074804-359l9m9gniauxr94) (pib:21)
[7 Dec 2010 21:36]
John Russell
Added to change log for 5.1 and 5.5: Issuing TRUNCATE TABLE and examining the same table's information in the INFORMATION_SCHEMA database at the same time could cause a crash in the debug version of the server. Added to change log for 5.5 only, flagged as 'incompatible change': As a result of this change, InnoDB always uses the fast truncation technique, equivalent to DROP TABLE and CREATE TABLE. It no longer performs a row-by-row delete for tables with parent-child foreign key relationships. TRUNCATE TABLE returns an error for such tables. Modify your SQL to issue DELETE FROM table_name for such tables instead. Added similar 'incompatible change' wording to the 5.1->5.5 upgrade instructions. Removed reference to the row-by-row technique from the TRUNCATE TABLE syntax section.
[9 Dec 2010 18:28]
Francis Huston
How about NOT breaking truncate table when foreign keys are used? Please take the time and fix the issue(s) properly. At a minimum I expect to be able to truncate all tables in a database if I do it in such an order that no rows exist referencing the table being truncated. Of course, given that 'on delete cascade' may be defined on any foreign key it should be possible to truncate a table which does have rows referencing it, provided foreign keys are declared with 'on delete cascade'. We do not need any more arbitrary restrictions stemming from poorly implemented functionality, and this is a regression.
[9 Dec 2010 19:01]
Davi Arnaut
Hi Francis, > At a minimum I expect to be able to truncate all tables in a database > if I do it in such an order that no rows exist referencing the table > being truncated. To do that we would need to check the rows and would make the truncate statement equivalent to a delete. Likewise for cascade. > We do not need any more arbitrary restrictions stemming from > poorly implemented functionality, and this is a regression. The design intention behind truncate has always been to bypass integrity checks. This behavior is similar to those of other database products.