Bug #54590 "make_binary_distribution" fails because a command line exceeds the limit
Submitted: 17 Jun 2010 17:04 Modified: 15 Oct 2010 13:23
Reporter: Joerg Bruehe Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Packaging Severity:S2 (Serious)
Version:5.0.91 OS:IBM AIX
Assigned to: Joerg Bruehe CPU Architecture:Any
Triage: Triaged: D2 (Serious) / R1 (None/Negligible) / E1 (None/Negligible)

[17 Jun 2010 17:04] Joerg Bruehe
Description:
In (at least) the build of 5.0.91, a binary package on AIX does not contain the "*.test" files of the main suite, those stored in "mysql-test/t".

The reason is a failure in "make_binmary_distribution":
scripts/make_binary_distribution[339]: /usr/bin/cp: 0403-027 The parameter list is too long.

Looking at the script, here are the relevant lines:
 339 $CP mysql-test/t/*.test mysql-test/t/*.imtest \
 340     mysql-test/t/*.disabled mysql-test/t/*.opt \
 341     mysql-test/t/*.slave-mi mysql-test/t/*.sh mysql-test/t/*.sql $BASE/mysql-test/t

How to repeat:
Just try it.

Suggested fix:
Don't construct such a long line with continuation,
rather split it into three copy commands.
[17 Jun 2010 17:05] Joerg Bruehe
Fixing it immediately.
[17 Jun 2010 17:47] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111471

2875 Joerg Bruehe	2010-06-17
      Bug#54590  "make_binary_distribution" fails because a command
                 line exceeds the limit
      
      The number and/or names of our files for the main test suite
      (contents of "mysql-test/t/") now exceeds the command line
      length limit on AIX.
      Solve the problem by using separate "cp" commands for the
      various file name extensions.
[17 Jun 2010 17:48] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111472

2875 Joerg Bruehe	2010-06-17
      Bug#54590  "make_binary_distribution" fails because a command
                 line exceeds the limit
      
      The number and/or names of our files for the main test suite
      (contents of "mysql-test/t/") now exceeds the command line
      length limit on AIX.
      Solve the problem by using separate "cp" commands for the
      various file name extensions.
[17 Jun 2010 17:56] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111479

3435 Joerg Bruehe	2010-06-17 [merge]
      Bug#54590  "make_binary_distribution" fails because a command
      line exceeds the limit
      
      Upmerge the fix from 5.0 to 5.1
[17 Jun 2010 18:11] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111482

3100 Joerg Bruehe	2010-06-17 [merge]
      Bug#54590  "make_binary_distribution" fails because a command
      line exceeds the limit
      
      Upmerge the fix from 5.1 to 5.5 ("trunk").
[17 Jun 2010 18:13] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111483

3252 Joerg Bruehe	2010-06-17 [merge]
      Bug#54590  "make_binary_distribution" fails because a command
      line exceeds the limit
      
      Upmerge the fix from "trunk" to "next-mr".
[17 Jun 2010 18:20] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111486

3060 Joerg Bruehe	2010-06-17 [merge]
      Bug#54590  "make_binary_distribution" fails because a command
      line exceeds the limit
      
      Merge the fix into "trunk-bugfixing".
[17 Jun 2010 18:21] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111487

3253 Joerg Bruehe	2010-06-17 [merge]
      Bug#54590  "make_binary_distribution" fails because a command
      line exceeds the limit
      
      Merge the fix into "next-mr-bugfixing".
[17 Jun 2010 18:24] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/111489

3254 Joerg Bruehe	2010-06-17 [merge]
      Upmerge an empty merge changeset,
      related to bug#54590 pushes.
[18 Jun 2010 8:18] Bjørn Munch
Fix looks sensinble and safe, let's assume the commands won't grow to become too long again.
[18 Jun 2010 8:32] Joerg Bruehe
Queued to bugteam/bugfixing trees.
[22 Jun 2010 13:08] Bugs System
Pushed into 5.5.5-m3 (revid:alik@sun.com-20100622130139-u05awgya93zvbsop) (version source revid:alik@sun.com-20100622130139-u05awgya93zvbsop) (merge vers: 5.5.5-m3) (pib:16)
[22 Jun 2010 13:09] Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100622130623-r7yhm89fz9n5t9nb) (version source revid:alik@sun.com-20100622130528-187gd949sa9b6pa6) (pib:16)
[28 Jun 2010 11:49] MC Brown
A note has been added to the 5.5.5 changelog: 

        The <option>make_binary_distribution</option> target                                          
        to <command>make</command> could fail on some platforms                                       
        because the lines generated were too long for the shell.
[19 Jul 2010 14:36] Bugs System
Pushed into 5.1.49 (revid:build@mysql.com-20100719143034-omcma40sblwmay3x) (version source revid:joerg@mysql.com-20100617175521-e29mmiz4xeei4hvg) (merge vers: 5.1.48) (pib:16)
[20 Jul 2010 2:27] Paul Dubois
Noted in 5.1.49 changelog.
[2 Aug 2010 7:50] Bugs System
Pushed into 5.0.92 (revid:georgi.kodinov@oracle.com-20100802074824-5201e4ppst9t3yqt) (version source revid:joerg@mysql.com-20100617174738-j8kihve3r0f0shzu) (merge vers: 5.0.92) (pib:18)
[2 Aug 2010 13:02] MC Brown
Added to 5.0.92 changelog
[4 Aug 2010 8:02] Bugs System
Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:alik@sun.com-20100622130528-187gd949sa9b6pa6) (merge vers: 5.6.99-m4) (pib:18)
[4 Aug 2010 8:18] Bugs System
Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804081533-c1d3rbipo9e8rt1s) (version source revid:alik@sun.com-20100622130528-187gd949sa9b6pa6) (merge vers: 5.6.99-m4) (pib:18)
[4 Aug 2010 19:52] Paul Dubois
Bug is not present in any released 5.6.x version.
[14 Oct 2010 8:31] Bugs System
Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)
[14 Oct 2010 8:47] Bugs System
Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)
[14 Oct 2010 9:01] Bugs System
Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (version source revid:vasil.dimov@oracle.com-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:21)
[15 Oct 2010 13:23] Jon Stephens
Already documented in the 5.1.49 changelog. Reverting to Closed state.