Bug #54144 ER_SLAVE_HEARTBEAT_VALUE_OUT_OF_RANGE is hard coded
Submitted: 1 Jun 2010 13:23 Modified: 15 Nov 2010 13:11
Reporter: Mikiya Okuno Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Replication Severity:S3 (Non-critical)
Version:5.5.4-m3 OS:Any
Assigned to: Luis Soares
Triage: Triaged: D3 (Medium)

[1 Jun 2010 13:23] Mikiya Okuno
Description:
The message for ER_SLAVE_HEARTBEAT_VALUE_OUT_OF_RANGE is hard coded in sql_yacc.yy. The message is English, so we cannot translate it in errmsg.txt for other languages.

How to repeat:
see sql_yacc.yy in 5.5.4-m3

Suggested fix:
The format should be changed, or the error should be separated to three, as there are three patterns.
[27 Sep 2010 16:34] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/119188
[7 Oct 2010 10:50] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120228

3216 Luis Soares	2010-10-07
      BUG#54144: ER_SLAVE_HEARTBEAT_VALUE_OUT_OF_RANGE is hard coded
            
      The error message for ER_SLAVE_HEARTBEAT_VALUE_OUT_OF_RANGE was
      hard coded. Additionally, the same error was used in three
      separate error symptoms: 1. when heartbeat period exceeds the
      value of slave_net_timeout, 2. when it is smaller than 1
      milisecond and 3. when it was not in range, ie, either negative
      or greater than the maximum allowed.
            
      We fix this by splitting into three distinct errors and by
      removing the message from the source code and moving it to the
      errmsg-utf8.txt file.
[7 Oct 2010 15:38] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120277

3216 Luis Soares	2010-10-07
      BUG#54144: ER_SLAVE_HEARTBEAT_VALUE_OUT_OF_RANGE is hard coded
            
      The error message for ER_SLAVE_HEARTBEAT_VALUE_OUT_OF_RANGE was
      hard coded. Additionally, the same error was used in three
      separate error symptoms: 1. when heartbeat period exceeds the
      value of slave_net_timeout, 2. when it is smaller than 1
      milisecond and 3. when it was not in range, ie, either negative
      or greater than the maximum allowed.
            
      We fix this by splitting into three distinct errors and by
      removing the message from the source code and moving it to the
      errmsg-utf8.txt file.
[7 Oct 2010 23:37] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120323

3216 Luis Soares	2010-10-08 [merge]
      BUG#54144: manual merged bzr bundle from bug report.
[7 Oct 2010 23:45] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120324

3245 Luis Soares	2010-10-08 [merge]
      BUG#54144: Manual merged from mysql-5.5-bugteam into mysql-trunk-merge.
      
      Changed result file to match trunk-merge error codes.
[7 Oct 2010 23:46] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/120325

3245 Luis Soares	2010-10-08 [merge]
      BUG#54144: Manually merged from mysql-5.5-bugteam into 
                 mysql-trunk-merge.
      
      Changed result files to match trunk-merge error codes.
[7 Oct 2010 23:54] Luis Soares
Queued in mysql-5.5-bugteam and merged to mysql-trunk-merge:
- http://pb2.norway.sun.com/web.py?template=push_details&push=1632720
- http://pb2.norway.sun.com/web.py?template=push_details&push=1632719
[13 Oct 2010 7:06] Jon Stephens
Documented in the 5.5.7 changelog as follows:

        The error message for ER_SLAVE_HEARTBEAT_VALUE_OUT_OF_RANGE was
        hard coded in English in sql_yacc.yy, so that it could not be
        translated in errmsg.txt for other languages.

        Additionally, this same error message was used for three separate 
        error conditions: 1. when the heartbeat period exceeded the value 
        of slave_net_timeout; 2. when the heartbeat period was nonnegative 
        but shorter than 1 millisecond; 3. when the value for the heartbeat 
        period was either negative or greater than the maximum allowed.

        These issues have been addressed as follows: 1. By using three 
        distinct error messages for each of the conditions listed 
        previously; and 2. By moving the sources for these messages into 
        the errmsg-utf8.txt file to facilitate translations into languages 
        other than English.

Set NM status, waiting for merge to 5.6 tree.
[29 Oct 2010 14:19] Jon Stephens
Already documented in 5.5, still waiting for merge to trunk.
[9 Nov 2010 19:46] Bugs System
Pushed into mysql-5.5 5.5.7-rc (revid:sunanda.menon@sun.com-20101109182959-otkxq8vo2dcd13la) (version source revid:sunanda.menon@sun.com-20101109182959-otkxq8vo2dcd13la) (merge vers: 5.5.7-rc) (pib:21)
[13 Nov 2010 16:12] Bugs System
Pushed into mysql-trunk 5.6.99-m5 (revid:alexander.nozdrin@oracle.com-20101113155825-czmva9kg4n31anmu) (version source revid:alexander.nozdrin@oracle.com-20101113152450-2zzcm50e7i4j35v7) (merge vers: 5.6.1-m4) (pib:21)
[13 Nov 2010 16:34] Bugs System
Pushed into mysql-next-mr (revid:alexander.nozdrin@oracle.com-20101113160336-atmtmfb3mzm4pz4i) (version source revid:vasil.dimov@oracle.com-20100629074804-359l9m9gniauxr94) (pib:21)
[15 Nov 2010 13:12] Jon Stephens
Does not appear in a 5.6 release; no additional changelog entries required.

Closed.