Bug #53148 Remove PFS_readonly_table

• Submitted: 26 Apr 2010 6:43
• Modified: 4 Aug 2010 20:06
• Reporter: Marc ALFF
• Status: Closed
• Category: MySQL Server: Performance Schema
• Severity: S3 (Non-critical)
• Version: 5.5.3-m3, 5.5.4-m3
• OS: Any
• Assigned to: Marc ALFF
• CPU Architecture: Any

[26 Apr 2010 6:43] Marc ALFF

Description:
This is a left over from the code review that was identified but never addressed.

Now that the ACL related code is separated in a different area,
there is no reason to have classes like PFS_readonly_table in the inheritance
tree under PFS_engine_table.

This is a code cleanup bug, no functional impact or visible effect.

How to repeat:
Read the code.

Suggested fix:
To fix:
- remove the class PFS_readonly_table
- implement a default update_row_values() method instead
- adjust all the code

[26 Apr 2010 9:28] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/106485

3150 Marc Alff	2010-04-26
      Bug#53148 Remove PFS_readonly_table
      
      This fix is a code cleanup only, no functional impact.
      
      The class PFS_readonly_table was not needed, and was removed.

[26 Apr 2010 13:57] Marc ALFF

Pushed into:
- mysql-next-mr-bugfixing
- mysql-6.0-codebase-bugfixing

Doc team: no user visible effect to document, minor code cleanup.

[27 Apr 2010 9:46] Bugs System

Pushed into 6.0.14-alpha (revid:[e-mail]-20100427094135-5s49ecp3ckson6e2) (version source revid:[e-mail]-20100427093843-uekr85qkd7orx12t) (merge vers: 6.0.14-alpha) (pib:16)

[27 Apr 2010 9:52] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100427094036-38frbg3famdlvjup) (version source revid:[e-mail]-20100427093825-92wc8b22d4yg34ju) (pib:16)

[28 Apr 2010 2:13] Paul DuBois

No changelog entry needed.

[15 Jul 2010 23:06] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/113714

3114 Marc Alff	2010-07-15
      Bug#53148 Remove PFS_readonly_table
      
      This fix is for cleanup, to resolve a remaining code review item.
      Backport from mysql-next-mr (5.6) to mysql-trunk (5.5).

[16 Jul 2010 0:36] Marc ALFF

Pushed into mysql-trunk-bugfixing (5.5.6)

[16 Jul 2010 0:38] Marc ALFF

Re-closing, nothing to document

[23 Jul 2010 12:25] Bugs System

Pushed into mysql-trunk 5.5.6-m3 (revid:[e-mail]-20100723121820-jryu2fuw3pc53q9w) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (merge vers: 5.5.5-m3) (pib:18)

[23 Jul 2010 12:32] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100723121929-90e9zemk3jkr2ocy) (version source revid:[e-mail]-20100531152341-x2d4hma644icamh1) (pib:18)

[4 Aug 2010 8:07] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:[e-mail]-20100427095914-pzlxbqjjtnngxmf0) (merge vers: 5.6.99-m4) (pib:18)

[4 Aug 2010 8:23] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804081533-c1d3rbipo9e8rt1s) (version source revid:[e-mail]-20100427095914-pzlxbqjjtnngxmf0) (merge vers: 5.6.99-m4) (pib:18)

[4 Aug 2010 20:06] Paul DuBois

No changelog entry needed.