Bug #52323 Add --wait-nodes to ndb_waiter
Submitted: 24 Mar 2010 8:33 Modified: 31 Mar 2010 11:46
Reporter: Jørgen Austvik Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Cluster: Cluster (NDB) storage engine Severity:S4 (Feature request)
Version:mysql-5.1-telco-6.3 OS:Any
Assigned to: Jørgen Austvik CPU Architecture:Any

[24 Mar 2010 8:33] Jørgen Austvik
Description:
ndb_waiter has a --nowait-nodes, but is missing a --wait-nodes.

Please add --wait-nodes=1,2,5-6, which can be used for waiting until a single node stops e.g.

How to repeat:
.

Suggested fix:
+  { "wait-nodes", 'w', "Node ids to wait on, e.g. '1,2-4'",
[29 Mar 2010 12:06] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/104551

3485 Jorgen Austvik	2010-03-29
      unit tests for bug#52323
[30 Mar 2010 15:00] Jon Stephens
Doesn't look like the bug was actually fixed...?

Also, you shouldn't change assignee for Documenting status. :)
[31 Mar 2010 7:23] Jørgen Austvik
For me it looks like this feature request is fixed??

6.3:

[ja155679@khepri02:mysql-test] ../bin/ndb_waiter --help
MySQL distrib mysql-5.1.44 ndb-6.3.33-GA-debug, for pc-solaris2.11 (i386)
...
  -w, --wait-nodes=name
                      Node ids to wait on, e.g. '1,2-4'
..

7.1:

[ja155679@khepri02:5.1-telco-7.1] grep wait-nodes storage/ndb/tools/waiter.cpp
  { "wait-nodes", 'w', "Node ids to wait on, e.g. '1,2-4'",
[ja155679@khepri02:5.1-telco-7.1] bzr status storage/ndb/tools/waiter.cpp
[ja155679@khepri02:5.1-telco-7.1]
[31 Mar 2010 8:12] Jon Stephens
What I am waiting to see is a push that actually incorporates the change (not just in tests) along with a message from pushbuild stating what version(s) the change went into. If this isnät going to happen for this bug, could you add this info? Thanks!
[31 Mar 2010 8:31] Jørgen Austvik
Hmm, I don't know why it found my commit message, but not the push. It was pushed straight after the commit.

To the best of my knowledge, this are the versions:
6.3.34
7.0.14
7.1.4
[31 Mar 2010 8:35] Jørgen Austvik
Sorry, 7.0.15
[31 Mar 2010 11:46] Jon Stephens
Documented feature addition in the NDB-6.3.34/7.0.15/7.1.4 changelogs as well as the ndb_waiter program description.

Closed.