| Bug #52321 | mtr test suite paths need to be updated | ||
|---|---|---|---|
| Submitted: | 24 Mar 2010 3:03 | Modified: | 14 Oct 2010 14:36 |
| Reporter: | Hery Ramilison | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | Tools: MTR / mysql-test-run | Severity: | S3 (Non-critical) |
| Version: | 5.1.45 | OS: | Linux |
| Assigned to: | Bjørn Munch | CPU Architecture: | Any |
| Tags: | mtr | ||
[24 Mar 2010 6:26]
Sveta Smirnova
Thank you for the report. Verified as described.
[24 Mar 2010 12:09]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/104195 2907 Bjorn Munch 2010-03-24 Bug #52321 mtr test suite paths need to be updated Use $suitedir instead of $basedir to find suites Add 'testdir' to ConfigFactory
[15 Jun 2010 9:17]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/111103 2912 Bjorn Munch 2010-06-15 Bug #52321 mtr test suite paths need to be updated Use $suitedir instead of $basedir to find suites Add 'testdir' to ConfigFactory
[15 Jun 2010 11:09]
Bjørn Munch
Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr
[16 Aug 2010 6:30]
Bugs System
Pushed into mysql-trunk 5.6.1-m4 (revid:alik@sun.com-20100816062701-qo9dpnk5tkt1pksb) (version source revid:alik@sun.com-20100816062603-xc16eftmv7rmktyq) (merge vers: 5.6.1-m4) (pib:20)
[16 Aug 2010 6:38]
Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100816062819-bluwgdq8q4xysmlg) (version source revid:alik@sun.com-20100816062612-enatdwnv809iw3s9) (pib:20)
[16 Aug 2010 17:02]
Paul DuBois
Test suite changes. No changelog entry needed.
[28 Sep 2010 8:47]
Bugs System
Pushed into mysql-5.1 5.1.52 (revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (version source revid:sunanda.menon@sun.com-20100928083322-wangbv97uobu7g66) (merge vers: 5.1.52) (pib:21)
[14 Oct 2010 8:34]
Bugs System
Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (version source revid:martin.skold@mysql.com-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)
[14 Oct 2010 8:49]
Bugs System
Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (version source revid:martin.skold@mysql.com-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)
[14 Oct 2010 9:03]
Bugs System
Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (version source revid:martin.skold@mysql.com-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)
[14 Oct 2010 14:36]
Jon Stephens
Set back to Closed state; see above.
Description: The mtr test suite paths need to be updated. The tests fails looking for the script on an installed system. It appears that they have only been run from the source files and expect corresponding paths. > Logging: ./mtr > 100318 6:36:01 [Note] Plugin 'FEDERATED' is disabled. > MySQL Version 5.1.45 > Checking supported features... > - skipping ndbcluster, mysqld not compiled with ndbcluster > - SSL connections supported > Collecting tests... > ** ERROR: Could not find 'binlog' in '/usr/mysql-test/suite/binlog' or '/usr/mysql-test/binlog' > at lib/mtr_cases.pm line 269 How to repeat: rpm -ivh MySQL-server-community-5.1.45-1.rhel5.i386.rpm rpm -ivh MySQL-client-community-5.1.45-1.rhel5.i386.rpm rpm -ivh MySQL-test-community-5.1.45-1.rhel5.i386.rpm cd /usr/share/mysql-test ./mtr Suggested fix: [mysql-test]# diff -u lib/mtr_cases.pm{~,} --- lib/mtr_cases.pm~ 2010-03-02 02:09:05.000000000 +0100 +++ lib/mtr_cases.pm 2010-03-18 23:32:24.000000000 +0100 @@ -266,11 +266,11 @@ } else { - $suitedir= my_find_dir($::basedir, - ["mysql-test/suite", - "mysql-test", + $suitedir= my_find_dir($suitedir, + ["suite", + ".", # Look in storage engine specific suite dirs - "storage/*/mysql-test-suites" + "../storage/*/mysql-test-suites" ], [$suite]); } [mysql-test]# diff -u /users/jramilison/mtr-testing/tmp/usr/share/mysql-test/lib/My/ConfigFactory.pm lib/My/ConfigFactory.pm --- /users/jramilison/mtr-testing/tmp/usr/share/mysql-test/lib/My/ConfigFactory.pm 2010-03-02 02:09:05.000000000 +0100 +++ lib/My/ConfigFactory.pm 2010-03-22 14:28:17.000000000 +0100 @@ -23,7 +23,7 @@ my @share_locations= ("share/mysql", "sql/share", "share"); -sub get_basedir { +sub get_basedir { my ($self, $group)= @_; my $basedir= $group->if_exist('basedir') || $self->{ARGS}->{basedir}; @@ -31,6 +31,14 @@ } +sub get_testdir { + my ($self, $group)= @_; + my $testdir= $group->if_exist('testdir') || + $self->{ARGS}->{testdir}; + return $testdir; +} + + sub fix_charset_dir { my ($self, $config, $group_name, $group)= @_; return my_find_dir($self->get_basedir($group), @@ -142,8 +150,8 @@ sub fix_std_data { my ($self, $config, $group_name, $group)= @_; - my $basedir= $self->get_basedir($group); - return "$basedir/mysql-test/std_data"; + my $testdir= $self->get_testdir($group); + return "$testdir/std_data"; } sub ssl_supported {