Bug #52214 Misleading error msg when test fails before having produced any query output

• Submitted: 19 Mar 2010 11:32
• Modified: 14 Oct 2010 14:26
• Reporter: Bjørn Munch
• Status: Closed
• Category: Tools: MTR / mysql-test-run
• Severity: S3 (Non-critical)
• Version: 5.1+
• OS: Any
• Assigned to: Bjørn Munch
• CPU Architecture: Any

[19 Mar 2010 11:32] Bjørn Munch

Description:
If a test fails very early it may produce an error message like this, in addition to the test failure:

Failed to read from '/home/bm136801/my/memvar-51/mysql-test/var/log/foo.log', errno: 22

This is confusing.

How to repeat:
Run a test that fails before having produced any query outout, e.g. by putting some illegal statement first.

Suggested fix:
What happens is that mysqltest intends to output the last N lines of results from the temporary result file, but if the read returns 0 bytes, this is incorrectly treated as an error.

Fix: output the error message only if errno has been set, also fix to do proper error handling.

[19 Mar 2010 12:03] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/103817

2905 Bjorn Munch	2010-03-19
      Bug #52214 Misleading error msg when test fails before having produced any query output
      Print error message only if real error

[13 Apr 2010 10:42] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/105488

2909 Bjorn Munch	2010-04-13
      Bug #52214 Misleading error msg when test fails before having produced any query
      output
      Print error message only if real error

[13 Apr 2010 13:33] Bjørn Munch

(Rewiewer said OK on IRC)

Pushed to *-mtr branches

[16 Aug 2010 6:31] Bugs System

Pushed into mysql-trunk 5.6.1-m4 (revid:[e-mail]-20100816062701-qo9dpnk5tkt1pksb) (version source revid:[e-mail]-20100816062603-xc16eftmv7rmktyq) (merge vers: 5.6.1-m4) (pib:20)

[16 Aug 2010 6:41] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100816062819-bluwgdq8q4xysmlg) (version source revid:[e-mail]-20100816062612-enatdwnv809iw3s9) (pib:20)

[16 Aug 2010 17:02] Paul DuBois

Test suite changes. No changelog entry needed.

[28 Sep 2010 8:49] Bugs System

Pushed into mysql-5.1 5.1.52 (revid:[e-mail]-20100928083322-wangbv97uobu7g66) (version source revid:[e-mail]-20100928083322-wangbv97uobu7g66) (merge vers: 5.1.52) (pib:21)

[14 Oct 2010 8:39] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (version source revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (merge vers: 5.1.51-ndb-7.0.20) (pib:21)

[14 Oct 2010 8:54] Bugs System

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (version source revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (merge vers: 5.1.51-ndb-6.3.39) (pib:21)

[14 Oct 2010 9:12] Bugs System

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (version source revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (merge vers: 5.1.51-ndb-6.2.19) (pib:21)

[14 Oct 2010 14:26] Jon Stephens

Closed per comments above.