Bug #52107 Comment in sql/net_serv.cc still makes "GPL protocol" claim

• Submitted: 16 Mar 2010 18:19
• Modified: 14 Oct 2010 14:24
• Reporter: Jim Winstead
• Status: Closed
• Category: MySQL Server: General
• Severity: S3 (Non-critical)
• Version: 5.1
• OS: Any
• Assigned to: Kristofer Pettersson
• CPU Architecture: Any
• Tags: GPL, protocol

[16 Mar 2010 18:19] Jim Winstead

Description:
A comment in sql/net_serv.cc says:

  This file is the net layer API for the MySQL client/server protocol,
  which is a tightly coupled, proprietary protocol owned by MySQL AB.
  @note
  Any re-implementations of this protocol must also be under GPL
  unless one has got an license from MySQL AB stating otherwise.

To the best of my knowledge, we have stopped making this claim elsewhere, such as in the protocol documentation at http://forge.mysql.com/w/index.php?title=MySQL_Internals_ClientServer_Protocol

(This was noted by Mark Callaghan here: http://mysqlha.blogspot.com/2010/03/can-protocol-be-gpl.html)

How to repeat:
Read the source.

Suggested fix:
Remove this extra bit of licensing commentary.

[16 Mar 2010 19:39] Jonas Oreland

seems to have been added 2003-06-04 15:28:51
in changeset revid:[e-mail]-20030604152851-64586

[16 Mar 2010 23:58] Brian Aker

Didn't Monty claim in comments on Slashdot that he has never said that the protocol was GPL?

[17 Mar 2010 4:35] Valeriy Kravchuk

Verified by code review.

[17 Mar 2010 12:06] Konstantin Osipov

Brian, 
yes he did.
Yet it's in his patch.

[18 May 2010 10:01] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/108498

3368 Kristofer Pettersson	2010-05-18
      Bug#52107 Comment in sql/net_serv.cc still makes "GPL protocol" claim
      
      Removed misleading comments.

[2 Jun 2010 8:48] Bugs System

Pushed into 5.1.48 (revid:[e-mail]-20100602084411-2yu607bslbmgufl3) (version source revid:[e-mail]-20100526151302-tsfjgf2z597e494r) (merge vers: 5.1.47) (pib:16)

[17 Jun 2010 6:12] Bugs System

Pushed into 5.5.5-m3 (revid:[e-mail]-20100615145247-8bj0vmuqlotbqsn9) (version source revid:[e-mail]-20100527104212-cloj25taqgmyp2of) (merge vers: 5.5.5-m3) (pib:16)

[17 Jun 2010 6:15] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100615150216-cubqoyn1fj9b6a2p) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (pib:16)

[18 Jun 2010 1:51] Paul DuBois

Cosmetic change. No changelog entry needed.

[14 Oct 2010 8:32] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 8:47] Bugs System

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 9:02] Bugs System

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 14:24] Jon Stephens

No changelog entry required -- see above. Set back to Closed state.