Bug #51896 make test-bt terminates too early
Submitted: 9 Mar 2010 23:27 Modified: 4 Aug 2010 22:43
Reporter: Vladislav Vaintroub Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:next-mr-bugfixing. 6.0-bugfixing OS:Any
Assigned to: Vladislav Vaintroub CPU Architecture:Any

[9 Mar 2010 23:27] Vladislav Vaintroub
Description:
make test-bt target would terminate if mysql-test-run returns error in cmake builds.
This was not the case in autotools make, where errors were silenced with leading dash in makefiles, on purpose to increase coverage even if error occurs.

How to repeat:
Look at the source (mysql-test/CMakeLists.txt)
[9 Mar 2010 23:43] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/102798

3119 Vladislav Vaintroub	2010-03-09
      Bug#51896  :make test-bt terminates too early with cmake.
      
      Reason for it is test-bt is a custom target executing  bunch of 
      COMMAND(perl mysql-test-run.pl ...). If one of the COMMAND fails, the
      whole build termintates. 
      
      The fix is to write a cmake script run_collection that takes a corresponding "collections" file and executes it line by line with EXECUTE_PROCESS and ignore all EXECUTE_PROCESS errors.
[10 Mar 2010 1:17] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/102806

3119 Vladislav Vaintroub	2010-03-09
      Bug#51896  :make test-bt terminates too early with cmake.
      
      Reason for it is test-bt is a custom target executing  bunch of 
      COMMAND(perl mysql-test-run.pl ...). If one of the COMMAND fails, the
      whole build termintates. 
      
      The fix is to write a cmake script run_collection that takes a corresponding "collections" file and executes it line by line with EXECUTE_PROCESS and ignore all EXECUTE_PROCESS errors.
[10 Mar 2010 12:50] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/102878

3119 Vladislav Vaintroub	2010-03-09
      Bug#51896  :make test-bt terminates too early with cmake.
      
      Reason for it is test-bt is a custom target executing  bunch of 
      COMMAND(perl mysql-test-run.pl ...). If one of the COMMAND fails, the
      whole build termintates. 
      
      The fix is to write a cmake script run_collection that takes a
      corresponding "collections" file and executes it line by line with
      EXECUTE_PROCESS and ignore all EXECUTE_PROCESS errors.
      
      - Also, added or fixed copyright notices.
[10 Mar 2010 15:23] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/102897

3119 Vladislav Vaintroub	2010-03-10
      Bug#51896  :make test-bt terminates too early with cmake.
            
      Reason for it is test-bt is a custom target executing  bunch of 
      COMMAND(perl mysql-test-run.pl ...). If one of the COMMAND fails, the
      whole build termintates. 
            
      The fix is to write a cmake script run_collection that takes a
      corresponding "collections" file and executes it line by line with
      EXECUTE_PROCESS and ignore all EXECUTE_PROCESS errors.
            
      - Also, added or fixed copyright notices.
[24 Mar 2010 8:15] Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20100324081249-yfwol7qtcek6dh7w) (version source revid:alik@sun.com-20100324081113-kc7x1iytnplww91u) (merge vers: 6.0.14-alpha) (pib:16)
[25 Mar 2010 15:31] MC Brown
A note has been added to the 6.0.14 changelog: 

Running the <literal>make test-bt</literal> target would fail                                                                                      
  in the event of a single test run failure, instead of running all                                                                                        
  the tests in the suite.
[4 Aug 2010 8:09] Bugs System
Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804080001-bny5271e65xo34ig) (version source revid:alik@sun.com-20100324081105-y72rautcea375zxm) (merge vers: 5.6.99-m4) (pib:18)
[4 Aug 2010 8:24] Bugs System
Pushed into mysql-trunk 5.6.1-m4 (revid:alik@ibmvm-20100804081533-c1d3rbipo9e8rt1s) (version source revid:alik@sun.com-20100324081105-y72rautcea375zxm) (merge vers: 5.6.99-m4) (pib:18)
[4 Aug 2010 22:43] Paul Dubois
Bug does not appear in any released 5.6.x version.