Bug #51828 mysql_upgrade fails to build on Windows: compiler limit: string exceeds 65535 B
Submitted: 8 Mar 2010 11:47 Modified: 17 Mar 2010 10:55
Reporter: John Embretsen Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S1 (Critical)
Version:6.0-codebase-bugfixing OS:Windows
Assigned to: Marc ALFF CPU Architecture:Any

[8 Mar 2010 11:47] John Embretsen
Description:
Compilation of mysql_upgrade fails on Windows:

(...)
38>------ Build started: Project: mysql_upgrade, Configuration: Debug Win32 ------
38>Compiling...
38>mysql_upgrade.c
38>G:\johnemb\bzr\mysql-6.0-codebase-bugfixing\jbuild2\include\../scripts/mysql_fix_privilege_tables_sql.c(1252) : fatal
 error C1091: compiler limit: string exceeds 65535 bytes in length
38>Build log was saved at "file://g:\johnemb\bzr\mysql-6.0-codebase-bugfixing\jbuild2\client\mysql_upgrade.dir\Debug\Bui
ldLog.htm"
38>mysql_upgrade - 1 error(s), 0 warning(s)

This, in turn, results in MTR not being able to start the server for running tests:

TEST                                      RESULT   TIME (ms)
------------------------------------------------------------

worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009
worker[1] mysql-test-run: *** ERROR: Could not find G:/johnemb/bzr/mysql-6.0-codebase-bugfixing/jbuild2/client/Debug//my
sql_upgrade

This again results in no tests being run on Windows platforms in mysql-6.0-codebase-bugfixing branch.

Seems like the issue was introduced by push/merge revision marc.alff@oracle.com-20100307185405-y64369sty42wm5ha on 2010-03-07.

How to repeat:
mkdir mybuild
cd mybuild
cmake .. -G"Visual Studio 9 2008"
devenv mysql.sln /build relwithdebinfo

Check output and/or try to run MTR:

cd mysql-test
perl mysql-test-run.pl 1st
[8 Mar 2010 11:55] John Embretsen
Marc, please check this out, seems like your push caused this.

Verified in Pushbuild (mysql-6.0-codebase-bugfixing).
Search for "mysql_upgrade" in build logs and/or check test results.
[9 Mar 2010 1:02] Marc ALFF
The fix for this bug is not local,
see WL#5291
[10 Mar 2010 5:39] Marc ALFF
See related Bug#45194, which exposed the build limitation.
[10 Mar 2010 13:37] Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20100310133305-0jdlngbtrkoqzckh) (version source revid:alik@sun.com-20100310132404-uqarl0o0vlra2kjx) (merge vers: 6.0.14-alpha) (pib:16)
[17 Mar 2010 10:44] Marc ALFF
Status update on this bug:

- the build failure observed in 6.0 was triggered because the limit of 65535 was reached in 6.0 only.
For 5.5, the scripts are smaller, so that this bug was not triggered on 5.5.

- the last script change that triggered the bug the fix for bug#45194 mysql_upgrade deletes existing data in performance_schema database/schema

To resolve the situation in 6.0:
- the fix for bug#45191 was rolled back, so that 6.0 builds again for windows

As a result, bug#45194 is only resolved for 5.5, but in "need merge" status for 6.0

Since the build failure itself is resolved, bug#51828 is resolved.

What needs to be implemented to resolve the situation in the long term is to implement WL#5291
[17 Mar 2010 10:55] Marc ALFF
No patch queued (bug#45194 rolled back instead), and nothing to document,
so changing to closed status directly.