Bug #51607 Automake distcheck target broken

• Submitted: 1 Mar 2010 15:42
• Modified: 28 Apr 2010 2:06
• Reporter: Marc ALFF
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S1 (Critical)
• Version: mysql-next-mr, 5.5.99-m3
• OS: Any
• Assigned to: Vladislav Vaintroub
• CPU Architecture: Any

[1 Mar 2010 15:42] Marc ALFF

Description:
With the recent CMake related changes,
the automake build is broken for distcheck.

Seen in mysql-next-mr-bugfixing (did not try mysql-next-mr)

malff@linux-su11:mysql-next-mr-bugfixing> env | grep CMAKE
HAVE_CMAKE=no

malff@linux-su11:mysql-next-mr-bugfixing> ./BUILD/compile-pentium64-debug-max
builds properly

malff@linux-su11:mysql-next-mr-bugfixing> make distcheck
fails with:

sh: ./configure.am: No such file or directory
make: *** [distcheck] Error 127

How to repeat:
make distcheck

Suggested fix:
Probably need to add configure.am to EXTRA_DIST in Makefile.am,
the same way configure.cmake was added.

[2 Mar 2010 8:22] Sveta Smirnova

Thank you for the report.

With latest update of mysql-next-mr and mysql-next-mr-bugfixing I get:

$make distcheck
make: *** No rule to make target `distcheck'.  Stop.

Can it be considered same issue or something wrong with either my or your setup?

[2 Mar 2010 13:28] Marc ALFF

I could reproduce it in mysql-next mr.

Make sure that the environment variable HAVE_CMAKE is 'no',
start from a clean tree, and try, verbatim:
- ./BUILD/compile-pentium64-debug-max
- make distcheck

[3 Mar 2010 9:20] Sveta Smirnova

Thank you for the feedback.

Verified as described.

[3 Mar 2010 9:29] Valeriy Kravchuk

With recent mysql-next-mr on Ubuntu I've got:

sh: Can't open ./configure.am
make: *** [distcheck] Error 2

[10 Mar 2010 13:11] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/102882

3124 Vladislav Vaintroub	2010-03-09
      Bug#51607: Automake distcheck target broken.
      
      Reason for the error was that ./configure wrapper script was  not 
      safe for VPATH builds used by "make distcheck", specifically it expected configure.am to be in the current directory.
      
      Fix changes configure wrapper to resolve script names relative 
      to configure script path.
      
      Also, use $top_srcdir/configure.am instead of configure.am in dist-hook to be more VPATH friendly.

[16 Mar 2010 9:06] Marc ALFF

Patch approved.

distcheck now fails later when installing the language error message files,
but this is a different problem.

This issue with configure.am is now resolved.

[19 Apr 2010 11:16] Vladislav Vaintroub

Appears to be already pushed into {trunk,next-mr,6.0-codebase}-bugfixings

[27 Apr 2010 9:47] Bugs System

Pushed into 6.0.14-alpha (revid:[e-mail]-20100427094135-5s49ecp3ckson6e2) (version source revid:[e-mail]-20100427093843-uekr85qkd7orx12t) (merge vers: 6.0.14-alpha) (pib:16)

[27 Apr 2010 9:49] Bugs System

Pushed into 5.5.5-m3 (revid:[e-mail]-20100427093804-a2k3rrjpwu5jegu8) (version source revid:[e-mail]-20100427093804-a2k3rrjpwu5jegu8) (merge vers: 5.5.5-m3) (pib:16)

[27 Apr 2010 9:53] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100427094036-38frbg3famdlvjup) (version source revid:[e-mail]-20100427093825-92wc8b22d4yg34ju) (pib:16)

[28 Apr 2010 2:06] Paul DuBois

Not in any released version. No changelog entry needed.