| Bug #51488 | missing features and change behavior in cmake runs compared to autotools runs | ||
|---|---|---|---|
| Submitted: | 25 Feb 2010 8:18 | Modified: | 13 Mar 2010 23:42 |
| Reporter: | Vladislav Vaintroub | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Compiling | Severity: | S3 (Non-critical) |
| Version: | 5.5.99-m3 | OS: | Any (Unix) |
| Assigned to: | Vladislav Vaintroub | CPU Architecture: | Any |
[25 Feb 2010 8:18]
Vladislav Vaintroub
[27 Feb 2010 17:12]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/101763 2987 Vladislav Vaintroub 2010-02-27 Bug #51488 :missing features and change behavior in cmake runs compared to autotools runs - Add test-ps and test-nr targets - Fix recognition of --with-debug=full and configure wrapper - Remove CMakeCache.txt in configure wrapper, to match the original - Fix recognition of max-no-ndb - Fix broken dependencies of mysql_fix_privilege_table.sql from mysql_system_tables.sql and mysql_system_tables_fix.sql - Add "distclean target" that informs user about appropriate bzr command @ cmake/configure.pl - Recognize --with-debug=full, map to WITH_DEBUG_FULL - remove CMakeCache.txt, so the configuration is not more sticky (to match the original configure behavior) @ cmake/plugin.cmake - Recognize WITH_MAX_NO_NDB, this fixes missing storage engines after BUILD/*max-no-ndb scripts @ mysql-test/CMakeLists.txt -Add test-ps and test-ns targets, as in autotools make @ scripts/CMakeLists.txt - Fix broken dependency when producing mysql_fix_privilege_tables.sql, reported by Davi We now concatenate 2 scripts in custom command that has dependency on both scripts rather than concatenating them at cmake time. @ sql/CMakeLists.txt Address frequently asked question "where is distclean" by implementing distclean that does nothing but points to appropriate bzr command. It is better not to call "bzr clean-tree" automatically, without user consent. it could clean new files that were meant to be added.
[1 Mar 2010 13:15]
John Embretsen
My review comments sent per E-mail, see http://lists.mysql.com/commits/101859
[2 Mar 2010 14:37]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/102061 3100 Vladislav Vaintroub 2010-03-02 Bug #51488 :missing features and change behavior in cmake runs compared to autotools runs - Add test-ps and test-nr targets - Fix recognition of --with-debug=full and configure wrapper - Remove CMakeCache.txt in configure wrapper, to match the original - Fix recognition of max-no-ndb - Fix broken dependencies of mysql_fix_privilege_table.sql from mysql_system_tables.sql and mysql_system_tables_fix.sql - Add "distclean target" that informs user about appropriate bzr command @ cmake/configure.pl - Recognize --with-debug=full, map to WITH_DEBUG_FULL - remove CMakeCache.txt, so the configuration is no more sticky (to match the original configure behavior) @ cmake/plugin.cmake - Recognize WITH_MAX_NO_NDB, this fixes missing storage engines after BUILD/*max-no-ndb scripts @ mysql-test/CMakeLists.txt -Add test-{p,n}{s,r} targets, as in autotools make @ scripts/CMakeLists.txt - Fix broken dependency when producing mysql_fix_privilege_tables.sql, reported by Davi. We now concatenate 2 scripts in custom command that has dependency on both scripts rather than concatenating them at cmake time. @ sql/CMakeLists.txt Address frequently asked question "where is distclean" by implementing distclean target that does nothing except pointing to appropriate bzr command. It is better not to call "bzr clean-tree" automatically, without user consent. It could clean new files that were meant to be added.
[2 Mar 2010 20:54]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/102115 3100 Vladislav Vaintroub 2010-03-02 Bug #51488 :missing features and change behavior in cmake runs compared to autotools runs - Add test-ps and test-nr targets - Fix recognition of --with-debug=full and configure wrapper - Remove CMakeCache.txt in configure wrapper, to match the original - Fix recognition of max-no-ndb - Fix broken dependencies of mysql_fix_privilege_table.sql from mysql_system_tables.sql and mysql_system_tables_fix.sql - Add "distclean target" that informs user about appropriate bzr command @ cmake/configure.pl - Recognize --with-debug=full, map to WITH_DEBUG_FULL - remove CMakeCache.txt, so the configuration is no more sticky (to match the original configure behavior) @ cmake/plugin.cmake - Recognize WITH_MAX_NO_NDB, this fixes missing storage engines after BUILD/*max-no-ndb scripts @ mysql-test/CMakeLists.txt -Add test-{p,n}{s,r} targets, as in autotools make @ scripts/CMakeLists.txt - Fix broken dependency when producing mysql_fix_privilege_tables.sql, reported by Davi. We now concatenate 2 scripts in custom command that has dependency on both scripts rather than concatenating them at cmake time. @ sql/CMakeLists.txt Address frequently asked question "where is distclean" by implementing distclean target that does nothing except pointing to appropriate bzr command. It is better not to call "bzr clean-tree" automatically, without user consent. It could clean new files that were meant to be added.
[3 Mar 2010 10:16]
Tor Didriksen
I think 'test-bt' is sufficient, so let's drop the new 'test-xx' targets.
[3 Mar 2010 11:30]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/102172 3100 Vladislav Vaintroub 2010-03-03 Bug #51488 :missing features and change behavior in cmake runs compared to autotools runs - Fix recognition of --with-debug=full in configure wrapper - Remove CMakeCache.txt in configure wrapper, to match the original - Fix recognition of max-no-ndb - Fix broken dependencies of mysql_fix_privilege_table.sql from mysql_system_tables.sql and mysql_system_tables_fix.sql - Add "distclean target" that informs user about appropriate bzr command @ cmake/configure.pl - Recognize --with-debug=full, map to WITH_DEBUG_FULL - remove CMakeCache.txt, so the configuration is no more sticky (to match the original configure behavior) @ cmake/plugin.cmake - Recognize WITH_MAX_NO_NDB, this fixes missing storage engines after BUILD/*max-no-ndb scripts @ mysql-test/CMakeLists.txt test-force uses the same macros (MTR_FORCE) as test-bt* now @ scripts/CMakeLists.txt - Fix broken dependency when producing mysql_fix_privilege_tables.sql, reported by Davi. We now concatenate 2 scripts in custom command that has dependency on both scripts rather than concatenating them at cmake time. @ sql/CMakeLists.txt Address frequently asked question "where is distclean" by implementing distclean target that does nothing except pointing to appropriate bzr command. It is better not to call "bzr clean-tree" automatically, without user consent. It could clean new files that were meant to be added.
[6 Mar 2010 10:29]
Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20100306102742-yw9zzgw9ac5r65m5) (version source revid:bar@mysql.com-20100305074327-h09o5lw290s04lcf) (merge vers: 6.0.14-alpha) (pib:16)
[6 Mar 2010 10:31]
Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100306102638-qna09hbjb5gm940h) (version source revid:alik@sun.com-20100304153932-9hajxhhyanqbckmu) (pib:16)
[6 Mar 2010 11:04]
Bugs System
Pushed into 5.5.3-m3 (revid:alik@sun.com-20100306103849-hha31z2enhh7jwt3) (version source revid:alik@sun.com-20100304153932-9hajxhhyanqbckmu) (merge vers: 5.5.99-m3) (pib:16)
[13 Mar 2010 23:42]
Paul DuBois
Not in any released version. No changelog entry needed.
