Bug #50279 MySQL Backup: Result differences in backup_bml_not_falcon
Submitted: 12 Jan 2010 15:03 Modified: 3 Sep 2010 8:40
Reporter: Ingo Strüwing Email Updates:
Status: Unsupported Impact on me:
None 
Category:MySQL Server: Backup Severity:S3 (Non-critical)
Version:5.6.0-beta Backup OS:Any
Assigned to: Ingo Strüwing CPU Architecture:Any

[12 Jan 2010 15:03] Ingo Strüwing
Description:
backup.backup_bml_not_falcon             [ fail ]
        Test ended at 2010-01-12 15:22:03

CURRENT_TEST: backup.backup_bml_not_falcon
--- /home2/mydev/bzrroot/mysql-5.6-backup-backport-ms09-2/mysql-test/suite/backup/r/backup_bml_not_falcon.result        2
+++ /home2/mydev/bzrroot/mysql-5.6-backup-backport-ms09-2/mysql-test/suite/backup/r/backup_bml_not_falcon.reject        2
@@ -39,7 +39,7 @@
 (8, 'INDEX',     'i1 ON t2', '(b)');
 DROP PROCEDURE IF EXISTS test.check_results\\
 Warnings:
-Note   1305    PROCEDURE test.check_results does not exist
+Note   1305    PROCEDURE check_results does not exist
 CREATE PROCEDURE test.check_results()
 BEGIN
 # show databases
@@ -1899,6 +1899,7 @@
 RETURN 1       latin1  latin1_swedish_ci       latin1_swedish_ci
 Procedure      sql_mode        Create Procedure        character_set_client    collation_connection    Database Collatio
 p1             CREATE DEFINER=`root`@`localhost` PROCEDURE `p1`()
+    COMMENT 'testing alter'
 SET @foo=1     latin1  latin1_swedish_ci       latin1_swedish_ci
 event_name
 e2

mysqltest: Result content mismatch

How to repeat:
Apply newest fixes to mysql-backup-backport. Run backup_bml_not_falcon.
[12 Jan 2010 15:06] Ingo Strüwing
The first diff results fromthe fact that the fix for Bug#31767 (DROP FUNCTION name resolution) has not yet been back ported to 5.6. Until this happens, the result file can be adapted to the output.
[12 Jan 2010 18:59] Ingo Strüwing
After a lot of digging, I conclude that the 5.6 behavior is correct.
The backup image file, which is created by the preceeding test,
contains the COMMENT characteristic of test.p1().
This is correct because the ALTER PROCEDURE p1 COMMENT 'testing alter'
is started before the BACKUP and finished before BACKUP retrieves the
metadata.

So the problem is in 6.0 and has not been detected when creating
the result file in the first place. See
Bug#50287 (MySQL Backup: missed altered procedure in backup_bml_not_falcon.test)
[12 Jan 2010 19:17] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/96664

3056 Ingo Struewing	2010-01-12
      Bug#50279 - MySQL Backup: Result differences in backup_bml_not_falcon
      
      Two differences in the test result have been analyzed as acceptable.
      
      Also improved DBUG tracability.
     @ mysql-test/suite/backup/include/bml_test.inc
        Bug#50279 - MySQL Backup: Result differences in backup_bml_not_falcon
        Improved DBUG tracability.
     @ mysql-test/suite/backup/r/backup_bml_not_falcon.result
        Bug#50279 - MySQL Backup: Result differences in backup_bml_not_falcon
        Updated test result.
     @ mysql-test/suite/backup/t/backup_bml_not_falcon.test
        Bug#50279 - MySQL Backup: Result differences in backup_bml_not_falcon
        Improved DBUG tracability.
[12 Jan 2010 19:24] Chuck Bell
Approved to push.
[12 Jan 2010 23:03] Ingo Strüwing
Queued to mysql-backup-backport.
[3 Sep 2010 8:40] Ingo Strüwing
The feature will not be implemented.