| Bug #50270 | MySQL Backup: sync point before_execute_sql_command commented out | ||
|---|---|---|---|
| Submitted: | 12 Jan 2010 11:52 | Modified: | 3 Sep 2010 8:40 |
| Reporter: | Ingo Strüwing | Email Updates: | |
| Status: | Unsupported | Impact on me: | |
| Category: | MySQL Server: Backup | Severity: | S3 (Non-critical) |
| Version: | 5.6.0-beta | OS: | Any |
| Assigned to: | Ingo Strüwing | CPU Architecture: | Any |
[12 Jan 2010 12:08]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/96603 3054 Ingo Struewing 2010-01-12 Bug#50270 - MySQL Backup: sync point before_execute_sql_command commented out The sync point before_execute_sql_command had been commented out. The tests backup_bml_block and backup_bml_not_falcon failed. Removed the comment signs. This makes backup_bml_block pass and backup_bml_not_falcon fail with result differences. Most of them will be fixed by back porting the fix for Bug 47281 (BML may not block all it should). @ sql/sql_parse.cc Bug#50270 - MySQL Backup: sync point before_execute_sql_command commented out Re-enabled sync point before_execute_sql_command. Removed trailing space.
[12 Jan 2010 12:37]
Rafal Somla
Good to push.
[12 Jan 2010 23:03]
Ingo Strüwing
Queued to mysql-backup-backport.
[3 Sep 2010 8:40]
Ingo Strüwing
The feature will not be implemented.
Description: backup_bml_block and backup_bml_not_falcon fail due to missing sync point before_execute_sql_command. Code analysis shows: #ifndef DBUG_OFF // if (lex->sql_command != SQLCOM_SET_OPTION) // DEBUG_SYNC(thd,"before_execute_sql_command"); #endif How to repeat: Run test and/or read code. Suggested fix: Remove the comment signs: #ifndef DBUG_OFF if (lex->sql_command != SQLCOM_SET_OPTION) DEBUG_SYNC(thd,"before_execute_sql_command"); #endif (and, btw, use the correct macro: #if defined(ENABLED_DEBUG_SYNC))