Bug #49968 Properly define HAVE_ERRNO_AS_DEFINE for the appropriate OpenBSD releases.

• Submitted: 29 Dec 2009 1:09
• Modified: 14 Oct 2010 14:03
• Reporter: Brad Smith
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S2 (Serious)
• Version: 5.1.41, 4.1, 5.0, 5.1, next-mr
• OS: Other (OpenBSD)
• Assigned to: Jonathan Perkin
• CPU Architecture: Any
• Tags: Contribution

[29 Dec 2009 1:09] Brad Smith

Description:
As of OpenBSD 3.6 (5.5 years old now) errno is now a define. This has been in the OpenBSD port/package for the whole time and I'm finally making an effort to push this upstream.

How to repeat:
Compile MySQL on OpenBSD.

Suggested fix:
The attached patch. The patch is against 5.1 although the issue applies to all previous MySQL releases (5.0) as well as newer releases (5.4, 6).

[29 Dec 2009 1:11] Brad Smith

patch

Attachment: patch-include_my_global_h (application/octet-stream, text), 318 bytes.

[29 Dec 2009 9:34] Sveta Smirnova

Thank you for the report.

Verified as described.

[15 Jan 2010 22:13] Brad Smith

Can you please provide an ETA as to when this fix will be commited to the appropriate source repo branches?

[28 Mar 2010 15:27] Brad Smith

It has been 3 months and there have been 4x 5.1.x releases since then. What is taking so long for this fix to be commited?

[28 Mar 2010 19:02] Jonathan Perkin

Hi,

There are only so many hours in a day.  However, given the simpleness of the patch I'll look to integrate this tomorrow.

Regards.

[25 May 2010 13:29] Bugs System

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/109177

3397 Jonathan Perkin	2010-05-25
      bug#49968: Properly define HAVE_ERRNO_AS_DEFINE for the appropriate
      OpenBSD releases.
      
      Apply patch from Brad Smith, thanks!

[2 Jun 2010 8:50] Bugs System

Pushed into 5.1.48 (revid:[e-mail]-20100602084411-2yu607bslbmgufl3) (version source revid:[e-mail]-20100526151733-st1tsjoz6xkvb096) (merge vers: 5.1.47) (pib:16)

[17 Jun 2010 6:14] Bugs System

Pushed into 5.5.5-m3 (revid:[e-mail]-20100615145247-8bj0vmuqlotbqsn9) (version source revid:[e-mail]-20100527104212-cloj25taqgmyp2of) (merge vers: 5.5.5-m3) (pib:16)

[17 Jun 2010 6:17] Bugs System

Pushed into mysql-next-mr (revid:[e-mail]-20100615150216-cubqoyn1fj9b6a2p) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (pib:16)

[18 Jun 2010 0:07] Brad Smith

Looking good with 5.1.48 and I see the patch was also rolled into the other various branches for future releases. This bug report can be closed.

[29 Jun 2010 8:00] MC Brown

No user-visible changes; internal fix. No changelog entry required.

[14 Oct 2010 8:31] Bugs System

Pushed into mysql-5.1-telco-7.0 5.1.51-ndb-7.0.20 (revid:[e-mail]-20101014082627-jrmy9xbfbtrebw3c) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 8:47] Bugs System

Pushed into mysql-5.1-telco-6.3 5.1.51-ndb-6.3.39 (revid:[e-mail]-20101014083757-5qo48b86d69zjvzj) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 9:01] Bugs System

Pushed into mysql-5.1-telco-6.2 5.1.51-ndb-6.2.19 (revid:[e-mail]-20101014084420-y54ecj85j5we27oa) (version source revid:[e-mail]-20100513074652-0cvlhgkesgbb2bfh) (merge vers: 5.5.5-m3) (pib:21)

[14 Oct 2010 14:03] Jon Stephens

Set back to Closed state without further action. See previous comments.