MySQL Bugs: #49166: mtr --combination is broken after restrictions of combination names

Bug #49166	mtr --combination is broken after restrictions of combination names
Submitted:	27 Nov 2009 14:18	Modified:	17 Jun 2010 19:27
Reporter:	Bjørn Munch	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Tools: MTR / mysql-test-run	Severity:	S7 (Test Cases)
Version:	5.1+	OS:	Any
Assigned to:	Bjørn Munch	CPU Architecture:	Any

Description:
Bug #46625 added some "sanity check" of combination names, this works fine for those coming from the combination *files* or the innodb_plugin add-on, but it utterly breaks command line --combination because the "value" of the combinations is used as name, and this begins with --.

How to repeat:
./mtr --combination=--skip-innodb 1st

This results in

worker[1] mysql-test-run: *** ERROR: Combination '--skip-innodb' contains illegal characters

Suggested fix:
Allow also combinations that begin with "--"; those should in fact be allowed to contain anything, *including* spaces. We cannot dictate what is or is not allowed as options to mysqld.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/92859

2866 Bjorn Munch	2009-12-04
      Bug #49166 mtr --combination is broken after restrictions of combination names
      Combinations beginning with -- not allowed
      Allow them...

Since you reviewed Bug #46625, I figured you could take this small follow-up too. :-)

OK

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/95959

2866 Bjorn Munch	2010-01-05
      Bug #49166 mtr --combination is broken after restrictions of combination names
      Combinations beginning with -- not allowed
      Allow them...

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/95969

2869 Bjorn Munch	2010-01-05
      Bug #49166 mtr --combination is broken after restrictions of combination names
      Combinations beginning with -- not allowed
      Allow them...

Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr, 6.0-codebase-mtr

Pushed into 6.0.14-alpha (revid:alik@sun.com-20100220092844-jh07ayojyxn8uh9p) (version source revid:bjorn.munch@sun.com-20100106093632-yy2ts5rndk3cchvm) (merge vers: 6.0.14-alpha) (pib:16)

Pushed into 5.5.3-m2 (revid:alik@sun.com-20100220092622-wvhh1vfy5tjq4mhu) (version source revid:bjorn.munch@sun.com-20100105123522-kkpl64kzxbsuz674) (merge vers: 5.5.1-m2) (pib:16)

Pushed into mysql-next-mr (revid:alik@sun.com-20100220092730-paoo5t9gcajs5dq8) (version source revid:bjorn.munch@sun.com-20100106090111-s6smcs0si1ohiiu5) (pib:16)

Changes to test suite. No changelog entry needed.

Setting report to Need Merge pending push to 5.1.x, Celosia.

Pushed into 5.1.45 (revid:joro@sun.com-20100301083827-xnimmrjg6bh33o1o) (version source revid:azundris@mysql.com-20100222175719-viuh0f3gdsrkgv0r) (merge vers: 5.1.45) (pib:16)

No changelog entry needed.

Pushed into 5.1.47-ndb-7.0.16 (revid:martin.skold@mysql.com-20100617114014-bva0dy24yyd67697) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)

Pushed into 5.1.47-ndb-6.2.19 (revid:martin.skold@mysql.com-20100617115448-idrbic6gbki37h1c) (version source revid:martin.skold@mysql.com-20100609140708-52rvuyq4q500sxkq) (merge vers: 5.1.45-ndb-6.2.19) (pib:16)

Pushed into 5.1.47-ndb-6.3.35 (revid:martin.skold@mysql.com-20100617114611-61aqbb52j752y116) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)