| Bug #49165 | Remove unused/confusing code/comments in setup_conds() | ||
|---|---|---|---|
| Submitted: | 27 Nov 2009 14:07 | Modified: | 7 Mar 2010 1:30 |
| Reporter: | Tor Didriksen | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: General | Severity: | S3 (Non-critical) |
| Version: | 5.6, 6.0 | OS: | Any |
| Assigned to: | Tor Didriksen | CPU Architecture: | Any |
[27 Nov 2009 14:24]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/91926 2906 Tor Didriksen 2009-11-27 Bug#49165 Remove unused/confusing code/comments in setup_conds() @ sql/sql_base.cc Query_arena *arena and backup are both unused. Removing those, allows us to remove select_lex->conds_processed_with_permanent_arena @ sql/sql_lex.cc conds_processed_with_permanent_arena is unused @ sql/sql_lex.h conds_processed_with_permanent_arena was unused
[27 Nov 2009 14:25]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/91927 2906 Tor Didriksen 2009-11-27 Bug #49165 Remove unused/confusing code/comments in setup_conds() @ sql/sql_base.cc Query_arena *arena and backup are both unused. Removing those, allows us to remove select_lex->conds_processed_with_permanent_arena @ sql/sql_lex.cc conds_processed_with_permanent_arena is unused @ sql/sql_lex.h conds_processed_with_permanent_arena was unused
[27 Nov 2009 14:28]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/91928 2906 Tor Didriksen 2009-11-27 Bug #49165 Remove unused/confusing code/comments in setup_conds() @ sql/sql_base.cc Query_arena *arena and backup are both unused. Removing those, allows us to remove select_lex->conds_processed_with_permanent_arena @ sql/sql_lex.cc conds_processed_with_permanent_arena is unused @ sql/sql_lex.h conds_processed_with_permanent_arena was unused
[30 Nov 2009 7:01]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/92024 2908 Tor Didriksen 2009-11-27 Bug#49165 Remove unused/confusing code/comments in setup_conds() @ sql/sql_base.cc Query_arena *arena and backup are both unused. Removing those, allows us to remove select_lex->conds_processed_with_permanent_arena @ sql/sql_lex.cc conds_processed_with_permanent_arena is unused @ sql/sql_lex.h conds_processed_with_permanent_arena was unused
[1 Dec 2009 7:23]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/92215 2909 Tor Didriksen 2009-11-27 Bug#49165 Remove unused/confusing code/comments in setup_conds() @ sql/sql_base.cc Query_arena *arena and backup are both unused. Removing those, allows us to remove select_lex->conds_processed_with_permanent_arena @ sql/sql_lex.cc conds_processed_with_permanent_arena is unused @ sql/sql_lex.h conds_processed_with_permanent_arena was unused
[1 Dec 2009 11:17]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/92247 3743 Tor Didriksen 2009-12-01 [merge] Bug#49165 Remove unused/confusing code/comments in setup_conds()
[1 Dec 2009 11:20]
Tor Didriksen
Pushed to bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-6.0-codebase-bugfixing/ bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-next-mr-bugfixing
[11 Dec 2009 6:02]
Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20091211055901-yp18b3c7xuhl87rf) (version source revid:alik@sun.com-20091211055401-43rjwq7gjed6ds83) (merge vers: 6.0.14-alpha) (pib:13)
[11 Dec 2009 6:04]
Bugs System
Pushed into 5.6.0-beta (revid:alik@sun.com-20091211055628-ltr7fero363uev7r) (version source revid:alik@sun.com-20091211055453-717czhtezc74u8db) (merge vers: 5.6.0-beta) (pib:13)
[16 Dec 2009 2:32]
Paul DuBois
No user impact. No changelog entry needed.
[6 Mar 2010 11:07]
Bugs System
Pushed into 5.5.3-m3 (revid:alik@sun.com-20100306103849-hha31z2enhh7jwt3) (version source revid:vvaintroub@mysql.com-20091211201717-03qf8ckwiw0np80p) (merge vers: 5.6.0-beta) (pib:16)
[7 Mar 2010 1:30]
Paul DuBois
No changelog entry needed.
Description: This code in setup_conds() is a no-op: if (select_lex->conds_processed_with_permanent_arena || arena->is_conventional()) arena= 0; // For easier test since arena is not used at all. That's the only place we use conds_processed_with_permanent_arena, so that can be removed as well. How to repeat: Not Appliccable. I'm reporting this as a bug because I want a separate review. Suggested fix: Remove the code.