Bug #48806 mysql-test-run.pl --help should work even in the absence of binaries
Submitted: 16 Nov 2009 14:22 Modified: 17 Jun 2010 19:37
Reporter: Bjørn Munch Email Updates:
Status: Closed Impact on me:
Category:Tools: MTR / mysql-test-run Severity:S3 (Non-critical)
Version:5.1+ OS:Any
Assigned to: Bjørn Munch CPU Architecture:Any
Tags: mtr

[16 Nov 2009 14:22] Bjørn Munch
mysql-test-run.pl --help fails if no binaries are available:

** ERROR: Could not find 'my_safe_process' in './lib/My/SafeProcess/my_safe_process' or './My/SafeProcess/my_safe_process'
 at lib/My/SafeProcess.pm line 99
Compilation failed in require at ./mysql-test-run.pl line 74.
BEGIN failed--compilation aborted at ./mysql-test-run.pl line 74.

This shouldn't be necessary, since the .pl script itself is available and it exits after printing help info.

How to repeat:
Run mysql-test-run.pl --help directoy from a source repository without building first. It does work (apparently) as long as binaries exist, even if for the wrong platform.
[17 Nov 2009 11:15] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:


2856 Bjorn Munch	2009-11-17
      Bug #48806 mysql-test-run.pl --help should work even in the absence of binaries
      Searches for my_safe_process binary too early
      Put this into a sub() and call it after examining options (incl. --help)
[18 Nov 2009 15:05] Joerg Bruehe
Looks correct to me, no objections.
[18 Nov 2009 22:31] Timothy Smith
Patch looks fine, thanks.
[19 Nov 2009 11:27] Bjørn Munch
Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr, 6.0-codebase-mtr
[20 Feb 2010 9:31] Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20100220092844-jh07ayojyxn8uh9p) (version source revid:bjorn.munch@sun.com-20091119111729-sazk6qfk8qbwfq0y) (merge vers: 6.0.14-alpha) (pib:16)
[20 Feb 2010 9:34] Bugs System
Pushed into 5.5.3-m2 (revid:alik@sun.com-20100220092622-wvhh1vfy5tjq4mhu) (version source revid:bjorn.munch@sun.com-20091119092424-cpc87ef58xms6o9b) (merge vers: 5.5.0-beta) (pib:16)
[20 Feb 2010 9:37] Bugs System
Pushed into mysql-next-mr (revid:alik@sun.com-20100220092730-paoo5t9gcajs5dq8) (version source revid:bjorn.munch@sun.com-20091119092557-tm3cmjhd1jnlj0qc) (pib:16)
[23 Feb 2010 2:08] Paul DuBois
Changes to test suite. No changelog entry needed.

Setting report to Need Merge pending push to 5.1.x, Celosia.
[1 Mar 2010 8:47] Bugs System
Pushed into 5.1.45 (revid:joro@sun.com-20100301083827-xnimmrjg6bh33o1o) (version source revid:azundris@mysql.com-20100222175719-viuh0f3gdsrkgv0r) (merge vers: 5.1.45) (pib:16)
[1 Mar 2010 16:27] Paul DuBois
No changelog entry needed.
[17 Jun 2010 12:21] Bugs System
Pushed into 5.1.47-ndb-7.0.16 (revid:martin.skold@mysql.com-20100617114014-bva0dy24yyd67697) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)
[17 Jun 2010 13:08] Bugs System
Pushed into 5.1.47-ndb-6.2.19 (revid:martin.skold@mysql.com-20100617115448-idrbic6gbki37h1c) (version source revid:martin.skold@mysql.com-20100609140708-52rvuyq4q500sxkq) (merge vers: 5.1.45-ndb-6.2.19) (pib:16)
[17 Jun 2010 13:49] Bugs System
Pushed into 5.1.47-ndb-6.3.35 (revid:martin.skold@mysql.com-20100617114611-61aqbb52j752y116) (version source revid:vasil.dimov@oracle.com-20100331130613-8ja7n0vh36a80457) (merge vers: 5.1.46) (pib:16)