Bug #48149 | MTR should automatically skip SSL tests if SSL not supported | ||
---|---|---|---|
Submitted: | 19 Oct 2009 11:21 | Modified: | 18 Dec 2009 23:40 |
Reporter: | Bjørn Munch | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | Tools: MTR / mysql-test-run | Severity: | S3 (Non-critical) |
Version: | OS: | Any | |
Assigned to: | Bjørn Munch | CPU Architecture: | Any |
[19 Oct 2009 11:21]
Bjørn Munch
[19 Oct 2009 11:35]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/87291 2849 Bjorn Munch 2009-10-19 Bug #48149 MTR should automatically skip SSL tests if SSL not supported Knowledge of no SSL support is not used Skip tests the same way e.g. innodb tests are
[19 Oct 2009 12:10]
Magnus Blåudd
Patch is ok, but I can't find the "have_ssl_communication.inc" anywhere. If it exists, check in what way it differs from hav_ssl.inc, if the deifference is none, it should be removed.
[19 Oct 2009 12:13]
Bjørn Munch
have_ssl_communications.inc exists in 6.0-codebase but is identical to have_ssl.inc. I should probably remove from my patch for lower brances, and then question its existence in 6.0
[19 Oct 2009 12:18]
Bjørn Munch
Followup: looks like have_ssl_communications.inc is the original file, it has been renamed at some point with the result that 6.0 now has both....
[19 Oct 2009 13:53]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/87340 2849 Bjorn Munch 2009-10-19 Bug #48149 MTR should automatically skip SSL tests if SSL not supported Knowledge of no SSL support is not used Skip tests the same way e.g. innodb tests are Does not refer to have_ssl_communication.inc, will add this when merging to 6.0-codebase
[20 Oct 2009 10:25]
Bjørn Munch
First reviewer approved on IRC, so I ticked his box. Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr and 6.0-codebase-mtr
[22 Oct 2009 20:17]
Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20091022201524-0efl2fzebfuuf0vk) (version source revid:bjorn.munch@sun.com-20091020101018-lswq4s4mstoq8hu4) (merge vers: 6.0.14-alpha) (pib:13)
[22 Oct 2009 20:18]
Bugs System
Pushed into 5.5.0-beta (revid:alik@sun.com-20091022201318-jfvtrzd6lb07cwp5) (version source revid:bjorn.munch@sun.com-20091020100455-xzo8xiuwugnesoqd) (merge vers: 5.5.0-beta) (pib:13)
[22 Oct 2009 23:21]
Paul DuBois
Test suite change. No changelog entry needed. Setting report to NDI pending push into 5.1.x.
[23 Oct 2009 7:34]
Bugs System
Pushed into 5.1.41 (revid:bjorn.munch@sun.com-20091021073307-ummbh6668hvfxqjv) (version source revid:bjorn.munch@sun.com-20091021073307-ummbh6668hvfxqjv) (merge vers: 5.1.41) (pib:13)
[23 Oct 2009 15:17]
Paul DuBois
Test suite change. No changelog entry needed.
[18 Dec 2009 10:36]
Bugs System
Pushed into 5.1.41-ndb-7.1.0 (revid:jonas@mysql.com-20091218102229-64tk47xonu3dv6r6) (version source revid:jonas@mysql.com-20091218095730-26gwjidfsdw45dto) (merge vers: 5.1.41-ndb-7.1.0) (pib:15)
[18 Dec 2009 10:51]
Bugs System
Pushed into 5.1.41-ndb-6.2.19 (revid:jonas@mysql.com-20091218100224-vtzr0fahhsuhjsmt) (version source revid:jonas@mysql.com-20091217101452-qwzyaig50w74xmye) (merge vers: 5.1.41-ndb-6.2.19) (pib:15)
[18 Dec 2009 11:06]
Bugs System
Pushed into 5.1.41-ndb-6.3.31 (revid:jonas@mysql.com-20091218100616-75d9tek96o6ob6k0) (version source revid:jonas@mysql.com-20091217154335-290no45qdins5bwo) (merge vers: 5.1.41-ndb-6.3.31) (pib:15)
[18 Dec 2009 11:21]
Bugs System
Pushed into 5.1.41-ndb-7.0.11 (revid:jonas@mysql.com-20091218101303-ga32mrnr15jsa606) (version source revid:jonas@mysql.com-20091218064304-ezreonykd9f4kelk) (merge vers: 5.1.41-ndb-7.0.11) (pib:15)