Bug #48133 MTR should not dump entire history of mysqld log when failing to start server
Submitted: 18 Oct 2009 11:01 Modified: 18 Dec 2009 23:40
Reporter: Bjørn Munch Email Updates:
Status: Closed Impact on me:
None 
Category:Tools: MTR / mysql-test-run Severity:S3 (Non-critical)
Version:5.1+ OS:Any
Assigned to: Bjørn Munch CPU Architecture:Any
Tags: mtr

[18 Oct 2009 11:01] Bjørn Munch
Description:
This is a follow-up to Bug #46007, hence I assign the same reviewers. 

Now that we've added a function to extract relevant log from the server, we should use this also to limit what is dumped in the MTR log when it fails to start the server during a batch. Currently, it dumps the entire history, which would not be relevant and is just lots of "noise".

The log from the current test would be equivalent to the log from the server since it was attempted (re)started for this test.

There *may* be rare cases where something from the previous server could be of interest, but in those cases one can always go look up the server log when analyzing the failure.

How to repeat:
Seen e.g currently when trying to run 6.0-codebase with server built w/o ssl; rpl.rpl_ssl1 fails to start the server and this results in a huge server log dump.  But only the last few lines are in fact of any relevance.

Suggested fix:
Patch coming...
[18 Oct 2009 11:03] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/87240

2848 Bjorn Munch	2009-10-18
      Bug #48133 MTR should not dump entire history of mysqld log when failing to start server
      Don't print entire log, but use extract_server_log() introduced by 46007
[19 Oct 2009 13:48] Bjørn Munch
Pushed to 5.1-mtr, trunk-mtr, next-mr-mtr, 6.0-codebase-mtr
[22 Oct 2009 20:17] Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20091022201524-0efl2fzebfuuf0vk) (version source revid:bjorn.munch@sun.com-20091019132047-z83ij5ddiu7j34hu) (merge vers: 6.0.14-alpha) (pib:13)
[22 Oct 2009 20:18] Bugs System
Pushed into 5.5.0-beta (revid:alik@sun.com-20091022201318-jfvtrzd6lb07cwp5) (version source revid:bjorn.munch@sun.com-20091019131216-hx3jalmqpyd2j82n) (merge vers: 5.5.0-beta) (pib:13)
[22 Oct 2009 23:23] Paul DuBois
Test suite change. No changelog entry needed.

Setting report to NDI pending push into 5.1.x.
[23 Oct 2009 7:34] Bugs System
Pushed into 5.1.41 (revid:bjorn.munch@sun.com-20091021073307-ummbh6668hvfxqjv) (version source revid:bjorn.munch@sun.com-20091021073307-ummbh6668hvfxqjv) (merge vers: 5.1.41) (pib:13)
[23 Oct 2009 15:19] Paul DuBois
Test suite change. No changelog entry needed.
[18 Dec 2009 10:38] Bugs System
Pushed into 5.1.41-ndb-7.1.0 (revid:jonas@mysql.com-20091218102229-64tk47xonu3dv6r6) (version source revid:jonas@mysql.com-20091218095730-26gwjidfsdw45dto) (merge vers: 5.1.41-ndb-7.1.0) (pib:15)
[18 Dec 2009 10:53] Bugs System
Pushed into 5.1.41-ndb-6.2.19 (revid:jonas@mysql.com-20091218100224-vtzr0fahhsuhjsmt) (version source revid:jonas@mysql.com-20091217101452-qwzyaig50w74xmye) (merge vers: 5.1.41-ndb-6.2.19) (pib:15)
[18 Dec 2009 11:08] Bugs System
Pushed into 5.1.41-ndb-6.3.31 (revid:jonas@mysql.com-20091218100616-75d9tek96o6ob6k0) (version source revid:jonas@mysql.com-20091217154335-290no45qdins5bwo) (merge vers: 5.1.41-ndb-6.3.31) (pib:15)
[18 Dec 2009 11:22] Bugs System
Pushed into 5.1.41-ndb-7.0.11 (revid:jonas@mysql.com-20091218101303-ga32mrnr15jsa606) (version source revid:jonas@mysql.com-20091218064304-ezreonykd9f4kelk) (merge vers: 5.1.41-ndb-7.0.11) (pib:15)