Bug #46834 Test suite missing from RPMs
Submitted: 20 Aug 2009 13:25 Modified: 18 Dec 2009 11:46
Reporter: Jonathan Perkin Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Packaging Severity:S3 (Non-critical)
Version:5.1.32 OS:Linux
Assigned to: Jonathan Perkin CPU Architecture:Any

[20 Aug 2009 13:25] Jonathan Perkin
Description:
MySQL 5.1.32 introduced a number of mysql-test changes, notably in this case:

 === modified file 'mysql-test/Makefile.am'
 -benchdir_root=         $(prefix)
 -testdir =              $(benchdir_root)/mysql-test
 +testdir =      $(prefix)/mysql-test
 [...]

This would appear to be an optimisation, but the problem is that the RPM spec files override benchdir_root to ensure files are installed in the correct location:

 make DESTDIR=$RBR benchdir_root=%{_datadir} install

The end result is that all MySQL-test RPMs after 5.1.31 have been missing the entire test suite, due to it being installed into $prefix, i.e. "/".

 rpm -qpl MySQL-test-5.1.31-0.glibc23.i386.rpm | wc -l
 4161
 rpm -qpl MySQL-test-5.1.32-0.glibc23.i386.rpm | wc -l
 9

How to repeat:
Build RPM.

Suggested fix:
I have a diff which works, and will commit it in a tree once this bug report is created.
[20 Aug 2009 13:52] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/81173

2969 Jonathan Perkin	2009-08-20
      bug#46834: Test suite missing from RPMs
      
      Fix regression introduced in 5.1.32 by explicitly installing the test suite
      under datadir.
      
      This restores RPMs to the previous behaviour, but changes tar builds so that
      the test suite is now in ./share/mysql-test rather than ./mysql-test.  This, I
      believe, is the more technically correct location anyway, and ensures symmetry
      across packages.
[20 Aug 2009 13:59] Daniel Fischer
Moving mysql-test in 5.1 tarballs is an interface change that can't be done in 5.1

I disagree with moving the directory at all, because this will create an inconsistency for our testing tools.
[21 Aug 2009 6:41] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/81235

2969 Jonathan Perkin	2009-08-21
      bug#46834: Test suite missing from RPMs
      
      Fix regression introduced in 5.1.32, provide a testroot variable which
      can be overridden in RPM builds to install the test suite into the
      appropriate location.
[21 Aug 2009 10:44] Daniel Fischer
Last patch looks good.
[21 Aug 2009 12:00] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/81279

2971 Jonathan Perkin	2009-08-21
      Apply patch from bug#46834 to install the test suite in RPMs.
      modified:
        mysql-test/Makefile.am
        mysql-test/lib/My/SafeProcess/Makefile.am
        storage/ndb/test/run-test/Makefile.am
        support-files/mysql.spec.sh
[25 Aug 2009 9:23] Bugs System
Pushed into 5.1.39 (revid:jperkin@sun.com-20090824091334-6ktgrhq218vl7zq1) (version source revid:jperkin@sun.com-20090824091334-6ktgrhq218vl7zq1) (merge vers: 5.1.39) (pib:11)
[26 Aug 2009 12:35] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/81607

2970 Jonathan Perkin	2009-08-26
      bug#46834: Test suite missing from RPMs
      
      An additional change is requires to make the test suite work from
      installed RPMs.  mtr sets basedir=/usr to find binaries etc, so
      we need to look in share/mysql-test/suite for the test suites.
[1 Sep 2009 15:10] Paul Dubois
This actually made it into 5.1.38, so noting in 5.1.38 changelog:

The test suite was missing from RPM packages.

Leaving report in PQ status.
[2 Sep 2009 23:50] Bugs System
Pushed into 5.1.39 (revid:jperkin@sun.com-20090902234806-x2ak3azzjesvpp7p) (version source revid:jperkin@sun.com-20090902234806-x2ak3azzjesvpp7p) (merge vers: 5.1.39) (pib:11)
[4 Sep 2009 1:17] Paul Dubois
Setting report to NDI pending push into 5.4.x.
[14 Sep 2009 16:03] Bugs System
Pushed into 5.4.4-alpha (revid:alik@sun.com-20090914155317-m1g9wodmndzdj4l1) (version source revid:alik@sun.com-20090914155317-m1g9wodmndzdj4l1) (merge vers: 5.4.4-alpha) (pib:11)
[14 Sep 2009 19:51] Paul Dubois
Noted in 5.4.4 changelog.
[30 Sep 2009 8:18] Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20090929093622-1mooerbh12e97zux) (version source revid:jperkin@sun.com-20090921183308-hib541ftzava5qpa) (merge vers: 6.0.14-alpha) (pib:11)
[30 Sep 2009 8:20] Bugs System
Pushed into 5.4.5-beta (revid:alik@sun.com-20090925094254-tjl9eajkzwzgthoe) (version source revid:alik@sun.com-20090922142453-x275o41whpyezh4q) (merge vers: 5.4.4-beta) (pib:11)
[1 Oct 2009 5:58] Bugs System
Pushed into 5.1.39-ndb-6.3.28 (revid:jonas@mysql.com-20091001055605-ap2kiaarr7p40mmv) (version source revid:jonas@mysql.com-20091001055605-ap2kiaarr7p40mmv) (merge vers: 5.1.39-ndb-6.3.28) (pib:11)
[1 Oct 2009 7:25] Bugs System
Pushed into 5.1.39-ndb-7.0.9 (revid:jonas@mysql.com-20091001072547-kv17uu06hfjhgjay) (version source revid:jonas@mysql.com-20091001071652-irejtnumzbpsbgk2) (merge vers: 5.1.39-ndb-7.0.9) (pib:11)
[1 Oct 2009 13:25] Bugs System
Pushed into 5.1.39-ndb-7.1.0 (revid:jonas@mysql.com-20091001123013-g9ob2tsyctpw6zs0) (version source revid:jonas@mysql.com-20091001123013-g9ob2tsyctpw6zs0) (merge vers: 5.1.39-ndb-7.1.0) (pib:11)
[5 Oct 2009 10:50] Bugs System
Pushed into 5.1.39-ndb-6.2.19 (revid:jonas@mysql.com-20091005103850-dwij2dojwpvf5hi6) (version source revid:jonas@mysql.com-20090930185117-bhud4ek1y0hsj1nv) (merge vers: 5.1.39-ndb-6.2.19) (pib:11)
[5 Oct 2009 18:16] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/85788

3034 MySQL Build Team	2009-10-05
      Add fixes for Bug#46834: Test suite missing from RPMs
      
      Additional changes from the following commits:
      
      http://lists.mysql.com/commits/81279
      http://lists.mysql.com/commits/81607
      
      These were missed when scanning 'bzr log' for changes.
      modified:
        mysql-test/Makefile.am
        mysql-test/lib/My/SafeProcess/Makefile.am
        mysql-test/lib/mtr_cases.pm
        storage/ndb/test/run-test/Makefile.am
        support-files/mysql.spec.sh
[7 Oct 2009 14:43] Paul Dubois
The 5.4 fix has been pushed to 5.4.3.
[8 Oct 2009 13:48] Paul Dubois
Ignore previous comment.
[13 Oct 2009 18:31] Bugs System
Pushed into 5.1.41 (revid:build@mysql.com-20091013182142-vgsjky3t1v4btufv) (version source revid:build@mysql.com-20091013182142-vgsjky3t1v4btufv) (merge vers: 5.1.41) (pib:13)
[13 Oct 2009 23:34] Paul Dubois
Already noted in 5.1.38 changelog.
[21 Oct 2009 15:48] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/87667

2901 Jonathan Perkin	2009-10-21
      Apply missing patch from bug#46834 to mysql-trunk-bugfixing
[22 Oct 2009 6:33] Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20091022063126-l0qzirh9xyhp0bpc) (version source revid:alik@sun.com-20091019135554-s1pvptt6i750lfhv) (merge vers: 6.0.14-alpha) (pib:13)
[22 Oct 2009 7:05] Bugs System
Pushed into 5.5.0-beta (revid:alik@sun.com-20091022060553-znkmxm0g0gm6ckvw) (version source revid:alik@sun.com-20091019131937-nchb8tjk88jpfjav) (merge vers: 5.5.0-beta) (pib:13)
[22 Oct 2009 19:34] Paul Dubois
Noted in 5.5.0, 6.0.14 changelogs.
[31 Oct 2009 8:19] Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20091031081410-qkxmjsdzjmj840aq) (version source revid:jperkin@sun.com-20091022155158-md4nmhxjnfd3h5hj) (merge vers: 6.0.14-alpha) (pib:13)
[31 Oct 2009 8:21] Bugs System
Pushed into 5.5.0-beta (revid:alik@sun.com-20091031081110-58tn67wz7226hk03) (version source revid:jperkin@sun.com-20091022154852-45g1cx8t5pgyjpfu) (merge vers: 5.5.0-beta) (pib:13)
[3 Nov 2009 13:59] Bugs System
A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/89134

2906 Jonathan Perkin	2009-11-03
      Additional change required for bug#46834, find the std_data directory
      correctly in RPMs.
[13 Nov 2009 10:47] Bugs System
Pushed into 6.0.14-alpha (revid:alik@ibmvm-20091112022307-312ty3aow0i7zz0e) (version source revid:alik@ibmvm-20091112022307-312ty3aow0i7zz0e) (merge vers: 6.0.14-alpha) (pib:13)
[13 Nov 2009 10:47] Bugs System
Pushed into 5.5.0-beta (revid:alik@ibmvm-20091112022039-0oy0n7ns4ctd1zpp) (version source revid:alik@ibmvm-20091112022039-0oy0n7ns4ctd1zpp) (merge vers: 5.5.0-beta) (pib:13)
[18 Dec 2009 10:27] Bugs System
Pushed into 5.1.41-ndb-7.1.0 (revid:jonas@mysql.com-20091218102229-64tk47xonu3dv6r6) (version source revid:jonas@mysql.com-20091218095730-26gwjidfsdw45dto) (merge vers: 5.1.41-ndb-7.1.0) (pib:15)
[18 Dec 2009 10:43] Bugs System
Pushed into 5.1.41-ndb-6.2.19 (revid:jonas@mysql.com-20091218100224-vtzr0fahhsuhjsmt) (version source revid:jonas@mysql.com-20091217101452-qwzyaig50w74xmye) (merge vers: 5.1.41-ndb-6.2.19) (pib:15)
[18 Dec 2009 10:54] MC Brown
Added entry to 5.1.41-ndb-7.1.0
[18 Dec 2009 10:59] Bugs System
Pushed into 5.1.41-ndb-6.3.31 (revid:jonas@mysql.com-20091218100616-75d9tek96o6ob6k0) (version source revid:jonas@mysql.com-20091217154335-290no45qdins5bwo) (merge vers: 5.1.41-ndb-6.3.31) (pib:15)
[18 Dec 2009 11:08] MC Brown
Added entry to 5.1.41-ndb-6.2.19 and 5.1.41-ndb-6.3.31
[18 Dec 2009 11:13] Bugs System
Pushed into 5.1.41-ndb-7.0.11 (revid:jonas@mysql.com-20091218101303-ga32mrnr15jsa606) (version source revid:jonas@mysql.com-20091218064304-ezreonykd9f4kelk) (merge vers: 5.1.41-ndb-7.0.11) (pib:15)
[18 Dec 2009 11:46] MC Brown
Already documented in 5.1.41