MySQL Bugs: #46181: Upgrade Status details link popup goes away immediately

Bug #46181	Upgrade Status details link popup goes away immediately
Submitted:	14 Jul 2009 19:25	Modified:	27 Jul 2009 14:37
Reporter:	Marcos Palacios	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Enterprise Monitor: Web	Severity:	S3 (Non-critical)
Version:	2.1.0.1076	OS:	Any
Assigned to:	Josh Sled	CPU Architecture:	Any

Description:
After a service manager upgrade, if there are migration errors, we get the 'Upgrade Status:  there were errors in migration (details)' line and link in Settings > Manage Servers. When you click on 'details' the yellow 'An Error Occurred' popup shows up but goes away immediately (it happens even if the refresh rate is off).

Using firebug, we find that upon right-click on the "details" link and going to "Inspect element": in the firebug left panel, in the highlighted 
<a onClick="migrationErrorsPopup.show({'serverId': ____}, event)" href="#">
we get:
onClick="migrationErrorsPopup.show({},event)"
i.e., an empty 'serverId' parameter.

How to repeat:
- install a 1.3 svc mgr and agent
- use 'edit favorites' in the Monitor page to display six graphs (this is so the upgrade will have errors)
- upgrade the svc mgr, start it
- upgrade the agent, start it
- go to Settings > Manage Servers
- click the 'details' link in 'Upgrade Status:  there were errors in migration (details)'

Marcos Palacios writes: 
Found in bld 2.1.0.1076.

Josh Sled writes: 
revno: 7386
revision-id: jsled@asynchronous.org-20090721184741-s52c2p5td5az3xvi
parent: jsled@asynchronous.org-20090721180600-xau9jldtudde6j0z
committer: Josh Sled <jsled@asynchronous.org>
branch nick: local
timestamp: Tue 2009-07-21 14:47:41 -0400
message:
  EM-3447, Bug#46181: add a nop submit handler to prevent the popup from immediately refreshing the page before the errors have really been seen.

Bill Weber writes: 
patch available in builds >= 2.1.0.1080

Marcos Palacios writes: 
Verified fixed in build 2.1.0.1080.

An entry was added to the 2.1.0 changelog:

After a Service Manager upgrade, if there were migration errors, the message “Upgrade Status: there were errors in migration (details)” was displayed on the Settings, Manage Servers page. When the details link was clicked the yellow “An Error Occurred” popup was briefly displayed before disappearing, making it impossible to determine the details of the error.