Bug #46164 | memory leak in mysqltest after parse error with --debug | ||
---|---|---|---|
Submitted: | 14 Jul 2009 9:15 | Modified: | 19 Dec 2009 0:09 |
Reporter: | Sven Sandberg | Email Updates: | |
Status: | Closed | Impact on me: | |
Category: | Tools: MTR / mysql-test-run | Severity: | S3 (Non-critical) |
Version: | 5.1 | OS: | Linux |
Assigned to: | Bjørn Munch | CPU Architecture: | Any |
Tags: | memory leak, mysqltest |
[14 Jul 2009 9:15]
Sven Sandberg
[18 Aug 2009 13:27]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/80988 2819 Bjorn Munch 2009-08-18 Bug #46164 memory leak in mysqltest after parse error with --debug Moved some dynstr_free() further up
[18 Aug 2009 13:30]
Bjørn Munch
Reproduced using valgrind; those strings do accumulate also if the SQL errors are ignored. Fixed (and verified) by moving dynstr_free() a bit further up.
[27 Aug 2009 10:05]
Magnus Blåudd
Godd, freeing the allocated memory as soon it's not used anymore in the function. In general I would say that mysqltest is not written to properly clean up memory properly before _every_ place it can die since that would mostly clutter the cod up even more and it's just going to die anyway so just let the OS handle it. But in cases like this when it's kind of a normal exit point it makes sense to fix it, especially since it does not lead to code duplication. In the long run, the dynamic string C functions could be wrapped in a C++ wrapper and let the destructor take care of it.
[27 Aug 2009 10:35]
Bugs System
A patch for this bug has been committed. After review, it may be pushed to the relevant source trees for release in the next version. You can access the patch from: http://lists.mysql.com/commits/81700 2820 Bjorn Munch 2009-08-27 [merge] Bug #46164 memory leak in mysqltest after parse error with --debug Moved some dynstr_free() further up
[27 Aug 2009 10:51]
Bjørn Munch
Pushed to azalea-mtr (soon to be renamed next-mtr) and 5.1-mtr
[3 Sep 2009 17:11]
Bugs System
Pushed into 5.1.40 (revid:bjorn.munch@sun.com-20090903170735-679d64zp580wl39j) (version source revid:bjorn.munch@sun.com-20090903170735-679d64zp580wl39j) (merge vers: 5.1.40) (pib:11)
[4 Sep 2009 0:59]
Paul DuBois
Test suite change. No changelog entry needed. Setting report to NDI pending push into 5.4.x.
[30 Sep 2009 8:16]
Bugs System
Pushed into 6.0.14-alpha (revid:alik@sun.com-20090929093622-1mooerbh12e97zux) (version source revid:alik@sun.com-20090922182109-vs5ign07cwht12z6) (merge vers: 6.0.14-alpha) (pib:11)
[30 Sep 2009 8:20]
Bugs System
Pushed into 5.4.5-beta (revid:alik@sun.com-20090925094254-tjl9eajkzwzgthoe) (version source revid:alik@sun.com-20090922142453-x275o41whpyezh4q) (merge vers: 5.4.4-beta) (pib:11)
[30 Sep 2009 19:43]
Paul DuBois
Test suite change. No changelog entry needed.
[18 Dec 2009 10:38]
Bugs System
Pushed into 5.1.41-ndb-7.1.0 (revid:jonas@mysql.com-20091218102229-64tk47xonu3dv6r6) (version source revid:jonas@mysql.com-20091218095730-26gwjidfsdw45dto) (merge vers: 5.1.41-ndb-7.1.0) (pib:15)
[18 Dec 2009 10:53]
Bugs System
Pushed into 5.1.41-ndb-6.2.19 (revid:jonas@mysql.com-20091218100224-vtzr0fahhsuhjsmt) (version source revid:jonas@mysql.com-20091217101452-qwzyaig50w74xmye) (merge vers: 5.1.41-ndb-6.2.19) (pib:15)
[18 Dec 2009 11:08]
Bugs System
Pushed into 5.1.41-ndb-6.3.31 (revid:jonas@mysql.com-20091218100616-75d9tek96o6ob6k0) (version source revid:jonas@mysql.com-20091217154335-290no45qdins5bwo) (merge vers: 5.1.41-ndb-6.3.31) (pib:15)
[18 Dec 2009 11:22]
Bugs System
Pushed into 5.1.41-ndb-7.0.11 (revid:jonas@mysql.com-20091218101303-ga32mrnr15jsa606) (version source revid:jonas@mysql.com-20091218064304-ezreonykd9f4kelk) (merge vers: 5.1.41-ndb-7.0.11) (pib:15)